summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSubrata Banik <subratabanik@google.com>2024-02-28 19:02:24 +0530
committerJulius Werner <jwerner@chromium.org>2024-02-29 00:11:09 +0000
commit7b7bddc015a2db82820f55c781106f1bbc24b0c3 (patch)
tree6d74476325c4b942f2bb29b2b6b6fc7a61632e88
parent8d9ce363f83b56268ec3051c1e04adb8af8813e4 (diff)
Revert "lib: Explicitly declare heap as NOLOAD"
This reverts commit 99bf23c9e73c7492ee9d5c1f208bceedf3ff7cb5. This patch causes the boot regression at depthcharge with below error signature. Able to boot to OS after reverting this patch. ``` Starting depthcharge on Rex... WARNING: can't convert coreboot GPIOs, 'lid' won't be resampled at runtime! WARNING: can't convert coreboot GPIOs, 'power' won't be resampled at runtime! fw_config match found: AUDIO=MAX98360_ALC5682I_I2S Looking for NVMe Controller 0x30069a60 @ 00:06:00 libc/lp_vboot.c:25 vboot_get_context(): vboot workbuf could not be initialized, error: 0x10080030 Ready for GDB connection. ``` Change-Id: I8d49e2dc49cd2935a9d8023c989869ec9558039e Signed-off-by: Subrata Banik <subratabanik@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80775 Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Kapil Porwal <kapilporwal@google.com> Reviewed-by: Caveh Jalali <caveh@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/lib/program.ld2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/program.ld b/src/lib/program.ld
index 6d72d9ef0e..21f4be8d32 100644
--- a/src/lib/program.ld
+++ b/src/lib/program.ld
@@ -131,7 +131,7 @@
#endif
#if ENV_HAS_HEAP_SECTION
-.heap . (NOLOAD) : {
+.heap . : {
. = ALIGN(ARCH_POINTER_ALIGN_SIZE);
_heap = .;
. += CONFIG_HEAP_SIZE;