aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAmanda Huang <amanda_hwang@compal.corp-partner.google.com>2024-06-11 16:02:19 +0800
committerFelix Held <felix-coreboot@felixheld.de>2024-06-12 11:02:13 +0000
commit74472453ed2165e9664de92f65f502a5bf7ae696 (patch)
treecd27dae3175847496e5a1fd5baa47f619efd75b1
parent24d66f8303dbde402a0932083a5a224d50757b12 (diff)
mb/google/trulo/var/orisa: Disable storage devices based on fw_config
Disable devices in variant.c instead of adding probe statements to devicetree because storage devices need to be enabled when fw_config is unprovisioned. BUG=b:345112878 BRANCH=firmware-nissa-15217.B TEST=emerge-nissa coreboot chromeos-bootimage Change-Id: I1e5e49c1baa8d2b00134c26cc3b69aa15712b512 Signed-off-by: Amanda Huang <amanda_hwang@compal.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/82907 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Kapil Porwal <kapilporwal@google.com> Reviewed-by: Eric Lai <ericllai@google.com>
-rw-r--r--src/mainboard/google/brya/variants/orisa/Makefile.mk4
-rw-r--r--src/mainboard/google/brya/variants/orisa/fw_config.c42
-rw-r--r--src/mainboard/google/brya/variants/orisa/overridetree.cb4
-rw-r--r--src/mainboard/google/brya/variants/orisa/variant.c28
4 files changed, 78 insertions, 0 deletions
diff --git a/src/mainboard/google/brya/variants/orisa/Makefile.mk b/src/mainboard/google/brya/variants/orisa/Makefile.mk
index cc61780e02..c0c42324f8 100644
--- a/src/mainboard/google/brya/variants/orisa/Makefile.mk
+++ b/src/mainboard/google/brya/variants/orisa/Makefile.mk
@@ -1,7 +1,11 @@
## SPDX-License-Identifier: GPL-2.0-only
bootblock-y += gpio.c
+
romstage-y += gpio.c
romstage-y += memory.c
+
+ramstage-$(CONFIG_FW_CONFIG) += fw_config.c
ramstage-y += gpio.c
ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_HDA_VERB) += hda_verb.c
+ramstage-y += variant.c
diff --git a/src/mainboard/google/brya/variants/orisa/fw_config.c b/src/mainboard/google/brya/variants/orisa/fw_config.c
new file mode 100644
index 0000000000..800fc1f205
--- /dev/null
+++ b/src/mainboard/google/brya/variants/orisa/fw_config.c
@@ -0,0 +1,42 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <baseboard/gpio.h>
+#include <baseboard/variants.h>
+#include <console/console.h>
+#include <fw_config.h>
+
+static const struct pad_config emmc_disable_pads[] = {
+ /* I7 : EMMC_CMD */
+ PAD_NC(GPP_I7, NONE),
+ /* I8 : EMMC_D0 */
+ PAD_NC(GPP_I8, NONE),
+ /* I9 : EMMC_D1 */
+ PAD_NC(GPP_I9, NONE),
+ /* I10 : EMMC_D2 */
+ PAD_NC(GPP_I10, NONE),
+ /* I11 : EMMC_D3 */
+ PAD_NC(GPP_I11, NONE),
+ /* I12 : EMMC_D4 */
+ PAD_NC(GPP_I12, NONE),
+ /* I13 : EMMC_D5 */
+ PAD_NC(GPP_I13, NONE),
+ /* I14 : EMMC_D6 */
+ PAD_NC(GPP_I14, NONE),
+ /* I15 : EMMC_D7 */
+ PAD_NC(GPP_I15, NONE),
+ /* I16 : EMMC_RCLK */
+ PAD_NC(GPP_I16, NONE),
+ /* I17 : EMMC_CLK */
+ PAD_NC(GPP_I17, NONE),
+ /* I18 : EMMC_RST_L */
+ PAD_NC(GPP_I18, NONE),
+};
+
+void fw_config_gpio_padbased_override(struct pad_config *padbased_table)
+{
+ if (fw_config_is_provisioned() && !fw_config_probe(FW_CONFIG(STORAGE, STORAGE_EMMC))) {
+ printk(BIOS_INFO, "Disable eMMC GPIO pins.\n");
+ gpio_padbased_override(padbased_table, emmc_disable_pads,
+ ARRAY_SIZE(emmc_disable_pads));
+ }
+}
diff --git a/src/mainboard/google/brya/variants/orisa/overridetree.cb b/src/mainboard/google/brya/variants/orisa/overridetree.cb
index 642722259f..600eb02422 100644
--- a/src/mainboard/google/brya/variants/orisa/overridetree.cb
+++ b/src/mainboard/google/brya/variants/orisa/overridetree.cb
@@ -3,6 +3,10 @@ fw_config
option THERMAL_SOLUTION_6W 0
option THERMAL_SOLUTION_15W 1
end
+ field STORAGE 30 31
+ option STORAGE_EMMC 0
+ option STORAGE_UFS 1
+ end
end
chip soc/intel/alderlake
diff --git a/src/mainboard/google/brya/variants/orisa/variant.c b/src/mainboard/google/brya/variants/orisa/variant.c
new file mode 100644
index 0000000000..f34fb2698b
--- /dev/null
+++ b/src/mainboard/google/brya/variants/orisa/variant.c
@@ -0,0 +1,28 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <baseboard/variants.h>
+#include <device/device.h>
+#include <fw_config.h>
+
+void variant_devtree_update(void)
+{
+ struct device *emmc = DEV_PTR(emmc);
+ struct device *ufs = DEV_PTR(ufs);
+ struct device *ish = DEV_PTR(ish);
+
+ if (!fw_config_is_provisioned()) {
+ printk(BIOS_INFO, "fw_config unprovisioned so enable all storage devices\n");
+ return;
+ }
+
+ if (!fw_config_probe(FW_CONFIG(STORAGE, STORAGE_EMMC))) {
+ printk(BIOS_INFO, "eMMC disabled by fw_config\n");
+ emmc->enabled = 0;
+ }
+
+ if (!fw_config_probe(FW_CONFIG(STORAGE, STORAGE_UFS))) {
+ printk(BIOS_INFO, "UFS disabled by fw_config\n");
+ ufs->enabled = 0;
+ ish->enabled = 0;
+ }
+}