diff options
| author | Eric Lai <eric_lai@quanta.corp-partner.google.com> | 2022-03-14 17:00:39 +0800 |
|---|---|---|
| committer | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2022-03-17 04:57:43 +0000 |
| commit | 6e3d42ab4269ca6c82db9a129bff2429c42f5aeb (patch) | |
| tree | 2252783146cfca79f15aba13f1792a6b61735de7 | |
| parent | 4573ca42e675fb8b61bcf05591d8d4d05f93944d (diff) | |
drivers/wifi/generic: Fix is_cnvi function
dev->ops = &wifi_cnvi_ops need is_cnvi be true. This cause the exclusive
statement so is_cnvi never be true in !DEVTREE_EARLY.
BUG=b:224317408
TEST=no assertion in coreboot.
[EMERG] ASSERTION ERROR: file 'src/acpi/acpigen_pci.c', line 24
Signed-off-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Change-Id: I1ca6312ce164c43021686b483f6579164614cede
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62784
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kangheui Won <khwon@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
| -rw-r--r-- | src/drivers/wifi/generic/generic.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/drivers/wifi/generic/generic.c b/src/drivers/wifi/generic/generic.c index a6936f1d11..5aaedaeafe 100644 --- a/src/drivers/wifi/generic/generic.c +++ b/src/drivers/wifi/generic/generic.c @@ -43,11 +43,7 @@ struct device_operations wifi_cnvi_ops = { static bool is_cnvi(const struct device *dev) { -#if !DEVTREE_EARLY - return dev && dev->ops == &wifi_cnvi_ops; -#else return dev && dev->path.type != DEVICE_PATH_PCI; -#endif } bool wifi_generic_cnvi_ddr_rfim_enabled(const struct device *dev) |