diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2019-11-04 18:57:06 +0100 |
|---|---|---|
| committer | Paul Fagerburg <pfagerburg@chromium.org> | 2022-09-19 14:57:12 +0000 |
| commit | 6317aff5b3028ad44b7885b6b63263c55b5aadb3 (patch) | |
| tree | 1d382cf2530484955fb52774f7745c077e5f00c4 | |
| parent | b6cce33b18a7eb5f3e19bff4f102ec18ef30435a (diff) | |
Kconfig: Allow x86 to compress pre-ram stages if not run XIP
On the intel/glkrvp
compressed:
- romstage: 29659
- verstage: 31303
non compressed:
- romstage: 46244
- verstage: 47012
On qemu (with some additional patch to not run XIP)
compressed:
- romstage: 11203
non compressed:
- romstage: 13924
Even with a small romstage the size improvements are substantial,
which should result in a speedup when loading the stage. On the
up/squared loading romstage is sped up by 9ms.
TESTED: successfully boot the up/squared & google/vilboz.
Change-Id: Iac24d243c4bd4cb8c1db14a8e9fc43f508c2cd5d
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36613
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
| -rw-r--r-- | src/Kconfig | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/Kconfig b/src/Kconfig index 0d3879ecbf..38126fa2b5 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -173,14 +173,14 @@ config COMPRESS_RAMSTAGE config COMPRESS_PRERAM_STAGES bool "Compress romstage and verstage with LZ4" - depends on !ARCH_X86 && (HAVE_ROMSTAGE || HAVE_VERSTAGE) + depends on (HAVE_ROMSTAGE || HAVE_VERSTAGE) && NO_XIP_EARLY_STAGES # Default value set at the end of the file help Compress romstage and (if it exists) verstage with LZ4 to save flash space and speed up boot, since the time for reading the image from SPI (and in the vboot case verifying it) is usually much greater than the - time spent decompressing. Doesn't work for XIP stages (assume all - ARCH_X86 for now) for obvious reasons. + time spent decompressing. Doesn't work for XIP stages for obvious + reasons. config COMPRESS_BOOTBLOCK bool @@ -1370,7 +1370,7 @@ config COMPRESS_RAMSTAGE default y if !UNCOMPRESSED_RAMSTAGE config COMPRESS_PRERAM_STAGES - depends on !ARCH_X86 + depends on (HAVE_ROMSTAGE || HAVE_VERSTAGE) && NO_XIP_EARLY_STAGES default y config INCLUDE_CONFIG_FILE |