diff options
| author | Karthikeyan Ramasubramanian <kramasub@google.com> | 2024-08-19 18:41:31 -0600 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2024-08-22 13:54:06 +0000 |
| commit | 60d9121073e28c8457ba38e34a0dd13054b29ea2 (patch) | |
| tree | fe98313f1ca332cbb59958eec056a8e6e539f8fe | |
| parent | 6bdc3becfd99880474b849ec32dc23dddf3cbf11 (diff) | |
mb/google/brox: Enable storage devices on unprovisioned fw_config
Storage devices are very critical to boot to OS. When probe list is
defined for storage devices, all of them get disabled when fw_config is
unprovisioned - a typical situation in the factory. Fix this by
configuring the storage devices in device/override tree to probe and
enable them when fw_config is unprovisioned.
BUG=None
TEST=Build Brox firmware and boot to OS when fw_config is unprovisioned.
Change-Id: I0537f7d1d83293b9b3408f0aadf11fa2e7908163
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83984
Reviewed-by: Eric Lai <ericllai@google.com>
Reviewed-by: Jon Murphy <jpmurphy@google.com>
Reviewed-by: Bob Moragues <moragues@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
3 files changed, 9 insertions, 0 deletions
diff --git a/src/mainboard/google/brox/variants/brox/overridetree.cb b/src/mainboard/google/brox/variants/brox/overridetree.cb index 21774f88d2..18baa5d590 100644 --- a/src/mainboard/google/brox/variants/brox/overridetree.cb +++ b/src/mainboard/google/brox/variants/brox/overridetree.cb @@ -290,6 +290,7 @@ chip soc/intel/alderlake .flags = PCIE_RP_LTR | PCIE_RP_AER, }" probe STORAGE STORAGE_NVME + probe unprovisioned end device ref pcie_rp5 on register "pch_pcie_rp[PCH_RP(5)]" = "{ @@ -327,9 +328,11 @@ chip soc/intel/alderlake end probe ISH ISH_ENABLE probe STORAGE STORAGE_UFS + probe unprovisioned end device ref ufs on probe STORAGE STORAGE_UFS + probe unprovisioned end end end diff --git a/src/mainboard/google/brox/variants/jubilant/overridetree.cb b/src/mainboard/google/brox/variants/jubilant/overridetree.cb index 0613ff93f5..01ac731cf5 100644 --- a/src/mainboard/google/brox/variants/jubilant/overridetree.cb +++ b/src/mainboard/google/brox/variants/jubilant/overridetree.cb @@ -295,6 +295,7 @@ chip soc/intel/alderlake }" probe STORAGE STORAGE_NVME probe STORAGE STORAGE_UNKNOWN + probe unprovisioned end device ref pcie_rp5 on register "pch_pcie_rp[PCH_RP(5)]" = "{ @@ -333,10 +334,12 @@ chip soc/intel/alderlake end probe STORAGE STORAGE_UFS probe STORAGE STORAGE_UNKNOWN + probe unprovisioned end device ref ufs on probe STORAGE STORAGE_UFS probe STORAGE STORAGE_UNKNOWN + probe unprovisioned end device ref i2c0 on chip drivers/i2c/generic diff --git a/src/mainboard/google/brox/variants/lotso/overridetree.cb b/src/mainboard/google/brox/variants/lotso/overridetree.cb index e7c5f6b70b..6876b64de8 100644 --- a/src/mainboard/google/brox/variants/lotso/overridetree.cb +++ b/src/mainboard/google/brox/variants/lotso/overridetree.cb @@ -333,6 +333,7 @@ chip soc/intel/alderlake }" probe STORAGE STORAGE_UNKNOWN probe STORAGE STORAGE_NVME + probe unprovisioned end device ref pcie_rp5 on register "pch_pcie_rp[PCH_RP(5)]" = "{ @@ -382,10 +383,12 @@ chip soc/intel/alderlake end probe STORAGE STORAGE_UNKNOWN probe STORAGE STORAGE_UFS + probe unprovisioned end device ref ufs on probe STORAGE STORAGE_UNKNOWN probe STORAGE STORAGE_UFS + probe unprovisioned end device ref i2c0 on chip drivers/i2c/generic |