diff options
| author | Paul Menzel <paulepanter@users.sourceforge.net> | 2013-02-24 14:27:03 +0100 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2013-02-25 18:49:15 +0100 |
| commit | 5f20b3522212f58b5e6858ff7028fb5a8e0879f5 (patch) | |
| tree | ea91300de4a62ae91f0fd84faa22ad42f45765d3 | |
| parent | 30901baabcf1e26f3ba4cd32f5bd90eb1c6ed35c (diff) | |
QEMU x86: northbridge.c: Name enabling device function to `northbridge_enable`
Similar to the discussion on the coreboot list [1]
Am Freitag, den 22.02.2013, 02:17 +0100 schrieb Peter Stuge:
[…]
> Function names should try to be descriptive. "enable_dev" is not very
> descriptive. I like "mainboard_enable" because it makes output such
> as
>
> printk("%s: foo", __func__);
>
> useful.
rename the function for the northbridge to `northbridge_enable`.
[1] http://www.coreboot.org/pipermail/coreboot/2013-February/074549.html
Change-Id: I262311ec511e394550330214621b8c37780c1d4e
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: http://review.coreboot.org/2496
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martin.roth@se-eng.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
| -rw-r--r-- | src/mainboard/emulation/qemu-x86/northbridge.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/emulation/qemu-x86/northbridge.c b/src/mainboard/emulation/qemu-x86/northbridge.c index 7c36c0a469..3e7fbb99dd 100644 --- a/src/mainboard/emulation/qemu-x86/northbridge.c +++ b/src/mainboard/emulation/qemu-x86/northbridge.c @@ -135,7 +135,7 @@ static struct device_operations pci_domain_ops = { #endif }; -static void enable_dev(struct device *dev) +static void northbridge_enable(struct device *dev) { /* Set the operations if it is a special bus type */ if (dev->path.type == DEVICE_PATH_DOMAIN) { @@ -146,5 +146,5 @@ static void enable_dev(struct device *dev) struct chip_operations mainboard_emulation_qemu_x86_ops = { CHIP_NAME("QEMU Northbridge") - .enable_dev = enable_dev, + .enable_dev = northbridge_enable, }; |