summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPratikkumar Prajapati <pratikkumar.v.prajapati@intel.com>2023-08-15 11:45:15 -0700
committerMartin L Roth <gaumless@gmail.com>2023-09-01 21:22:37 +0000
commit5849f5bd323d496977f50d2ffa1dbdc5ba3ecaf3 (patch)
tree8772129a3ca27a2d9e4a24c88cace770a5b76ae0
parent458e2553f5a3385b776ba50b948b07e00c2fdd27 (diff)
soc/intel/common: Rename crashlog macros
Remove MAILBOX word from CPU_CRASHLOG_MAILBOX_WAIT_STALL and CPU_CRASHLOG_MAILBOX_WAIT_TIMEOUT macros, because they can be used for other interface as well. BUG=b:262501347 TEST=Able to build google/rex. Change-Id: I62b04fa4b05c427db494a536ca6504db02dfeb68 Signed-off-by: Pratikkumar Prajapati <pratikkumar.v.prajapati@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/77236 Reviewed-by: Subrata Banik <subratabanik@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/soc/intel/common/block/crashlog/crashlog.c6
-rw-r--r--src/soc/intel/common/block/include/intelblocks/crashlog.h4
2 files changed, 5 insertions, 5 deletions
diff --git a/src/soc/intel/common/block/crashlog/crashlog.c b/src/soc/intel/common/block/crashlog/crashlog.c
index 5b098bb583..fa3603334b 100644
--- a/src/soc/intel/common/block/crashlog/crashlog.c
+++ b/src/soc/intel/common/block/crashlog/crashlog.c
@@ -114,13 +114,13 @@ int cpu_cl_poll_mailbox_ready(u32 cl_mailbox_addr)
do {
cl_mailbox_interface.data = read32((u32 *)cl_mailbox_addr);
- udelay(CPU_CRASHLOG_MAILBOX_WAIT_STALL);
+ udelay(CPU_CRASHLOG_WAIT_STALL);
stall_cnt++;
} while ((cl_mailbox_interface.fields.busy == 1)
- && stall_cnt < CPU_CRASHLOG_MAILBOX_WAIT_TIMEOUT);
+ && stall_cnt < CPU_CRASHLOG_WAIT_TIMEOUT);
if ((cl_mailbox_interface.fields.busy == 1)
- && (stall_cnt >= CPU_CRASHLOG_MAILBOX_WAIT_TIMEOUT)) {
+ && (stall_cnt >= CPU_CRASHLOG_WAIT_TIMEOUT)) {
printk(BIOS_ERR, "CPU crashlog mailbox timed out.\n");
return 0;
}
diff --git a/src/soc/intel/common/block/include/intelblocks/crashlog.h b/src/soc/intel/common/block/include/intelblocks/crashlog.h
index ceaa9f1409..23d4861557 100644
--- a/src/soc/intel/common/block/include/intelblocks/crashlog.h
+++ b/src/soc/intel/common/block/include/intelblocks/crashlog.h
@@ -17,8 +17,8 @@
/* CPU CrashLog Mailbox commands */
#define CPU_CRASHLOG_CMD_DISABLE 0
#define CPU_CRASHLOG_CMD_CLEAR 2
-#define CPU_CRASHLOG_MAILBOX_WAIT_STALL 1
-#define CPU_CRASHLOG_MAILBOX_WAIT_TIMEOUT 1000
+#define CPU_CRASHLOG_WAIT_STALL 1
+#define CPU_CRASHLOG_WAIT_TIMEOUT 1000
#define CPU_CRASHLOG_DISC_TAB_GUID_VALID 0x1600
#define CRASHLOG_SIZE_DEBUG_PURPOSE 0x640