diff options
| author | Martin Roth <gaumless@gmail.com> | 2023-10-23 18:43:36 -0600 |
|---|---|---|
| committer | Martin L Roth <gaumless@gmail.com> | 2023-10-25 15:20:50 +0000 |
| commit | 4bae3237464889454cff9cbdec7bd7ba61d3dccd (patch) | |
| tree | 06f7d8590c64c0c734d6e54940d1267017371b77 | |
| parent | e6f19240de18e1b48b7a31875634bcc8045d9e8f (diff) | |
mb/prodrive/hermes: Skip NULL check after setting up struct
By calling get_board_settings() when board_cfg is initialized, board_cfg
is guaranteed not to be NULL, so don't check to see if it's NULL.
Found-by: Coverity Scan #1513079
Signed-off-by: Martin Roth <gaumless@gmail.com>
Change-Id: I61105be9ed71ff30efdda66d2cbfcaf54d70053f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78618
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
| -rw-r--r-- | src/mainboard/prodrive/hermes/romstage.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/prodrive/hermes/romstage.c b/src/mainboard/prodrive/hermes/romstage.c index a479bd51af..a3028c2dfd 100644 --- a/src/mainboard/prodrive/hermes/romstage.c +++ b/src/mainboard/prodrive/hermes/romstage.c @@ -83,7 +83,7 @@ void mainboard_memory_init_params(FSPM_UPD *memupd) cannonlake_memcfg_init(&memupd->FspmConfig, &baseboard_mem_cfg); /* Tell FSP-M about the desired primary video adapter so that GGC is set up properly */ - if (board_cfg && board_cfg->primary_video == PRIMARY_VIDEO_INTEL) + if (board_cfg->primary_video == PRIMARY_VIDEO_INTEL) memupd->FspmConfig.PrimaryDisplay = 0; /* iGPU is primary */ /* Overwrite memupd */ |