summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSean Rhodes <sean@starlabs.systems>2022-02-17 14:24:03 +0000
committerFelix Held <felix-coreboot@felixheld.de>2022-03-09 14:18:59 +0000
commit45041caaba3de044207bacd7ef4286e66707f662 (patch)
tree6a130f06d8ca55971eafcba8f6ac0dd8e84af5bc
parent7dea2e5548fbc27a953752baf45a41f4d2254a63 (diff)
ec/starlabs: Correct Keyboard Backlight offsets for GLK
Correct the offsets used for the keyboard backlight control: ECRAM_KBL_STATE 0x19 ECRAM_KBL_BRIGHTNESS 0x18 Signed-off-by: Sean Rhodes <sean@starlabs.systems> Change-Id: I23bac43301635e6b18f1cbd28311e7210b049c70 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62126 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Andy Pont <andy.pont@sdcsystems.com> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
-rw-r--r--src/ec/starlabs/merlin/variants/glk/ecdefs.h4
-rw-r--r--src/ec/starlabs/merlin/variants/glk/emem.asl2
2 files changed, 3 insertions, 3 deletions
diff --git a/src/ec/starlabs/merlin/variants/glk/ecdefs.h b/src/ec/starlabs/merlin/variants/glk/ecdefs.h
index 5f43991aef..b09ffc76f0 100644
--- a/src/ec/starlabs/merlin/variants/glk/ecdefs.h
+++ b/src/ec/starlabs/merlin/variants/glk/ecdefs.h
@@ -15,8 +15,8 @@
/* EC RAM offsets. */
#define ECRAM_TRACKPAD_STATE 0x14
-#define ECRAM_KBL_STATE 0x18
-#define ECRAM_KBL_BRIGHTNESS 0x19
+#define ECRAM_KBL_STATE 0x19
+#define ECRAM_KBL_BRIGHTNESS 0x18
#define ECRAM_KBL_TIMEOUT 0x1a
#define ECRAM_FN_LOCK_STATE 0x2c
#define ECRAM_FN_CTRL_REVERSE 0x2d
diff --git a/src/ec/starlabs/merlin/variants/glk/emem.asl b/src/ec/starlabs/merlin/variants/glk/emem.asl
index d30b58c5bf..9173745fb5 100644
--- a/src/ec/starlabs/merlin/variants/glk/emem.asl
+++ b/src/ec/starlabs/merlin/variants/glk/emem.asl
@@ -20,8 +20,8 @@ Field (ECF2, ByteAcc, Lock, Preserve)
AFG3, 8, // After G3
CLTP, 8, // Close Trackpad
WKOL, 8, // Wake on Lid
- KLSE, 8, // Keyboard Backlight State
KLBE, 8, // Keyboard Backlight Brightness
+ KLSE, 8, // Keyboard Backlight State
Offset(0x1a),
KLTE, 8, // Keyboard Backlight Timeout