diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2024-05-24 14:16:20 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2024-05-25 14:45:43 +0000 |
| commit | 4244527d8ccf2256c567ec4c4091c5edad72d06c (patch) | |
| tree | 98770702a6604114a06678f44396d703fb91dc74 | |
| parent | 824d9303f22b8adc91752464d5f2ac166683e588 (diff) | |
acpi: add and use defines for LAPIC feature flags
Both the processor local APIC structure and the processor local x2APIC
structure use the same flag bit definitions. ACPI spec 6.4 was used as a
reference.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I8101c2ea874c8b12b130dbe9a0a7e0f0d94adffa
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82641
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
| -rw-r--r-- | src/acpi/acpi_apic.c | 4 | ||||
| -rw-r--r-- | src/include/acpi/acpi.h | 4 |
2 files changed, 6 insertions, 2 deletions
diff --git a/src/acpi/acpi_apic.c b/src/acpi/acpi_apic.c index 9098811932..ebff44f2bb 100644 --- a/src/acpi/acpi_apic.c +++ b/src/acpi/acpi_apic.c @@ -11,7 +11,7 @@ static int acpi_create_madt_lapic(acpi_madt_lapic_t *lapic, u8 cpu, u8 apic) { lapic->type = LOCAL_APIC; /* Local APIC structure */ lapic->length = sizeof(acpi_madt_lapic_t); - lapic->flags = (1 << 0); /* Processor/LAPIC enabled */ + lapic->flags = ACPI_MADT_LAPIC_ENABLED; lapic->processor_id = cpu; lapic->apic_id = apic; @@ -23,7 +23,7 @@ static int acpi_create_madt_lx2apic(acpi_madt_lx2apic_t *lapic, u32 cpu, u32 api lapic->type = LOCAL_X2APIC; /* Local APIC structure */ lapic->reserved = 0; lapic->length = sizeof(acpi_madt_lx2apic_t); - lapic->flags = (1 << 0); /* Processor/LAPIC enabled */ + lapic->flags = ACPI_MADT_LAPIC_ENABLED; lapic->processor_id = cpu; lapic->x2apic_id = apic; diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 0e5b4b280f..4a71aef67e 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -726,6 +726,10 @@ typedef struct acpi_madt_lapic { #define ACPI_MADT_MAX_LAPIC_ID 0xfe +/* MADT Local APIC Feature Flags */ +#define ACPI_MADT_LAPIC_ENABLED (1 << 0) +#define ACPI_MADT_LAPIC_ONLINE_CAPABLE (1 << 1) + /* MADT: Local APIC NMI Structure */ typedef struct acpi_madt_lapic_nmi { u8 type; /* Type (4) */ |