diff options
| author | Felix Held <felix.held@amd.corp-partner.google.com> | 2021-10-18 14:04:01 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-10-19 12:35:17 +0000 |
| commit | 3c1c90bf6107f34cf35e66dc92762ba02799e9ff (patch) | |
| tree | b4bd36e28b8d98f9f526e0aaa81c907142ff1a84 | |
| parent | ad68b07d45fdc2489ec008d77466d116352db1b2 (diff) | |
soc/amd/common/block/include/psp_efs: don't typedef struct
Don't use a typedef for the embedded_firmware struct so that it's
clearer that this is a struct.
TEST=Timeless build for google/guybrush results in identical binary.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I97a02c350af57c8f58014aaf7dda8b4796905ff3
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58420
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Kangheui Won <khwon@chromium.org>
| -rw-r--r-- | src/soc/amd/common/block/include/amdblocks/psp_efs.h | 4 | ||||
| -rw-r--r-- | src/soc/amd/common/block/psp/psp_efs.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/soc/amd/common/block/include/amdblocks/psp_efs.h b/src/soc/amd/common/block/include/amdblocks/psp_efs.h index c5c13a2837..1a6059a1be 100644 --- a/src/soc/amd/common/block/include/amdblocks/psp_efs.h +++ b/src/soc/amd/common/block/include/amdblocks/psp_efs.h @@ -30,7 +30,7 @@ struct second_gen_efs { /* todo: expand for Server products */ } __attribute__((packed)); /* Copied from coreboot/util/amdfwtool.h */ -typedef struct _embedded_firmware { +struct embedded_firmware { uint32_t signature; /* 0x55aa55aa */ uint32_t imc_entry; uint32_t gec_entry; @@ -60,7 +60,7 @@ typedef struct _embedded_firmware { uint8_t reserved_4Ah; uint8_t reserved_4Bh; uint32_t reserved_4Ch; -} __attribute__((packed, aligned(16))) embedded_firmware; +} __attribute__((packed, aligned(16))); bool efs_is_valid(void); bool read_efs_spi_settings(uint8_t *mode, uint8_t *speed); diff --git a/src/soc/amd/common/block/psp/psp_efs.c b/src/soc/amd/common/block/psp/psp_efs.c index 5814f48c63..feb0276463 100644 --- a/src/soc/amd/common/block/psp/psp_efs.c +++ b/src/soc/amd/common/block/psp/psp_efs.c @@ -6,7 +6,7 @@ #include <commonlib/region.h> #include <types.h> -static struct _embedded_firmware *efs; +static struct embedded_firmware *efs; bool efs_is_valid(void) { |