diff options
| author | Michael Niewöhner <foss@mniewoehner.de> | 2020-08-05 21:38:59 +0200 |
|---|---|---|
| committer | Michael Niewöhner <foss@mniewoehner.de> | 2021-04-22 19:42:05 +0000 |
| commit | 348f2a63707cc1711cc836837fc7f5b36b2e0553 (patch) | |
| tree | b69fec1b9623d3e3ab221d5e4523848b0ebad40e | |
| parent | 6e64c1a4e09de71d359c3123f7be1dfceba1f0a1 (diff) | |
soc/intel/skylake: set MSR LT_LOCK_MEMORY only when using native MP init
FSP takes care of setting the MSR LT_LOCK_MEMORY when SkipMpInit=0.
Thus, only set the lock when native MP init is used (SkipMpInit=1).
Change-Id: I2758e87c6370f3244416a3170cfafe6df757bb78
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44243
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
| -rw-r--r-- | src/soc/intel/skylake/finalize.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c index ebbd3da238..9e9f1ed2cc 100644 --- a/src/soc/intel/skylake/finalize.c +++ b/src/soc/intel/skylake/finalize.c @@ -84,7 +84,12 @@ static void soc_lockdown(struct device *dev) pci_write_config8(dev, GEN_PMCON_A, reg8); } - cpu_lt_lock_memory(); + /* + * Lock chipset memory registers to protect SMM. + * When SkipMpInit=0, this is done by FSP. + */ + if (!CONFIG(USE_INTEL_FSP_MP_INIT)) + cpu_lt_lock_memory(); } static void soc_finalize(void *unused) |