diff options
| author | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2021-01-15 09:43:49 -0700 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2021-01-25 08:52:01 +0000 |
| commit | 2e3edcfbe0a9057d53b9f6eb2f3f433b3d3f5e5e (patch) | |
| tree | 162dc9f4f8e87e34627b290a08fb01b275e7b8e4 | |
| parent | 845b65bf5e8d04e5bbc11d49b07e8b49e36bb023 (diff) | |
mb/google/volteer/eldrid: Use #define symbols for usb2_ports config
It's easier to understand what these symbolic names mean rather than
using the constants; the static.c will will end up (indirectly)
including `soc/usb.h` therefore the macros are in scope here.
Change-Id: I5ef977a05a2522e177f32c99bfab74f9288ae869
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49488
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nick Chen <nick_xr_chen@wistron.corp-partner.google.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Furquan Shaikh <furquan@google.com>
| -rw-r--r-- | src/mainboard/google/volteer/variants/eldrid/overridetree.cb | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb index d7ea9d3d6f..37e0ab9efc 100644 --- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb +++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb @@ -79,10 +79,11 @@ chip soc/intel/tigerlake #lower camera driving register "usb2_ports[4]" = "{ .enable = 1, - .tx_bias = 0, - .tx_emp_enable = 0, - .pre_emp_bias = 0, - .pre_emp_bit = 0, + .ocpin = OC_SKIP, + .tx_bias = USB2_BIAS_0MV, + .tx_emp_enable = USB2_EMP_OFF, + .pre_emp_bias = USB2_BIAS_0MV, + .pre_emp_bit = USB2_FULL_BIT_PRE_EMP, }" #Type-A / Type-C C0 |