summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2023-01-05 18:05:11 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2023-08-16 17:57:35 +0000
commit28a7d9bf795ac0f6dea4f6495c1afaaf3ec051ef (patch)
treebc453b249d2d1e4a18f7718f88749144c62f6c2a
parentaf656f929299521d2509e5cc927b711f9d4c6ebb (diff)
mb/google/slippy: Re-arrange mainboard_smi_sleep()
Change-Id: I9ac7293e03bba773753f48163aca9385f819a71b Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74822 Reviewed-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/google/slippy/smihandler.c14
1 files changed, 7 insertions, 7 deletions
diff --git a/src/mainboard/google/slippy/smihandler.c b/src/mainboard/google/slippy/smihandler.c
index 7e4b271e3f..c68741b2e9 100644
--- a/src/mainboard/google/slippy/smihandler.c
+++ b/src/mainboard/google/slippy/smihandler.c
@@ -34,23 +34,23 @@ void mainboard_smi_sleep(u8 slp_typ)
switch (slp_typ) {
case ACPI_S3:
- /* Prevent leak from standby rail to WLAN rail in S3. */
+ case ACPI_S4:
+ case ACPI_S5:
+ /* Prevent leak from standby rail to WLAN rail in S3/S4/S5. */
set_gpio(GPIO_WLAN_DISABLE_L, 0);
set_gpio(GPIO_PP3300_CODEC_EN, 0);
/* Disable LTE */
set_gpio(GPIO_LTE_DISABLE_L, 0);
+ break;
+ }
+ switch (slp_typ) {
+ case ACPI_S3:
/* Enable wake events */
google_chromeec_set_wake_mask(MAINBOARD_EC_S3_WAKE_EVENTS);
break;
case ACPI_S4:
case ACPI_S5:
- /* Prevent leak from standby rail to WLAN rail in S5. */
- set_gpio(GPIO_WLAN_DISABLE_L, 0);
- set_gpio(GPIO_PP3300_CODEC_EN, 0);
- /* Disable LTE */
- set_gpio(GPIO_LTE_DISABLE_L, 0);
-
/* Enable wake events */
google_chromeec_set_wake_mask(MAINBOARD_EC_S5_WAKE_EVENTS);
break;