diff options
| author | Martin Roth <gaumless@gmail.com> | 2023-10-23 19:47:32 -0600 |
|---|---|---|
| committer | Martin L Roth <gaumless@gmail.com> | 2023-10-25 15:21:10 +0000 |
| commit | 27b4a60baf685dd636904277c1fab249c80e5777 (patch) | |
| tree | bbb4791f8aa023f08fe1a3144d5f358df94ce2bf | |
| parent | 4bae3237464889454cff9cbdec7bd7ba61d3dccd (diff) | |
mb/prodrive/hermes: Limit amount of data copied into struct
Change strcpy to strncpy just to be safe.
Found-by: Coverity Scan #1446759
Signed-off-by: Martin Roth <gaumless@gmail.com>
Change-Id: I7ed094a313692806a6ab6b4226b9978647e9cb8d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78621
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
| -rw-r--r-- | src/mainboard/prodrive/hermes/mainboard.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/prodrive/hermes/mainboard.c b/src/mainboard/prodrive/hermes/mainboard.c index 3173522a77..b0bf0dd986 100644 --- a/src/mainboard/prodrive/hermes/mainboard.c +++ b/src/mainboard/prodrive/hermes/mainboard.c @@ -111,7 +111,7 @@ static void update_board_layout(void) continue; layout.cpu_count++; if (!layout.cpu_name[0]) - strcpy(layout.cpu_name, cpu->name); + strncpy(layout.cpu_name, cpu->name, sizeof(layout.cpu_name)); } if (cpuid_get_max_func() >= 0x16) |