diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2023-02-28 17:02:50 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-03-29 16:23:34 +0000 |
| commit | 23cae54e5dc4d546412db7299b8ff52f1bb0135c (patch) | |
| tree | baddd249de54a5ae3399b9a60b6303069a9087cb | |
| parent | 78cbcefb7662b5f749b5583dce2c78b100b9d58e (diff) | |
soc/amd/picasso/Kconfig: update help text for 2nd VBIOS ID detection
The help text for VGA_BIOS_SECOND_ID was outdated and from a time before
we found out that just looking at the CPUID doesn't reliably tell us on
which type of silicon we're running and which VBIOS file to pick, so we
had to use a different method. Update the help text to match what the
code does.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ia568771ed7dfa0c7bb850b0efcd2959d7ddfd4a1
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73335
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
| -rw-r--r-- | src/soc/amd/picasso/Kconfig | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index 6bbbb86ddb..11410ae91f 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -243,13 +243,11 @@ config VGA_BIOS_SECOND_ID string default "1002,15dd,c4" help - Because Dali and Picasso need different video BIOSes, but have the - same vendor/device IDs, we need an alternate method to determine the - correct video BIOS. In map_oprom_vendev_rev(), we look at the cpuid - and decide which rom to load. - - Even though the hardware has the same vendor/device IDs, the vBIOS - contains a *different* device ID, confusing the situation even more. + Some Dali and all Pollock APUs need a different VBIOS than some other + Dali and all Picasso APUs, but don't always have a different PCI + vendor/device IDs, so we need an alternate method to determine the + correct video BIOS. In map_oprom_vendev_rev(), we look at the return + value of soc_is_raven2() and decide which rom to load. config VGA_BIOS_SECOND_FILE string |