summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Walter <christian.walter@9elements.com>2020-07-15 13:04:40 +0200
committerPatrick Rudolph <siro@das-labor.org>2020-08-12 05:36:18 +0000
commit2276ffa3800e3374b2659a7d03abbe3485318ebc (patch)
treea9a2dcd95e16bf695e73d6cec2f42af1aaa103f9
parent3299b2ded5327cd4a40e68554a8c2fd227355ada (diff)
mb/prodrive/hermes: Add multifunction device for UART 2
On CNP-H, only four I2C controllers are available, so PCI devices 19.0 and 19.1 are missing. However, PCI device 19.2 still exists as UART 2. That function 0 is missing means UART 2 can only be used in ACPI mode. Both devices need to be marked as hidden on the devicetree so that the allocator takes UART 2 into account. Change-Id: Ie77198cc0327414b9f88cf15ba4efaddb4f5cca4 Signed-off-by: Christian Walter <christian.walter@9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/43481 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Rudolph <siro@das-labor.org>
-rw-r--r--src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb5
1 files changed, 4 insertions, 1 deletions
diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb
index b3649f906e..d1694dce5a 100644
--- a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb
+++ b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb
@@ -173,7 +173,10 @@ chip soc/intel/cannonlake
device pci 14.3 on end # CNVi wifi
end
- device pci 19.2 on end # UART #2
+ # This device does not have any function on CNP-H, but it needs
+ # to be here so that the resource allocator is aware of UART 2.
+ device pci 19.0 hidden end
+ device pci 19.2 hidden end # UART #2, in ACPI mode
device pci 1b.4 on
smbios_slot_desc "SlotTypePciExpressGen3X16" "SlotLengthOther" "SLOT1" "SlotDataBusWidth4X"