summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSubrata Banik <subratabanik@google.com>2022-11-16 14:07:43 +0530
committerFelix Held <felix-coreboot@felixheld.de>2022-11-18 19:48:14 +0000
commit20c64a1210360adc880b8e4fdecc3bb2ae95fb59 (patch)
tree66ab6a79c21d8823df7d93d46ee174d0d6ff4bcc
parentb699d61b997949207a34cb672d3ba18d538fdebf (diff)
mb/google/rex: Disable `ACPI PM timer`
This patch deselects `USE_PM_ACPI_TIMER` kconfig to ensure that ACPI PM timer remains disabled. The PM timer (by PMC IP) consumes more power and blocks S0ix so the timer is emulated by ucode to save power and unblock S0ix. TEST=Able to boot Google, Rex and ensure PMC MMIO register 0x18fc BIT 1 is set. Signed-off-by: Subrata Banik <subratabanik@google.com> Change-Id: I2a23b417ff7fb6328323380a7df46b4b397fc8eb Reviewed-on: https://review.coreboot.org/c/coreboot/+/69685 Reviewed-by: Kapil Porwal <kapilporwal@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
-rw-r--r--src/mainboard/google/rex/Kconfig3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig
index 05b47479fb..66e3591bb2 100644
--- a/src/mainboard/google/rex/Kconfig
+++ b/src/mainboard/google/rex/Kconfig
@@ -106,4 +106,7 @@ config TPM_TIS_ACPI_INTERRUPT
int
default 35 # GPE0_DW1_03 (GPP_E03)
+config USE_PM_ACPI_TIMER
+ default n
+
endif # BOARD_GOOGLE_REX_COMMON