summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Georgi <pgeorgi@google.com>2019-12-17 16:59:47 +0100
committerPatrick Georgi <pgeorgi@google.com>2020-01-20 14:31:29 +0000
commit186c2f9abcd7d98a15ae6b8f92f3fd7cfa41d54e (patch)
tree18b8e9a433bbd1d581a858640a843ca036d79a3d
parentd76947f13b760d876fdfb675bac992cb4275e1c1 (diff)
util/nvramtool: Create nvramtool object directories earlier
The existing rule created a potential race condition between creating the directory and putting files in there, so use our existing infrastructure for directory creation instead. Change-Id: If52a9f558c7d9ce85f71ba53232594699c9d357a Signed-off-by: Patrick Georgi <pgeorgi@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/37798 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Jett Rink <jettrink@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--util/nvramtool/Makefile.inc3
1 files changed, 1 insertions, 2 deletions
diff --git a/util/nvramtool/Makefile.inc b/util/nvramtool/Makefile.inc
index 48f6d86557..697428906e 100644
--- a/util/nvramtool/Makefile.inc
+++ b/util/nvramtool/Makefile.inc
@@ -36,8 +36,7 @@ NVRAMTOOLLDFLAGS += -lregex -lwsock32
nvramtoolobj += win32mmap.o
endif
-$(objutil)/nvramtool $(objutil)/nvramtool/accessors $(objutil)/nvramtool/cli:
- mkdir -p $@
+additional-dirs += $(objutil)/nvramtool/accessors $(objutil)/nvramtool/cli
$(objutil)/nvramtool/%.o: $(top)/util/nvramtool/%.c
printf " HOSTCC $(subst $(objutil)/,,$(@))\n"