summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTim Wawrzynczak <twawrzynczak@chromium.org>2022-06-30 10:19:58 -0600
committerFelix Held <felix-coreboot@felixheld.de>2022-07-15 12:05:07 +0000
commit17c77f5a86abc9ac6d9cbae029a793dfe1c4b9cb (patch)
treed2b19bfb0770bfd5693c66d118dca5999734cd6b
parentfcfc5729470e3a3f3a7a304244ff6fad00ca058f (diff)
mb/google/brya/var/agah: Disable ASPM for dGPU
Since ASPM is not verified as fully functional yet, and the board is still in development, this patch disables ASPM for the dGPU. BUG=b:236676400 TEST=boot to OS in agah, lspci -vvv shows ASPM is disabled Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Change-Id: I525eeb18c57d45fd55335b63a59262066afc9567 Reviewed-on: https://review.coreboot.org/c/coreboot/+/65566 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Ivy Jian <ivy.jian@quanta.corp-partner.google.com>
-rw-r--r--src/mainboard/google/brya/variants/agah/overridetree.cb1
-rw-r--r--src/mainboard/google/brya/variants/agah/variant.c4
2 files changed, 5 insertions, 0 deletions
diff --git a/src/mainboard/google/brya/variants/agah/overridetree.cb b/src/mainboard/google/brya/variants/agah/overridetree.cb
index 550dab60fb..a50a9d4cb8 100644
--- a/src/mainboard/google/brya/variants/agah/overridetree.cb
+++ b/src/mainboard/google/brya/variants/agah/overridetree.cb
@@ -71,6 +71,7 @@ chip soc/intel/alderlake
.clk_req = 0,
.clk_src = 0,
.flags = PCIE_RP_LTR | PCIE_RP_AER,
+ .pcie_rp_aspm = ASPM_DISABLE
}"
device pci 00.0 alias dgpu on end
end
diff --git a/src/mainboard/google/brya/variants/agah/variant.c b/src/mainboard/google/brya/variants/agah/variant.c
index b0baab356b..437fdc4c51 100644
--- a/src/mainboard/google/brya/variants/agah/variant.c
+++ b/src/mainboard/google/brya/variants/agah/variant.c
@@ -132,6 +132,10 @@ static void dgpu_power_sequence_on(void)
void variant_init(void)
{
+ /* Disable ASPM for the GPU until it is verified working. */
+ struct device *dgpu = DEV_PTR(dgpu);
+ dgpu->disable_pcie_aspm = 1;
+
if (acpi_is_wakeup_s3())
return;