aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDtrain Hsu <dtrain_hsu@compal.corp-partner.google.com>2023-06-05 10:00:41 +0800
committerFelix Held <felix-coreboot@felixheld.de>2023-06-06 12:18:49 +0000
commit1659218d7c7e68beee752e701e4b7ba13369bcae (patch)
treee58a002d4c89de1a376d0fb5a854a40de7516f16
parente27bd13088dc597c32e46b88d93ff74c31dca792 (diff)
mb/google/nissa/var/uldren: Modify GPP_D7 and PCIE RP7
Uldren does not have PCIE device and should disable PCIE RP7 and GPP_D7 for preventing PCIe controller not power gate in S0ix. BUG=b:283735051 BRANCH=firmware-nissa-15217.B TEST=emerge-nissa coreboot chromeos-bootimage 1. PCIE RP7: cbmem -c | grep 'PCI: 00:1c.6' [SPEW ] PCI: 00:1c.6: enabled 0 [SPEW ] PCI: 00:1c.6: enabled 0 2. GPP_D7: iotools mmio_read32 0xfd6d0ab0 0x44000300 Change-Id: Ia8a2c0f5530c7a056e8d706c651cac1d49b2091c Signed-off-by: Dtrain Hsu <dtrain_hsu@compal.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/75644 Reviewed-by: Harsha B R <harsha.b.r@intel.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Derek Huang <derekhuang@google.com>
-rw-r--r--src/mainboard/google/brya/variants/uldren/gpio.c2
-rw-r--r--src/mainboard/google/brya/variants/uldren/overridetree.cb1
2 files changed, 3 insertions, 0 deletions
diff --git a/src/mainboard/google/brya/variants/uldren/gpio.c b/src/mainboard/google/brya/variants/uldren/gpio.c
index e1e5e8cd4d..c0c438147e 100644
--- a/src/mainboard/google/brya/variants/uldren/gpio.c
+++ b/src/mainboard/google/brya/variants/uldren/gpio.c
@@ -21,6 +21,8 @@ static const struct pad_config override_gpio_table[] = {
PAD_CFG_GPO(GPP_C1, 1, DEEP),
/* D6 : SRCCLKREQ1# ==> WWAN_EN */
PAD_CFG_GPO(GPP_D6, 1, DEEP),
+ /* D7 : SRCCLKREQ2# ==> NC */
+ PAD_NC(GPP_D7, NONE),
/* D8 : SRCCLKREQ3# ==> NC */
PAD_NC(GPP_D8, NONE),
/* D15 : ISH_UART0_RTS# ==> NC */
diff --git a/src/mainboard/google/brya/variants/uldren/overridetree.cb b/src/mainboard/google/brya/variants/uldren/overridetree.cb
index 77b8655207..a873a6288b 100644
--- a/src/mainboard/google/brya/variants/uldren/overridetree.cb
+++ b/src/mainboard/google/brya/variants/uldren/overridetree.cb
@@ -353,6 +353,7 @@ chip soc/intel/alderlake
end
end
end
+ device ref pcie_rp7 off end
device ref hda on
chip drivers/generic/max98357a
register "hid" = ""MX98360A""