diff options
| author | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2022-07-27 09:56:41 -0600 |
|---|---|---|
| committer | Paul Fagerburg <pfagerburg@chromium.org> | 2022-07-28 20:02:24 +0000 |
| commit | 1523742d4c23b3d31aac4a17b6bac7c19c8bd3b9 (patch) | |
| tree | 0ca9258d758e2051b66f76a460c3a2ad69256dbc | |
| parent | d6b763ca634163c9d8b9afca51f88698704c0fa9 (diff) | |
mb/google/brya/var/agah: Update ASPM settings for dGPU
After some debugging, it has been determined that the ASPM L0s substate
is functional, but there is still some problem with ASPM L1 substates,
so this patch updates ASPM status for the dGPU from disabled to L0s
only.
BUG=b:240390998
TEST=tested with nvidia tools
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Change-Id: I584bdbf26eda20246034263446492bf4daf5f3b6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66198
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Ivy Jian <ivy.jian@quanta.corp-partner.google.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
| -rw-r--r-- | src/mainboard/google/brya/variants/agah/overridetree.cb | 2 | ||||
| -rw-r--r-- | src/mainboard/google/brya/variants/agah/variant.c | 4 |
2 files changed, 1 insertions, 5 deletions
diff --git a/src/mainboard/google/brya/variants/agah/overridetree.cb b/src/mainboard/google/brya/variants/agah/overridetree.cb index 0f50f96712..ae6ad4a22d 100644 --- a/src/mainboard/google/brya/variants/agah/overridetree.cb +++ b/src/mainboard/google/brya/variants/agah/overridetree.cb @@ -80,7 +80,7 @@ chip soc/intel/alderlake .clk_req = 0, .clk_src = 0, .flags = PCIE_RP_LTR | PCIE_RP_AER, - .pcie_rp_aspm = ASPM_DISABLE + .pcie_rp_aspm = ASPM_L0S, }" device pci 00.0 alias dgpu on end end diff --git a/src/mainboard/google/brya/variants/agah/variant.c b/src/mainboard/google/brya/variants/agah/variant.c index 437fdc4c51..b0baab356b 100644 --- a/src/mainboard/google/brya/variants/agah/variant.c +++ b/src/mainboard/google/brya/variants/agah/variant.c @@ -132,10 +132,6 @@ static void dgpu_power_sequence_on(void) void variant_init(void) { - /* Disable ASPM for the GPU until it is verified working. */ - struct device *dgpu = DEV_PTR(dgpu); - dgpu->disable_pcie_aspm = 1; - if (acpi_is_wakeup_s3()) return; |