summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilip Chen <philipchen@google.com>2021-07-15 15:31:51 -0700
committerFelix Held <felix-coreboot@felixheld.de>2021-07-21 16:21:01 +0000
commit1158f712dc99c8fe4dc4c70009cad0c3fdb7c80d (patch)
treebc10111dd8870fb365d4fa544de48d03cf210fae
parenta8e9dbae65cad1a9c655aa5f71bfe3b097348843 (diff)
mb/google/herobrine: Retrieve SKU ID from EC
BUG=b:186264627 BRANCH=none TEST=build herobrine Signed-off-by: Philip Chen <philipchen@google.com> Change-Id: Id3faf7af64c0129ec646a01085adc43b561225d2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/56354 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Shelley Chen <shchen@google.com>
-rw-r--r--src/mainboard/google/herobrine/Kconfig1
-rw-r--r--src/mainboard/google/herobrine/Makefile.inc2
-rw-r--r--src/mainboard/google/herobrine/boardid.c5
3 files changed, 4 insertions, 4 deletions
diff --git a/src/mainboard/google/herobrine/Kconfig b/src/mainboard/google/herobrine/Kconfig
index 7f88b94f5c..38bb328753 100644
--- a/src/mainboard/google/herobrine/Kconfig
+++ b/src/mainboard/google/herobrine/Kconfig
@@ -9,6 +9,7 @@ config BOARD_SPECIFIC_OPTIONS
select COMMON_CBFS_SPI_WRAPPER
select EC_GOOGLE_CHROMEEC if !BOARD_GOOGLE_SENOR
select EC_GOOGLE_CHROMEEC_RTC if !BOARD_GOOGLE_SENOR
+ select EC_GOOGLE_CHROMEEC_SKUID if !BOARD_GOOGLE_SENOR
select EC_GOOGLE_CHROMEEC_SPI if !BOARD_GOOGLE_SENOR
select RTC if !BOARD_GOOGLE_SENOR
select MISSING_BOARD_RESET if BOARD_GOOGLE_SENOR
diff --git a/src/mainboard/google/herobrine/Makefile.inc b/src/mainboard/google/herobrine/Makefile.inc
index 11a396ff04..a80779946d 100644
--- a/src/mainboard/google/herobrine/Makefile.inc
+++ b/src/mainboard/google/herobrine/Makefile.inc
@@ -1,8 +1,8 @@
## SPDX-License-Identifier: GPL-2.0-only
-all-y += boardid.c
all-y += chromeos.c
ifneq ($(CONFIG_BOARD_GOOGLE_SENOR),y)
+all-y += boardid.c
all-y += reset.c
endif
bootblock-y += bootblock.c
diff --git a/src/mainboard/google/herobrine/boardid.c b/src/mainboard/google/herobrine/boardid.c
index eecbeab087..6368d25157 100644
--- a/src/mainboard/google/herobrine/boardid.c
+++ b/src/mainboard/google/herobrine/boardid.c
@@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <boardid.h>
+#include <ec/google/chromeec/ec.h>
#include <gpio.h>
uint32_t board_id(void)
@@ -19,7 +20,5 @@ uint32_t ram_code(void)
uint32_t sku_id(void)
{
- static uint32_t id = UNDEFINED_STRAPPING_ID;
-
- return id;
+ return google_chromeec_get_board_sku();
}