diff options
| author | Martin Roth <martinroth@google.com> | 2017-08-08 20:31:46 -0600 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-08-17 11:26:31 +0000 |
| commit | 0bb936da9ae2454307a1ffb4c97aa7c822c09a9c (patch) | |
| tree | 534c1f1bc4b426c099c5aa278af0082763888dee | |
| parent | 82f13e91fa934e787710ed9f1cc0d8a7c18a58cd (diff) | |
lint: update signed-off-by check
The current signed-off-by check doesn't really work well as a lint
stable test being run by the pre-commit git hook. This test looks
at the PREVIOUS commit instead of the staged commit, which works well
on the server. In looking for a way to check the staged commit message,
I found the commit-msg hook, which is the correct way to check the
staged message.
- Update the commit message check from a lint-stable test to a
lint-extended test.
- Add the check for signed-off-by to the commit-msg hook
Change-Id: I8be8aef25730d988c7cf1586ae66ecb839d5f756
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/20920
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Chris Ching <chingcodes@chromium.org>
| -rwxr-xr-x | util/gitconfig/commit-msg | 5 | ||||
| -rwxr-xr-x | util/lint/lint-extended-020-signed-off-by (renamed from util/lint/lint-stable-020-signed-off-by) | 0 |
2 files changed, 4 insertions, 1 deletions
diff --git a/util/gitconfig/commit-msg b/util/gitconfig/commit-msg index 82f0581ced..2eef752156 100755 --- a/util/gitconfig/commit-msg +++ b/util/gitconfig/commit-msg @@ -169,5 +169,8 @@ _gen_ChangeId() { git hash-object -t commit --stdin } - +if ! grep -qi '^[[:space:]]*\+Signed-off-by:' "$MSG"; then + printf "\nError: No Signed-off-by line in the commit message.\n" + exit 1 +fi add_ChangeId diff --git a/util/lint/lint-stable-020-signed-off-by b/util/lint/lint-extended-020-signed-off-by index 40b6e9eb42..40b6e9eb42 100755 --- a/util/lint/lint-stable-020-signed-off-by +++ b/util/lint/lint-extended-020-signed-off-by |