diff options
| author | Fabio Aiuto <fabioaiuto83@gmail.com> | 2022-08-19 17:25:25 +0200 |
|---|---|---|
| committer | Martin Roth <martin.roth@amd.corp-partner.google.com> | 2022-08-24 15:18:06 +0000 |
| commit | 0805c7010a5fcfe732a38dfac065b615d577aa4d (patch) | |
| tree | 60b31c4090d2a24f8ebe5056bb1868fc850cf50f | |
| parent | d77525b5bd28011a56194fcb5f8f77bc709dd039 (diff) | |
src/arch/x86/smbios.c: remove unneeded braces
fix the following checkpatch errors:
WARNING:BRACES: braces {} are not necessary for any arm of this statement
354: FILE: src/arch/x86/smbios.c:354:
+ if (CONFIG_ROM_SIZE >= 1 * GiB) {
[...]
+ } else {
[...]
WARNING:BRACES: braces {} are not necessary for single statement blocks
561: FILE: src/arch/x86/smbios.c:561:
+ if (leaf_b_threads == 0) {
+ leaf_b_threads = 1;
+ }
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Change-Id: I14c29e4358cad4cd5ef169ebab7079db2129d8fa
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66925
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
| -rw-r--r-- | src/arch/x86/smbios.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index fd41ff23f1..4f8de420c3 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -351,11 +351,10 @@ static int smbios_write_type0(unsigned long *current, int handle) rom_size = MIN(CONFIG_ROM_SIZE, 16 * MiB); t->bios_rom_size = (rom_size / 65535) - 1; - if (CONFIG_ROM_SIZE >= 1 * GiB) { + if (CONFIG_ROM_SIZE >= 1 * GiB) t->extended_bios_rom_size = DIV_ROUND_UP(CONFIG_ROM_SIZE, GiB) | (1 << 14); - } else { + else t->extended_bios_rom_size = DIV_ROUND_UP(CONFIG_ROM_SIZE, MiB); - } t->system_bios_major_release = coreboot_major_revision; t->system_bios_minor_release = coreboot_minor_revision; @@ -558,9 +557,9 @@ static int smbios_write_type4(unsigned long *current, int handle) res = cpuid_ext(0xb, 0); leaf_b_threads = res.ebx; /* if hyperthreading is not available, pretend this is 1 */ - if (leaf_b_threads == 0) { + if (leaf_b_threads == 0) leaf_b_threads = 1; - } + t->core_count2 = leaf_b_cores / leaf_b_threads; t->core_count = t->core_count2 > 0xff ? 0xff : t->core_count2; t->thread_count2 = leaf_b_cores; |