diff options
| author | Aaron Durbin <adurbin@chromium.org> | 2013-03-22 20:23:17 -0500 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2013-03-23 19:38:53 +0100 |
| commit | 0135702802601c19937eec57513f3a6e2f4d1e00 (patch) | |
| tree | 9538ce3061f48b38afa83e189bf3ce55fb650320 | |
| parent | b467f1ddafb0ad4769b5d51b88563966af7d563c (diff) | |
x86: mark .textfirst as allocatable and executable
When the linking of ramstage was changed to use an intermeidate
object with all ramstage objects in it the .textfirst section
was introduced to keep the entry point at 0. However, the
section was not marked allocatable or executable. Nor was it
marked as @progbits. That didn't cause an issue on its own since
.textfirst was directly called out in the linker script. However,
the rmodule infrastructure relies on all the relocation entries
being included in the rmodule. Without the proper section attributes
the .rel.textfirst section entries were not being included in
the final ramstage rmodule.
Change-Id: I54e7055a19bee6c86e269eba047d9a560702afde
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/2885
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
| -rw-r--r-- | src/arch/x86/lib/c_start.S | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/arch/x86/lib/c_start.S b/src/arch/x86/lib/c_start.S index 762aa8c264..32af0ccdf9 100644 --- a/src/arch/x86/lib/c_start.S +++ b/src/arch/x86/lib/c_start.S @@ -11,7 +11,7 @@ _stack: .space CONFIG_MAX_CPUS*CONFIG_STACK_SIZE _estack: - .section ".textfirst" + .section ".textfirst", "ax", @progbits .code32 .globl _start _start: |