diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-06-28 17:52:34 +1000 |
|---|---|---|
| committer | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-06-29 13:05:25 +0200 |
| commit | caac5ef86d1164d3f12c0486d0a2e469d0ebb252 (patch) | |
| tree | 4ab58ce1e4e5b69707bd427334310b4c8fcddb58 | |
| parent | 4d7539eefdedc4297e1529ee94df7165e2076fa1 (diff) | |
northbridge/amd: Remove some extraneous parentheses from if-statements
Spotted by Clang.
Change-Id: I38832da7b93d4ee18b8de3e80dc39513a8910221
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/6149
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
| -rw-r--r-- | src/northbridge/amd/agesa/family10/northbridge.c | 2 | ||||
| -rw-r--r-- | src/northbridge/amd/agesa/family12/amdfam12_conf.c | 4 | ||||
| -rw-r--r-- | src/northbridge/amd/agesa/family14/amdfam14_conf.c | 4 | ||||
| -rw-r--r-- | src/northbridge/amd/amdfam10/conf.c | 7 |
4 files changed, 7 insertions, 10 deletions
diff --git a/src/northbridge/amd/agesa/family10/northbridge.c b/src/northbridge/amd/agesa/family10/northbridge.c index 7a990d9a9e..73545a0e0a 100644 --- a/src/northbridge/amd/agesa/family10/northbridge.c +++ b/src/northbridge/amd/agesa/family10/northbridge.c @@ -191,7 +191,7 @@ static u32 get_mmio_addr_index(u32 nodeid, u32 linkn) u32 index; for (index=0; index<64; index++) { - if ((sysconf.conf_mmio_addrx[index+8] == 0)) { + if (sysconf.conf_mmio_addrx[index+8] == 0) { sysconf.conf_mmio_addr[index+8] = (nodeid & 0x3f) ; sysconf.conf_mmio_addrx[index+8] = 1 | ((linkn & 0x7)<<4); return index; diff --git a/src/northbridge/amd/agesa/family12/amdfam12_conf.c b/src/northbridge/amd/agesa/family12/amdfam12_conf.c index eb539d68f4..00ff641c8d 100644 --- a/src/northbridge/amd/agesa/family12/amdfam12_conf.c +++ b/src/northbridge/amd/agesa/family12/amdfam12_conf.c @@ -195,7 +195,7 @@ static u32 get_io_addr_index(u32 nodeid, u32 linkn) u32 index; for(index=0; index<256; index++) { - if((sysconf.conf_io_addrx[index+4] == 0)){ + if(sysconf.conf_io_addrx[index+4] == 0) { sysconf.conf_io_addr[index+4] = (nodeid & 0x3f) ; sysconf.conf_io_addrx[index+4] = 1 | ((linkn & 0x7)<<4); return index; @@ -211,7 +211,7 @@ static u32 get_mmio_addr_index(u32 nodeid, u32 linkn) u32 index; for(index=0; index<64; index++) { - if((sysconf.conf_mmio_addrx[index+8] == 0)){ + if(sysconf.conf_mmio_addrx[index+8] == 0) { sysconf.conf_mmio_addr[index+8] = (nodeid & 0x3f) ; sysconf.conf_mmio_addrx[index+8] = 1 | ((linkn & 0x7)<<4); return index; diff --git a/src/northbridge/amd/agesa/family14/amdfam14_conf.c b/src/northbridge/amd/agesa/family14/amdfam14_conf.c index d302db314a..c25521389c 100644 --- a/src/northbridge/amd/agesa/family14/amdfam14_conf.c +++ b/src/northbridge/amd/agesa/family14/amdfam14_conf.c @@ -195,7 +195,7 @@ static u32 get_io_addr_index(u32 nodeid, u32 linkn) u32 index; for(index=0; index<256; index++) { - if((sysconf.conf_io_addrx[index+4] == 0)){ + if(sysconf.conf_io_addrx[index+4] == 0) { sysconf.conf_io_addr[index+4] = (nodeid & 0x3f) ; sysconf.conf_io_addrx[index+4] = 1 | ((linkn & 0x7)<<4); return index; @@ -211,7 +211,7 @@ static u32 get_mmio_addr_index(u32 nodeid, u32 linkn) u32 index; for(index=0; index<64; index++) { - if((sysconf.conf_mmio_addrx[index+8] == 0)){ + if(sysconf.conf_mmio_addrx[index+8] == 0) { sysconf.conf_mmio_addr[index+8] = (nodeid & 0x3f) ; sysconf.conf_mmio_addrx[index+8] = 1 | ((linkn & 0x7)<<4); return index; diff --git a/src/northbridge/amd/amdfam10/conf.c b/src/northbridge/amd/amdfam10/conf.c index cfb914a859..971e319601 100644 --- a/src/northbridge/amd/amdfam10/conf.c +++ b/src/northbridge/amd/amdfam10/conf.c @@ -689,7 +689,7 @@ static u32 get_io_addr_index(u32 nodeid, u32 linkn) u32 index; for(index=0; index<256; index++) { - if((sysconf.conf_io_addrx[index+4] == 0)){ + if(sysconf.conf_io_addrx[index+4] == 0) { sysconf.conf_io_addr[index+4] = (nodeid & 0x3f) ; sysconf.conf_io_addrx[index+4] = 1 | ((linkn & 0x7)<<4); return index; @@ -697,16 +697,14 @@ static u32 get_io_addr_index(u32 nodeid, u32 linkn) } return 0; - } static u32 get_mmio_addr_index(u32 nodeid, u32 linkn) { u32 index; - for(index=0; index<64; index++) { - if((sysconf.conf_mmio_addrx[index+8] == 0)){ + if(sysconf.conf_mmio_addrx[index+8] == 0) { sysconf.conf_mmio_addr[index+8] = (nodeid & 0x3f) ; sysconf.conf_mmio_addrx[index+8] = 1 | ((linkn & 0x7)<<4); return index; @@ -714,7 +712,6 @@ static u32 get_mmio_addr_index(u32 nodeid, u32 linkn) } return 0; - } static void store_conf_io_addr(u32 nodeid, u32 linkn, u32 reg, u32 index, |