summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2019-05-16 14:51:51 -0600
committerDuncan Laurie <dlaurie@chromium.org>2019-05-18 20:33:19 +0000
commitaa2157430f96c658b9629bf69d507f1f161078a7 (patch)
tree6f0269413ede53eeb03b95431baf56c01101c8c9
parent6eaa78144cb7c5b60d3d3d8467b1a0a23ef0db70 (diff)
vendorcode/google/chromeos: Correct VPD field for MAC passthrough
The VPD field name is dock_passthrough, not dock_passthru. Fix it. (I assume there is no length limit) BUG=b:132689337 TEST=check that the feature can now be controlled by the associated enterprise policy Change-Id: Icc2b070313fde74447279cd6ccaa4e3eb6d119ee Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/32839 Reviewed-by: Duncan Laurie <dlaurie@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/vendorcode/google/chromeos/acpi/amac.asl15
1 files changed, 8 insertions, 7 deletions
diff --git a/src/vendorcode/google/chromeos/acpi/amac.asl b/src/vendorcode/google/chromeos/acpi/amac.asl
index c87862f6ff..5a091ddfaa 100644
--- a/src/vendorcode/google/chromeos/acpi/amac.asl
+++ b/src/vendorcode/google/chromeos/acpi/amac.asl
@@ -16,16 +16,17 @@
/*
* The Realtek r8152 driver in the Linux kernel supports a MAC address
- * passthru feature which can result in the dock ethernet port using the
- * same MAC address that is assigned to the internal NIC. This is done
- * by calling an ACPI method at \_SB.AMAC() which returns a formatted
- * string (as a buffer) containing the MAC address for the dock to use.
+ * dock pass-through feature which can result in the dock ethernet port
+ * using the same MAC address that is assigned to the internal NIC. This
+ * is done by calling an ACPI method at \_SB.AMAC() which returns a
+ * formatted string (as a buffer) containing the MAC address for the
+ * dock to use.
*
* The Linux kernel implementation can be found at
* drivers/net/usb/r8152.c:vendor_mac_passthru_addr_read()
*
* For Chrome OS, the policy which controls where the dock MAC address
- * comes from is written into RW_VPD property "dock_passthru":
+ * comes from is written into RW_VPD property "dock_passthrough":
*
* "dock_mac" or empty: Use MAC address from RO_VPD value "dock_mac"
* "ethernet_mac0": Use MAC address from RO_VPD value "ethernet_mac0"
@@ -39,8 +40,8 @@ Scope (\_SB)
/* Format expected by the Linux kernel r8152 driver */
Name (MACA, "_AUXMAC_#XXXXXXXXXXXX#")
- /* Get "dock_passthru" value from RW_VPD */
- Local0 = \VPD.VPDF ("RW", "dock_passthru")
+ /* Get "dock_passthrough" value from RW_VPD */
+ Local0 = \VPD.VPDF ("RW", "dock_passthrough")
Local1 = Zero
Switch (ToString (Local0))