summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEnrico Granata <egranata@chromium.org>2018-08-15 17:13:47 -0700
committerPatrick Georgi <pgeorgi@google.com>2018-08-20 15:51:27 +0000
commit55a8d8a772322e5ceb71c28785b1815970c468c5 (patch)
tree09cafd848a8f2a6a1dfda08867ed7f7d45bc76f3
parentbb0cf0191110b5edf4e3c4e05983d9704af5537d (diff)
nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs
This is meant to solve an issue where the proximity sensor may fluctuate between CLOSE / FAR in rapid succession upon the user removing their hand from the unit, before settling on the correct output. Using the hardware debouncing filter solves this issue and removes the spurious fluctuations. BRANCH=None BUG=None TEST=manual on Nocturne, observing events come in Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571 Signed-off-by: Enrico Granata <egranata@chromium.org> Reviewed-on: https://review.coreboot.org/28112 Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/google/poppy/variants/nocturne/devicetree.cb4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
index 88af9294d5..f81d43d1f2 100644
--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
@@ -309,7 +309,7 @@ chip soc/intel/skylake
register "reg_prox_ctrl7" = "0x0d"
register "reg_prox_ctrl8" = "0x8d"
register "reg_prox_ctrl9" = "0x43"
- register "reg_prox_ctrl10" = "0x11"
+ register "reg_prox_ctrl10" = "0x1f"
register "reg_prox_ctrl11" = "0x00"
register "reg_prox_ctrl12" = "0x00"
register "reg_prox_ctrl13" = "0x00"
@@ -350,7 +350,7 @@ chip soc/intel/skylake
register "reg_prox_ctrl7" = "0x0d"
register "reg_prox_ctrl8" = "0x8d"
register "reg_prox_ctrl9" = "0x43"
- register "reg_prox_ctrl10" = "0x11"
+ register "reg_prox_ctrl10" = "0x1f"
register "reg_prox_ctrl11" = "0x00"
register "reg_prox_ctrl12" = "0x00"
register "reg_prox_ctrl13" = "0x00"