summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Georgi <pgeorgi@google.com>2015-03-10 12:47:36 +0100
committerPatrick Georgi <pgeorgi@google.com>2015-04-18 08:41:48 +0200
commit49a80ce47507dd7be309baad880a9d93704bd675 (patch)
tree79b83e67ca61b2433a2c0cd18cfb8b2128c25d05
parent9a20a43c60eb8b3bcb23090d2a12682667a8a83d (diff)
libpayload: More defensive ChipIdea initialization
Mark EP0 non-stall explicitly. Shouldn't be necessary, but won't hurt either. BRANCH=none BUG=none TEST=none Change-Id: I7ecd16a2affe064918d93436aedfa07bd9a1cf56 Signed-off-by: Patrick Georgi <pgeorgi@chromium.org> Original-Commit-Id: a0fc237b33444fc30dc5b62e4f1afc3188f2cf43 Original-Change-Id: I1aa8742eebc4de733317600e35627631ebaf4724 Original-Signed-off-by: Patrick Georgi <pgeorgi@chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/258061 Original-Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-on: http://review.coreboot.org/9787 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
-rw-r--r--payloads/libpayload/drivers/udc/chipidea.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/payloads/libpayload/drivers/udc/chipidea.c b/payloads/libpayload/drivers/udc/chipidea.c
index 87c3076ecb..a399e8cd96 100644
--- a/payloads/libpayload/drivers/udc/chipidea.c
+++ b/payloads/libpayload/drivers/udc/chipidea.c
@@ -128,6 +128,9 @@ static int chipidea_hw_init(struct usbdev_ctrl *this, void *_opreg,
debug("taking controller out of reset\n");
writel(USBCMD_8MICRO | USBCMD_RUN, &p->opreg->usbcmd);
+ this->stall(this, 0, 0, 0);
+ this->stall(this, 0, 1, 0);
+
return 1;
}