diff options
| author | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2012-08-21 17:08:03 -0500 |
|---|---|---|
| committer | Anton Kochkov <anton.kochkov@gmail.com> | 2012-08-22 04:54:12 +0200 |
| commit | 0d5d70b79a3824bfa46a7035d901cb0e7672e3fe (patch) | |
| tree | 1a4af6123b756c0684f5a41e1d3ba7cb297e386b | |
| parent | 0013bbfa98586394015d28dce1be8e0f70d47d60 (diff) | |
mptable: bring sanity back to mptable generation (TRIVIAL)
Remove extra semicolon
Capitalize beginning of printk sentence
Fix detection of multiple ISA-carrying IOAPICs
Fix whitespace issue
Change-Id: I114119b1daf3b472955c0dd00bdc449401789525
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/1474
Tested-by: build bot (Jenkins)
Reviewed-by: Anton Kochkov <anton.kochkov@gmail.com>
| -rw-r--r-- | src/arch/x86/boot/mpspec.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/arch/x86/boot/mpspec.c b/src/arch/x86/boot/mpspec.c index 010bca15c9..78996c7d70 100644 --- a/src/arch/x86/boot/mpspec.c +++ b/src/arch/x86/boot/mpspec.c @@ -426,7 +426,7 @@ unsigned long __attribute__((weak)) write_smp_table(unsigned long addr) mptable_init(mc, LOCAL_APIC_ADDR); - smp_write_processors(mc); + smp_write_processors(mc); mptable_write_buses(mc, NULL, &isa_bus); @@ -443,16 +443,16 @@ unsigned long __attribute__((weak)) write_smp_table(unsigned long addr) ioapic_config->base); if (ioapic_config->have_isa_interrupts) { - if (isaioapic > 1) + if (isaioapic >= 0) printk(BIOS_ERR, "More than one IOAPIC with ISA interrupts?\n"); else - isaioapic = dev->path.ioapic.ioapic_id;; + isaioapic = dev->path.ioapic.ioapic_id; } } if (isaioapic >= 0) { /* Legacy Interrupts */ - printk(BIOS_DEBUG, "writing ISA IRQs\n"); + printk(BIOS_DEBUG, "Writing ISA IRQs\n"); mptable_add_isa_interrupts(mc, isa_bus, isaioapic, 0); } |