diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2017-05-17 10:42:39 +0200 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-08-10 15:55:33 +0000 |
| commit | 0722613563247d41caa406c176ee452465df3572 (patch) | |
| tree | 53ab72db4c6f38984c17abe50e76c91813077e91 | |
| parent | 4769cc3c0cc0ef465484013e8b320df79b0cafac (diff) | |
nb/amd_fam10/mct_ddr3: Use common function to compute crc16 checksum
Change-Id: I730a8a150134cc1ef8fb3872728bb0586ac7b210
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/19732
Tested-by: Raptor Engineering Automated Test Stand <noreply@raptorengineeringinc.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
| -rw-r--r-- | src/northbridge/amd/amdmct/mct_ddr3/mct_d.c | 29 |
1 files changed, 6 insertions, 23 deletions
diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c index 1ac91a1fb2..da803ff627 100644 --- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c +++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c @@ -42,6 +42,7 @@ #include <cpu/x86/msr.h> #include <arch/acpi.h> #include <string.h> +#include <device/dram/ddr3.h> #include "s3utils.h" static u8 ReconfigureDIMMspare_D(struct MCTStatStruc *pMCTstat, @@ -8214,30 +8215,12 @@ static void AfterDramInit_D(struct DCTStatStruc *pDCTstat, u8 dct) { */ uint8_t crcCheck(struct DCTStatStruc *pDCTstat, uint8_t dimm) { - u8 byte_use; - u8 Index; - u16 CRC; - u8 byte, i; - - byte_use = pDCTstat->spd_data.spd_bytes[dimm][SPD_ByteUse]; - if (byte_use & 0x80) - byte_use = 117; - else - byte_use = 126; + u16 crc_calc = spd_ddr3_calc_crc(pDCTstat->spd_data.spd_bytes[dimm], + sizeof(pDCTstat->spd_data.spd_bytes[dimm])); + u16 checksum_spd = pDCTstat->spd_data.spd_bytes[dimm][SPD_byte_127] << 8 + | pDCTstat->spd_data.spd_bytes[dimm][SPD_byte_126]; - CRC = 0; - for (Index = 0; Index < byte_use; Index ++) { - byte = pDCTstat->spd_data.spd_bytes[dimm][Index]; - CRC ^= byte << 8; - for (i = 0; i < 8; i++) { - if (CRC & 0x8000) { - CRC <<= 1; - CRC ^= 0x1021; - } else - CRC <<= 1; - } - } - return CRC == (pDCTstat->spd_data.spd_bytes[dimm][SPD_byte_127] << 8 | pDCTstat->spd_data.spd_bytes[dimm][SPD_byte_126]); + return crc_calc == checksum_spd; } int32_t abs(int32_t val) |