summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Rudolph <patrick.rudolph@9elements.com>2018-07-11 13:54:50 +0200
committerPhilipp Deppenwiese <zaolin.daisuki@gmail.com>2018-07-12 15:21:36 +0000
commitf4d81e03859f3dfed186b6a4314bb0fb59cf14ac (patch)
tree43a6de19558b11b6520fb260dcfa99436d322cb1
parent679d624fae6d96e53264c2b6f0dd6216636fab15 (diff)
Coverity: Fix CID1393978
Fix a typo. Only memcpy into target buffer if pointer is not NULL. Change-Id: I1aa4b2ce1843e53ab6ed2224eaa928fc79ea3b83 Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> Reviewed-on: https://review.coreboot.org/27446 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
-rw-r--r--src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c b/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c
index a8e65f061a..0df70ebc47 100644
--- a/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c
+++ b/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c
@@ -519,7 +519,7 @@ int bdk_device_add(bdk_node_t node, int ecam, int bus, int dev, int func)
{
int grow = device_list_max + DEVICE_GROW;
bdk_device_t *tmp = malloc(grow * sizeof(bdk_device_t));
- if (!tmp)
+ if (tmp)
memcpy(tmp, device_list, device_list_max * sizeof(bdk_device_t));
free(device_list);
if (tmp == NULL)