summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Georgi <pgeorgi@google.com>2014-11-24 22:02:21 +0100
committerPatrick Georgi <pgeorgi@google.com>2014-11-25 13:04:38 +0100
commitbd79296d34487605c87147738bd642beb7d502af (patch)
treeaaed7c06a1f371bd3f8d551077f4b6a787ce2722
parent80b880fa912164a3e77a02ad8cf24f64f31f065d (diff)
amd/fam10: Fix pstate configuration
Testing for msr.hi | PS_EN_MASK doesn't make sense. Change-Id: If3305e4255f227be4bb7a5496a625ef2a50a5808 Found-by: Coverity Scan Signed-off-by: Patrick Georgi <pgeorgi@google.com> Reviewed-on: http://review.coreboot.org/7578 Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Tested-by: build bot (Jenkins)
-rw-r--r--src/cpu/amd/model_10xxx/fidvid.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cpu/amd/model_10xxx/fidvid.c b/src/cpu/amd/model_10xxx/fidvid.c
index 4297c90460..d3c67a9fa0 100644
--- a/src/cpu/amd/model_10xxx/fidvid.c
+++ b/src/cpu/amd/model_10xxx/fidvid.c
@@ -196,7 +196,7 @@ static u8 setPStateMaxVal( device_t dev ) {
msr.hi |= PS_EN_MASK ;
wrmsr(PS_REG_BASE + i, msr);
}
- if (msr.hi | PS_EN_MASK) {
+ if (msr.hi & PS_EN_MASK) {
maxpstate = i;
}
}