summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJustin TerAvest <teravest@chromium.org>2018-01-31 13:07:54 -0700
committerMartin Roth <martinroth@google.com>2018-02-06 16:08:05 +0000
commitad282592b450c6309abe829f3c4e0d2b0111fb31 (patch)
treeefb99f11ad7c401e2a9f7d221ae577d129d617a3
parentf9d9781292aab5ea6c4a5058aca895b575e279a7 (diff)
mb/google/kahlee: Fix grunt I2C rise/fall times
I2C bus rise/fall times were measured as follows. Signals were generated with: - bus 0: manual i2c driver in depthcharge - bus 2,3: i2cdetect -r <bus_number> and then measured manually with an oscilloscope. BUG=b:72442912 Change-Id: I291e144249271ec34a93417398e54e68b8e21e23 Signed-off-by: Justin TerAvest <teravest@chromium.org> Reviewed-on: https://review.coreboot.org/23520 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
-rw-r--r--src/mainboard/google/kahlee/variants/grunt/devicetree.cb18
1 files changed, 9 insertions, 9 deletions
diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
index 9665a78675..7ffc0aca0c 100644
--- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
@@ -21,11 +21,11 @@ chip soc/amd/stoneyridge
register "uma_mode" = "UMAMODE_SPECIFIED_SIZE"
register "uma_size" = "128 * MiB"
- # TODO(teravest): Fix speeds here.
+ # Enable I2C0 for audio, USB3 hub at 400kHz
register "i2c[0]" = "{
.speed = I2C_SPEED_FAST,
- .rise_time_ns = 104,
- .fall_time_ns = 52,
+ .rise_time_ns = 95,
+ .fall_time_ns = 3,
}"
# Enable I2C1 for H1 at 400kHz
@@ -36,18 +36,18 @@ chip soc/amd/stoneyridge
.fall_time_ns = 4,
}"
- # TODO(teravest): Fix speeds here.
+ # Enable I2C2 for trackpad, pen at 400kHz
register "i2c[2]" = "{
.speed = I2C_SPEED_FAST,
- .rise_time_ns = 104,
- .fall_time_ns = 52,
+ .rise_time_ns = 117,
+ .fall_time_ns = 113,
}"
- # TODO(teravest): Fix speeds here.
+ # Enable I2C3 for touchscreen at 400kHz
register "i2c[3]" = "{
.speed = I2C_SPEED_FAST,
- .rise_time_ns = 104,
- .fall_time_ns = 52,
+ .rise_time_ns = 82,
+ .fall_time_ns = 67,
}"
device cpu_cluster 0 on