aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKeith Hui <buurin@gmail.com>2010-03-13 20:16:48 +0000
committerUwe Hermann <uwe@hermann-uwe.de>2010-03-13 20:16:48 +0000
commit9c1e1f0d3a562d6f1fb1a1bad5a8f58f62bf4613 (patch)
tree6de7fe916008931e6b9ed253a30849fd5ca11ebd
parentf7f9e92b4235169974c8f314ff6a921a0b7c4f9e (diff)
Add SDRAMPWR_4DIMM Kconfig option (not user-visible in menuconfig).
Each Intel 440BX board should select this option if it has 4 DIMM slots on the PCB, and _not_ select it (it defaults to 'n') if it has 3 DIMMs on the PCB. Signed-off-by: Keith Hui <buurin@gmail.com> Acked-by: Uwe Hermann <uwe@hermann-uwe.de> git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5204 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
-rw-r--r--src/mainboard/asus/p2b-d/Kconfig1
-rw-r--r--src/mainboard/asus/p2b-ds/Kconfig1
-rw-r--r--src/mainboard/asus/p2b-ls/Kconfig1
-rw-r--r--src/mainboard/asus/p3b-f/Kconfig1
-rw-r--r--src/northbridge/intel/i440bx/Kconfig13
-rw-r--r--src/northbridge/intel/i440bx/raminit.c6
6 files changed, 22 insertions, 1 deletions
diff --git a/src/mainboard/asus/p2b-d/Kconfig b/src/mainboard/asus/p2b-d/Kconfig
index 2e85fe0ad4..4f18006541 100644
--- a/src/mainboard/asus/p2b-d/Kconfig
+++ b/src/mainboard/asus/p2b-d/Kconfig
@@ -31,6 +31,7 @@ config BOARD_ASUS_P2B_D
select SMP
select UDELAY_TSC
select BOARD_ROMSIZE_KB_256
+ select SDRAMPWR_4DIMM
config MAINBOARD_DIR
string
diff --git a/src/mainboard/asus/p2b-ds/Kconfig b/src/mainboard/asus/p2b-ds/Kconfig
index 889648fbd0..dc77f19289 100644
--- a/src/mainboard/asus/p2b-ds/Kconfig
+++ b/src/mainboard/asus/p2b-ds/Kconfig
@@ -31,6 +31,7 @@ config BOARD_ASUS_P2B_DS
select SMP
select UDELAY_TSC
select BOARD_ROMSIZE_KB_256
+ select SDRAMPWR_4DIMM
config MAINBOARD_DIR
string
diff --git a/src/mainboard/asus/p2b-ls/Kconfig b/src/mainboard/asus/p2b-ls/Kconfig
index 973d1a333b..d1fd3975ee 100644
--- a/src/mainboard/asus/p2b-ls/Kconfig
+++ b/src/mainboard/asus/p2b-ls/Kconfig
@@ -29,6 +29,7 @@ config BOARD_ASUS_P2B_LS
select HAVE_PIRQ_TABLE
select UDELAY_TSC
select BOARD_ROMSIZE_KB_256
+ select SDRAMPWR_4DIMM
config MAINBOARD_DIR
string
diff --git a/src/mainboard/asus/p3b-f/Kconfig b/src/mainboard/asus/p3b-f/Kconfig
index c57ae30c3b..4e00e1224c 100644
--- a/src/mainboard/asus/p3b-f/Kconfig
+++ b/src/mainboard/asus/p3b-f/Kconfig
@@ -29,6 +29,7 @@ config BOARD_ASUS_P3B_F
select HAVE_PIRQ_TABLE
select UDELAY_TSC
select BOARD_ROMSIZE_KB_256
+ select SDRAMPWR_4DIMM
config MAINBOARD_DIR
string
diff --git a/src/northbridge/intel/i440bx/Kconfig b/src/northbridge/intel/i440bx/Kconfig
index 696e884705..4de84d3472 100644
--- a/src/northbridge/intel/i440bx/Kconfig
+++ b/src/northbridge/intel/i440bx/Kconfig
@@ -22,3 +22,16 @@ config NORTHBRIDGE_INTEL_I440BX
bool
select HAVE_HIGH_TABLES
+config SDRAMPWR_4DIMM
+ bool
+ depends on NORTHBRIDGE_INTEL_I440BX
+ default n
+ help
+ This option affects how the SDRAMC register is programmed.
+ Memory clock signals will not be routed properly if this option
+ is set wrong.
+
+ If your board has 4 DIMM slots, you must use select this option, in
+ your Kconfig file of the board. On boards with 3 DIMM slots,
+ do _not_ select this option.
+
diff --git a/src/northbridge/intel/i440bx/raminit.c b/src/northbridge/intel/i440bx/raminit.c
index 3de2dd7021..43e2a45e99 100644
--- a/src/northbridge/intel/i440bx/raminit.c
+++ b/src/northbridge/intel/i440bx/raminit.c
@@ -292,7 +292,11 @@ static const long register_values[] = {
* 0 = 3 clocks of RAS# precharge
* 1 = 2 clocks of RAS# precharge
*/
- SDRAMC + 0, 0x00, 0x00,
+#if CONFIG_SDRAMPWR_4DIMM
+ SDRAMC + 0, 0x00, 0x10, /* The board has 4 DIMM slots. */
+#else
+ SDRAMC + 0, 0x00, 0x00, /* The board has 3 DIMM slots.*/
+#endif
SDRAMC + 1, 0x00, 0x00,
/* PGPOL - Paging Policy Register