summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorUwe Hermann <uwe@hermann-uwe.de>2009-03-25 17:38:40 +0000
committerUwe Hermann <uwe@hermann-uwe.de>2009-03-25 17:38:40 +0000
commit83da8dcf608d4b6549399581463fe484b71bca6f (patch)
tree3dea58b9a07c7cb556499ba6892d68007ae1e676
parent951c63f2a5b57bfadbc48d2fca01db8686be8c02 (diff)
- List SMSC LPC47N227 runtime register block as supported.
- Add missing contributor in README. - Cosmetic fixes. Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Acked-by: Uwe Hermann <uwe@hermann-uwe.de> git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4029 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
-rw-r--r--util/superiotool/README1
-rw-r--r--util/superiotool/smsc.c12
-rw-r--r--util/superiotool/superiotool.c10
3 files changed, 12 insertions, 11 deletions
diff --git a/util/superiotool/README b/util/superiotool/README
index 07f9c7d14b..c7e6c30c22 100644
--- a/util/superiotool/README
+++ b/util/superiotool/README
@@ -89,6 +89,7 @@ David Hendricks <david.hendricks@gmail.com>
Frieder Ferlemann <Frieder.Ferlemann@web.de>
Idwer Vollering <idwer_v@hotmail.com>
Josh Profitt <zorn169@gmail.com>
+Michał Mirosław <mirq-linux@rere.qmqm.pl>
Rasmus Wiman <rasmus@wiman.org>
Robinson P. Tryon <bishop.robinson@gmail.com>
Ronald Hoogenboom <hoogenboom30@zonnet.nl>
diff --git a/util/superiotool/smsc.c b/util/superiotool/smsc.c
index cc796b1127..4d28ef7805 100644
--- a/util/superiotool/smsc.c
+++ b/util/superiotool/smsc.c
@@ -438,7 +438,7 @@ static const struct superio_registers reg_table[] = {
{0x6f, "LPC47B397", {
{EOT}}},
{0x74, "LPC47M182", { /* Only for LD_NUM = 0 */
- {NOLDN, NULL,
+ {NOLDN, NULL,
{0x02,0x03,0x07,0x20,0x21,0x22,0x23,0x24,0x26,0x27,
0x28,0x29,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT},
{0x00,RSVD,0x00,0x74,RSVD,0x00,RSVD,0x44,MISC,0x00,
@@ -655,6 +655,7 @@ static void probe_idregs_smsc_helper(uint16_t port, uint8_t idreg,
uint8_t revreg)
{
uint8_t id, rev;
+ uint16_t runtime_base;
const char *info = (idreg == 0x20) ? "(idregs=0x20/0x21) "
: "(idregs=0x0d/0x0e) ";
@@ -681,18 +682,16 @@ static void probe_idregs_smsc_helper(uint16_t port, uint8_t idreg,
LDN_SEL);
if (extra_dump) {
- uint16_t runtime_base;
switch (id) {
- case 0x5a:
+ case 0x5a: /* LPC47N227 */
runtime_base = regval(port, 0x30) << 4;
if (runtime_base)
dump_io(runtime_base, 16);
else
- printf("Runtime Register Block not mapped on this SuperIO.\n");
-
+ printf("Runtime Register Block not mapped on this Super I/O.\n");
break;
default:
- printf("No extra registers known for this chip\n");
+ printf("No extra registers known for this chip.\n");
}
}
@@ -708,4 +707,5 @@ void probe_idregs_smsc(uint16_t port)
void print_smsc_chips(void)
{
print_vendor_chips("SMSC", reg_table);
+ printf("SMSC LPC47N227 runtime register block\n\n");
}
diff --git a/util/superiotool/superiotool.c b/util/superiotool/superiotool.c
index 583a974fd4..6786b0a47f 100644
--- a/util/superiotool/superiotool.c
+++ b/util/superiotool/superiotool.c
@@ -161,13 +161,13 @@ void dump_io(uint16_t iobase, uint16_t length)
{
uint16_t i;
- printf("Dumping %d IO mapped registers at base 0x%04x:\n",
+ printf("Dumping %d I/O mapped registers at base 0x%04x:\n",
length, iobase);
- for (i=0; i<length; i++)
- printf ("%02x ", i);
+ for (i = 0; i < length; i++)
+ printf("%02x ", i);
printf("\n");
- for (i=0; i<length; i++)
- printf ("%02x ", INB(iobase +i));
+ for (i = 0; i < length; i++)
+ printf("%02x ", INB(iobase + i));
printf("\n");
}