summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2020-11-06 11:50:55 +0100
committerArthur Heymans <arthur@aheymans.xyz>2020-11-12 16:13:49 +0000
commit83b262275c43a2ff29c9d9364f25483fd690b803 (patch)
treeac9f0fecb3e82be9caf6ec86701667edbbe59f29
parent04ebdd9710fc62d0ed3f1388e37125eafc80f0d9 (diff)
soc/intel/xeon_sp: Use a common function to get the IIO HOB
TESTED ocp/deltalake still boots. Change-Id: I69f336c1ff348b8e820340b84494929f2c58ce72 Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/47296 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/soc/intel/xeon_sp/cpx/soc_util.c8
-rw-r--r--src/soc/intel/xeon_sp/nb_acpi.c10
-rw-r--r--src/soc/intel/xeon_sp/skx/soc_acpi.c6
-rw-r--r--src/soc/intel/xeon_sp/skx/soc_util.c15
4 files changed, 7 insertions, 32 deletions
diff --git a/src/soc/intel/xeon_sp/cpx/soc_util.c b/src/soc/intel/xeon_sp/cpx/soc_util.c
index 973d2588c5..d2d12d1eba 100644
--- a/src/soc/intel/xeon_sp/cpx/soc_util.c
+++ b/src/soc/intel/xeon_sp/cpx/soc_util.c
@@ -29,13 +29,7 @@ const struct SystemMemoryMapHob *get_system_memory_map(void)
uint8_t get_iiostack_info(struct iiostack_resource *info)
{
- size_t hob_size;
- const uint8_t fsp_hob_iio_universal_data_guid[16] = FSP_HOB_IIO_UNIVERSAL_DATA_GUID;
- const IIO_UDS *hob;
-
- hob = fsp_find_extension_hob_by_guid(
- fsp_hob_iio_universal_data_guid, &hob_size);
- assert(hob != NULL && hob_size != 0);
+ const IIO_UDS *hob = get_iio_uds();
// copy IIO Stack info from FSP HOB
info->no_of_stacks = 0;
diff --git a/src/soc/intel/xeon_sp/nb_acpi.c b/src/soc/intel/xeon_sp/nb_acpi.c
index 4a29c0868f..55c3d820ca 100644
--- a/src/soc/intel/xeon_sp/nb_acpi.c
+++ b/src/soc/intel/xeon_sp/nb_acpi.c
@@ -362,10 +362,7 @@ static unsigned long acpi_create_rmrr(unsigned long current)
static unsigned long acpi_create_rhsa(unsigned long current)
{
- size_t hob_size;
- const uint8_t uds_guid[16] = FSP_HOB_IIO_UNIVERSAL_DATA_GUID;
- const IIO_UDS *hob = fsp_find_extension_hob_by_guid(uds_guid, &hob_size);
- assert(hob != NULL && hob_size != 0);
+ const IIO_UDS *hob = get_iio_uds();
for (int socket = 0; socket < hob->PlatformData.numofIIO; ++socket) {
IIO_RESOURCE_INSTANCE iio_resource =
@@ -386,10 +383,7 @@ static unsigned long acpi_create_rhsa(unsigned long current)
static unsigned long acpi_fill_dmar(unsigned long current)
{
- size_t hob_size;
- const uint8_t uds_guid[16] = FSP_HOB_IIO_UNIVERSAL_DATA_GUID;
- const IIO_UDS *hob = fsp_find_extension_hob_by_guid(uds_guid, &hob_size);
- assert(hob != NULL && hob_size != 0);
+ const IIO_UDS *hob = get_iio_uds();
// DRHD
for (int iio = 1; iio <= hob->PlatformData.numofIIO; ++iio) {
diff --git a/src/soc/intel/xeon_sp/skx/soc_acpi.c b/src/soc/intel/xeon_sp/skx/soc_acpi.c
index 95563f5837..3ac46ffcfa 100644
--- a/src/soc/intel/xeon_sp/skx/soc_acpi.c
+++ b/src/soc/intel/xeon_sp/skx/soc_acpi.c
@@ -17,6 +17,7 @@
#include <soc/pci_devs.h>
#include <soc/pm.h>
#include <soc/soc_util.h>
+#include <soc/util.h>
/* TODO: Check if the common/acpi weak function can be used */
unsigned long acpi_fill_mcfg(unsigned long current)
@@ -99,10 +100,7 @@ void soc_fill_fadt(acpi_fadt_t *fadt)
void uncore_inject_dsdt(const struct device *device)
{
- size_t hob_size;
- const uint8_t uds_guid[16] = FSP_HOB_IIO_UNIVERSAL_DATA_GUID;
- const IIO_UDS *hob = fsp_find_extension_hob_by_guid(uds_guid, &hob_size);
- assert(hob != NULL && hob_size != 0);
+ const IIO_UDS *hob = get_iio_uds();
/* Only add RTxx entries once. */
if (device->bus->secondary != 0)
diff --git a/src/soc/intel/xeon_sp/skx/soc_util.c b/src/soc/intel/xeon_sp/skx/soc_util.c
index 469fd60b5f..af6dfcc341 100644
--- a/src/soc/intel/xeon_sp/skx/soc_util.c
+++ b/src/soc/intel/xeon_sp/skx/soc_util.c
@@ -57,13 +57,7 @@ const struct SystemMemoryMapHob *get_system_memory_map(void)
uint8_t get_iiostack_info(struct iiostack_resource *info)
{
- size_t hob_size;
- const uint8_t fsp_hob_iio_universal_data_guid[16] = FSP_HOB_IIO_UNIVERSAL_DATA_GUID;
- const IIO_UDS *hob;
-
- hob = fsp_find_extension_hob_by_guid(
- fsp_hob_iio_universal_data_guid, &hob_size);
- assert(hob != NULL && hob_size != 0);
+ const IIO_UDS *hob = get_iio_uds();
// copy IIO Stack info from FSP HOB
info->no_of_stacks = 0;
@@ -83,15 +77,10 @@ uint8_t get_iiostack_info(struct iiostack_resource *info)
uint32_t get_socket_stack_busno(uint32_t socket, uint32_t stack)
{
- size_t hob_size;
- const IIO_UDS *hob;
- const uint8_t fsp_hob_iio_universal_data_guid[16] = FSP_HOB_IIO_UNIVERSAL_DATA_GUID;
+ const IIO_UDS *hob = get_iio_uds();
assert(socket < MAX_SOCKET && stack < MAX_IIO_STACK);
- hob = fsp_find_extension_hob_by_guid(fsp_hob_iio_universal_data_guid, &hob_size);
- assert(hob != NULL && hob_size != 0);
-
return hob->PlatformData.CpuQpiInfo[socket].StackBus[stack];
}