summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2020-11-12 21:05:09 +0100
committerArthur Heymans <arthur@aheymans.xyz>2020-11-20 10:17:56 +0000
commit695dd2977bb04024333d52bf561f67a5678845d9 (patch)
treecf84bce206ed29a8f43191453168302699efceb5
parent281868e55fb45c093a3342d7581f89e4a65548a6 (diff)
soc/intel/xeon_sp: Use common P2SB functions to generate HPET DMAR
This makes coreboot more robust as it does not need to rely on syncing values set by FSP and coreboot. Change-Id: I2d954acdb939e7cb92d44b434ae628d7d935d776 Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/47533 Reviewed-by: Christian Walter <christian.walter@9elements.com> Reviewed-by: Marc Jones <marc@marcjonesconsulting.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/soc/intel/xeon_sp/Kconfig1
-rw-r--r--src/soc/intel/xeon_sp/nb_acpi.c8
2 files changed, 6 insertions, 3 deletions
diff --git a/src/soc/intel/xeon_sp/Kconfig b/src/soc/intel/xeon_sp/Kconfig
index 3d3e8037db..5c7a667d2f 100644
--- a/src/soc/intel/xeon_sp/Kconfig
+++ b/src/soc/intel/xeon_sp/Kconfig
@@ -49,6 +49,7 @@ config CPU_SPECIFIC_OPTIONS
select SOC_INTEL_COMMON_BLOCK_GPIO_DUAL_ROUTE_SUPPORT
select SOC_INTEL_COMMON_BLOCK_GPIO_PADCFG_PADTOL
select SOC_INTEL_COMMON_BLOCK_PCR
+ select SOC_INTEL_COMMON_BLOCK_P2SB
select TSC_MONOTONIC_TIMER
select UDELAY_TSC
select SUPPORT_CPU_UCODE_IN_CBFS
diff --git a/src/soc/intel/xeon_sp/nb_acpi.c b/src/soc/intel/xeon_sp/nb_acpi.c
index 6d6eb00ea4..29f533fdc8 100644
--- a/src/soc/intel/xeon_sp/nb_acpi.c
+++ b/src/soc/intel/xeon_sp/nb_acpi.c
@@ -12,6 +12,7 @@
#include <soc/pci_devs.h>
#include <soc/soc_util.h>
#include <soc/util.h>
+#include <intelblocks/p2sb.h>
#include "chip.h"
@@ -267,11 +268,12 @@ static unsigned long acpi_create_drhd(unsigned long current, int socket,
//BIT 15
if (num_hpets && (num_hpets != 0x1f) &&
(read32((void *)(HPET_BASE_ADDRESS + 0x100)) & (0x00008000))) {
+ union p2sb_bdf hpet_bdf = p2sb_get_hpet_bdf();
printk(BIOS_DEBUG, " [Message-capable HPET Device] Enumeration ID: 0x%x, "
"PCI Bus Number: 0x%x, PCI Path: 0x%x, 0x%x\n",
- 0, HPET_BUS_NUM, HPET_DEV_NUM, HPET0_FUNC_NUM);
- current += acpi_create_dmar_ds_msi_hpet(current, 0, HPET_BUS_NUM,
- HPET_DEV_NUM, HPET0_FUNC_NUM);
+ 0, hpet_bdf.bus, hpet_bdf.dev, hpet_bdf.fn);
+ current += acpi_create_dmar_ds_msi_hpet(current, 0, hpet_bdf.bus,
+ hpet_bdf.dev, hpet_bdf.fn);
}
}