summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaul Menzel <pmenzel@molgen.mpg.de>2020-07-19 09:42:53 +0200
committerPatrick Georgi <pgeorgi@google.com>2020-07-26 21:40:16 +0000
commit56642930ab241c137c289e060d1ecc00dc6e5a4b (patch)
tree75fd38fc974ea01b20e458481927fcd25e72e0cf
parent4907e62893fb70e26f2d92b8de572b4767771812 (diff)
mb/lenovo: Prepend EC event number with 0x to denote hex notation
Currently, the message below is printed, suggesting it’s decimal notation: coreboot-4.12-1530-g7acbd5fc45 Sun Jul 19 07:47:58 UTC 2020 smm starting (log level: 7)... EC event 48 GPI (mask 1000) Prepend 0x, so it’s clear it’s hexadecimal notation. EC event 0x48 Use the command below change all places: git grep -l 'EC event %02x' | xargs sed -i 's/EC event %02x/EC event %#02x/' Change-Id: I8d1e6434a0e550c5a19576f9f7fea05e7a812e49 Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/43585 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
-rw-r--r--src/mainboard/lenovo/l520/smihandler.c2
-rw-r--r--src/mainboard/lenovo/t410/smihandler.c2
-rw-r--r--src/mainboard/lenovo/t420/smihandler.c2
-rw-r--r--src/mainboard/lenovo/t420s/smihandler.c2
-rw-r--r--src/mainboard/lenovo/t430/smihandler.c2
-rw-r--r--src/mainboard/lenovo/t430s/smihandler.c2
-rw-r--r--src/mainboard/lenovo/t440p/smihandler.c2
-rw-r--r--src/mainboard/lenovo/t520/smihandler.c2
-rw-r--r--src/mainboard/lenovo/t530/smihandler.c2
-rw-r--r--src/mainboard/lenovo/t60/smihandler.c2
-rw-r--r--src/mainboard/lenovo/x1_carbon_gen1/smihandler.c2
-rw-r--r--src/mainboard/lenovo/x201/smihandler.c2
-rw-r--r--src/mainboard/lenovo/x220/smihandler.c2
-rw-r--r--src/mainboard/lenovo/x230/smihandler.c2
-rw-r--r--src/mainboard/lenovo/x60/smihandler.c2
-rw-r--r--util/autoport/ec_lenovo.go2
16 files changed, 16 insertions, 16 deletions
diff --git a/src/mainboard/lenovo/l520/smihandler.c b/src/mainboard/lenovo/l520/smihandler.c
index 68e682fdbc..b5c6395f51 100644
--- a/src/mainboard/lenovo/l520/smihandler.c
+++ b/src/mainboard/lenovo/l520/smihandler.c
@@ -21,7 +21,7 @@ static void mainboard_smi_handle_ec_sci(void)
return;
event = ec_query();
- printk(BIOS_DEBUG, "EC event %02x\n", event);
+ printk(BIOS_DEBUG, "EC event %#02x\n", event);
}
void mainboard_smi_gpi(u32 gpi_sts)
diff --git a/src/mainboard/lenovo/t410/smihandler.c b/src/mainboard/lenovo/t410/smihandler.c
index ade22ff980..08b5d2f909 100644
--- a/src/mainboard/lenovo/t410/smihandler.c
+++ b/src/mainboard/lenovo/t410/smihandler.c
@@ -23,7 +23,7 @@ static void mainboard_smi_handle_ec_sci(void)
return;
event = ec_query();
- printk(BIOS_DEBUG, "EC event %02x\n", event);
+ printk(BIOS_DEBUG, "EC event %#02x\n", event);
switch (event) {
case 0x18:
diff --git a/src/mainboard/lenovo/t420/smihandler.c b/src/mainboard/lenovo/t420/smihandler.c
index b974f2a757..e72ef43617 100644
--- a/src/mainboard/lenovo/t420/smihandler.c
+++ b/src/mainboard/lenovo/t420/smihandler.c
@@ -20,7 +20,7 @@ static void mainboard_smi_handle_ec_sci(void)
return;
event = ec_query();
- printk(BIOS_DEBUG, "EC event %02x\n", event);
+ printk(BIOS_DEBUG, "EC event %#02x\n", event);
}
void mainboard_smi_gpi(u32 gpi_sts)
diff --git a/src/mainboard/lenovo/t420s/smihandler.c b/src/mainboard/lenovo/t420s/smihandler.c
index b974f2a757..e72ef43617 100644
--- a/src/mainboard/lenovo/t420s/smihandler.c
+++ b/src/mainboard/lenovo/t420s/smihandler.c
@@ -20,7 +20,7 @@ static void mainboard_smi_handle_ec_sci(void)
return;
event = ec_query();
- printk(BIOS_DEBUG, "EC event %02x\n", event);
+ printk(BIOS_DEBUG, "EC event %#02x\n", event);
}
void mainboard_smi_gpi(u32 gpi_sts)
diff --git a/src/mainboard/lenovo/t430/smihandler.c b/src/mainboard/lenovo/t430/smihandler.c
index df01686190..81cbc487f6 100644
--- a/src/mainboard/lenovo/t430/smihandler.c
+++ b/src/mainboard/lenovo/t430/smihandler.c
@@ -20,7 +20,7 @@ static void mainboard_smi_handle_ec_sci(void)
return;
event = ec_query();
- printk(BIOS_DEBUG, "EC event %02x\n", event);
+ printk(BIOS_DEBUG, "EC event %#02x\n", event);
}
void mainboard_smi_gpi(u32 gpi_sts)
diff --git a/src/mainboard/lenovo/t430s/smihandler.c b/src/mainboard/lenovo/t430s/smihandler.c
index 5a3cf35346..03c899e0d9 100644
--- a/src/mainboard/lenovo/t430s/smihandler.c
+++ b/src/mainboard/lenovo/t430s/smihandler.c
@@ -20,7 +20,7 @@ static void mainboard_smi_handle_ec_sci(void)
return;
event = ec_query();
- printk(BIOS_DEBUG, "EC event %02x\n", event);
+ printk(BIOS_DEBUG, "EC event %#02x\n", event);
}
void mainboard_smi_gpi(u32 gpi_sts)
diff --git a/src/mainboard/lenovo/t440p/smihandler.c b/src/mainboard/lenovo/t440p/smihandler.c
index dce3ebd427..e3da85d865 100644
--- a/src/mainboard/lenovo/t440p/smihandler.c
+++ b/src/mainboard/lenovo/t440p/smihandler.c
@@ -20,7 +20,7 @@ static void mainboard_smi_handle_ec_sci(void)
return;
event = ec_query();
- printk(BIOS_DEBUG, "EC event %02x\n", event);
+ printk(BIOS_DEBUG, "EC event %#02x\n", event);
}
void mainboard_smi_gpi(u32 gpi_sts)
diff --git a/src/mainboard/lenovo/t520/smihandler.c b/src/mainboard/lenovo/t520/smihandler.c
index 5a3cf35346..03c899e0d9 100644
--- a/src/mainboard/lenovo/t520/smihandler.c
+++ b/src/mainboard/lenovo/t520/smihandler.c
@@ -20,7 +20,7 @@ static void mainboard_smi_handle_ec_sci(void)
return;
event = ec_query();
- printk(BIOS_DEBUG, "EC event %02x\n", event);
+ printk(BIOS_DEBUG, "EC event %#02x\n", event);
}
void mainboard_smi_gpi(u32 gpi_sts)
diff --git a/src/mainboard/lenovo/t530/smihandler.c b/src/mainboard/lenovo/t530/smihandler.c
index 5a3cf35346..03c899e0d9 100644
--- a/src/mainboard/lenovo/t530/smihandler.c
+++ b/src/mainboard/lenovo/t530/smihandler.c
@@ -20,7 +20,7 @@ static void mainboard_smi_handle_ec_sci(void)
return;
event = ec_query();
- printk(BIOS_DEBUG, "EC event %02x\n", event);
+ printk(BIOS_DEBUG, "EC event %#02x\n", event);
}
void mainboard_smi_gpi(u32 gpi_sts)
diff --git a/src/mainboard/lenovo/t60/smihandler.c b/src/mainboard/lenovo/t60/smihandler.c
index 013c9b0a9d..fe732a32b5 100644
--- a/src/mainboard/lenovo/t60/smihandler.c
+++ b/src/mainboard/lenovo/t60/smihandler.c
@@ -90,7 +90,7 @@ static void mainboard_smi_handle_ec_sci(void)
return;
event = ec_query();
- printk(BIOS_DEBUG, "EC event %02x\n", event);
+ printk(BIOS_DEBUG, "EC event %#02x\n", event);
switch (event) {
/* brightness up */
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/smihandler.c b/src/mainboard/lenovo/x1_carbon_gen1/smihandler.c
index df01686190..81cbc487f6 100644
--- a/src/mainboard/lenovo/x1_carbon_gen1/smihandler.c
+++ b/src/mainboard/lenovo/x1_carbon_gen1/smihandler.c
@@ -20,7 +20,7 @@ static void mainboard_smi_handle_ec_sci(void)
return;
event = ec_query();
- printk(BIOS_DEBUG, "EC event %02x\n", event);
+ printk(BIOS_DEBUG, "EC event %#02x\n", event);
}
void mainboard_smi_gpi(u32 gpi_sts)
diff --git a/src/mainboard/lenovo/x201/smihandler.c b/src/mainboard/lenovo/x201/smihandler.c
index ade22ff980..08b5d2f909 100644
--- a/src/mainboard/lenovo/x201/smihandler.c
+++ b/src/mainboard/lenovo/x201/smihandler.c
@@ -23,7 +23,7 @@ static void mainboard_smi_handle_ec_sci(void)
return;
event = ec_query();
- printk(BIOS_DEBUG, "EC event %02x\n", event);
+ printk(BIOS_DEBUG, "EC event %#02x\n", event);
switch (event) {
case 0x18:
diff --git a/src/mainboard/lenovo/x220/smihandler.c b/src/mainboard/lenovo/x220/smihandler.c
index 5a3cf35346..03c899e0d9 100644
--- a/src/mainboard/lenovo/x220/smihandler.c
+++ b/src/mainboard/lenovo/x220/smihandler.c
@@ -20,7 +20,7 @@ static void mainboard_smi_handle_ec_sci(void)
return;
event = ec_query();
- printk(BIOS_DEBUG, "EC event %02x\n", event);
+ printk(BIOS_DEBUG, "EC event %#02x\n", event);
}
void mainboard_smi_gpi(u32 gpi_sts)
diff --git a/src/mainboard/lenovo/x230/smihandler.c b/src/mainboard/lenovo/x230/smihandler.c
index df01686190..81cbc487f6 100644
--- a/src/mainboard/lenovo/x230/smihandler.c
+++ b/src/mainboard/lenovo/x230/smihandler.c
@@ -20,7 +20,7 @@ static void mainboard_smi_handle_ec_sci(void)
return;
event = ec_query();
- printk(BIOS_DEBUG, "EC event %02x\n", event);
+ printk(BIOS_DEBUG, "EC event %#02x\n", event);
}
void mainboard_smi_gpi(u32 gpi_sts)
diff --git a/src/mainboard/lenovo/x60/smihandler.c b/src/mainboard/lenovo/x60/smihandler.c
index f239b4cf1a..b5889db406 100644
--- a/src/mainboard/lenovo/x60/smihandler.c
+++ b/src/mainboard/lenovo/x60/smihandler.c
@@ -92,7 +92,7 @@ static void mainboard_smi_handle_ec_sci(void)
return;
event = ec_query();
- printk(BIOS_DEBUG, "EC event %02x\n", event);
+ printk(BIOS_DEBUG, "EC event %#02x\n", event);
switch (event) {
/* brightness up */
diff --git a/util/autoport/ec_lenovo.go b/util/autoport/ec_lenovo.go
index 3113a33fbc..6851d6d1ed 100644
--- a/util/autoport/ec_lenovo.go
+++ b/util/autoport/ec_lenovo.go
@@ -112,7 +112,7 @@ static void mainboard_smi_handle_ec_sci(void)
return;
event = ec_query();
- printk(BIOS_DEBUG, "EC event %02x\n", event);
+ printk(BIOS_DEBUG, "EC event %#02x\n", event);
}
void mainboard_smi_gpi(u32 gpi_sts)