aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVladimir Serbinenko <phcoder@gmail.com>2013-11-26 02:42:52 +0100
committerVladimir Serbinenko <phcoder@gmail.com>2014-01-10 18:08:31 +0100
commit54124d3e5689f7ca8d27090c5ef0512876f8ec2d (patch)
tree5cfe1d4261e76c3f3a23a2b2ab106b11e4e2af7c
parenta37383db8081b66eafc3860ede23edbfd39ac8ad (diff)
Remove sprintf
Remove sprintf as if you can't easily use snprintf then you probably have buffer overflow. Change-Id: Ic4570e099a52d743aca938a2bfadb95981adc503 Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com> Reviewed-on: http://review.coreboot.org/4280 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
-rw-r--r--src/console/vsprintf.c14
-rw-r--r--src/include/string.h1
2 files changed, 0 insertions, 15 deletions
diff --git a/src/console/vsprintf.c b/src/console/vsprintf.c
index b1b6d475be..1fb834f382 100644
--- a/src/console/vsprintf.c
+++ b/src/console/vsprintf.c
@@ -57,20 +57,6 @@ static int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
return i;
}
-int sprintf(char *buf, const char *fmt, ...)
-{
- va_list args;
- int i;
-
- va_start(args, fmt);
- /* A trick: we have at most (size_t)-1 adressable space anyway, so
- if we output so much we'll crash anyway. */
- i = vsnprintf(buf, -1, fmt, args);
- va_end(args);
-
- return i;
-}
-
int snprintf(char *buf, size_t size, const char *fmt, ...)
{
va_list args;
diff --git a/src/include/string.h b/src/include/string.h
index dc125e19b0..b4d0268419 100644
--- a/src/include/string.h
+++ b/src/include/string.h
@@ -16,7 +16,6 @@ void *memset(void *s, int c, size_t n);
int memcmp(const void *s1, const void *s2, size_t n);
void *memchr(const void *s, int c, size_t n);
#if !defined(__PRE_RAM__)
-int sprintf(char * buf, const char *fmt, ...);
int snprintf(char * buf, size_t size, const char *fmt, ...);
#endif