diff options
| author | Patrick Georgi <patrick@georgi-clan.de> | 2014-08-10 15:44:04 +0200 |
|---|---|---|
| committer | Patrick Georgi <patrick@georgi-clan.de> | 2014-08-11 08:21:45 +0200 |
| commit | 4ef309e85db0f44888650f98eead220ad147aa14 (patch) | |
| tree | 458ba4bd0d322ad1075bb7b58021a2a6dc89e3a4 | |
| parent | bfca984b782585fba7ff800dfa2190f518d2c521 (diff) | |
board-status: avoid shell error
[ $3 -eq 1 ] fails if no third argument is given.
[ "$3" -eq 1 ] still fails.
Doing a string comparison is robust across shells.
Change-Id: I3ee388fdbe51b7ab9344d86e67827654714d3191
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/6576
Tested-by: build bot (Jenkins)
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
| -rwxr-xr-x | util/board_status/board_status.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh index 7389478614..de83d36325 100755 --- a/util/board_status/board_status.sh +++ b/util/board_status/board_status.sh @@ -49,7 +49,7 @@ test_cmd() return 0 fi - if [ $3 -eq 1 ]; then + if [ "$3" = "1" ]; then return 1 fi |