diff options
| author | Daniele Forsi <dforsi@gmail.com> | 2014-07-14 15:35:42 +0200 |
|---|---|---|
| committer | Patrick Georgi <patrick@georgi-clan.de> | 2014-07-15 11:03:36 +0200 |
| commit | 3bb0b7230c07cb1d5b71df6976a8323c1cb41ca0 (patch) | |
| tree | 0996199e8abec07a6d1501da6c5d4c486f9abaff | |
| parent | be5340bad23af53b4e78adb143fed926ff199c7c (diff) | |
util/xcompile: Print fatal error messages to stderr instead of stdout
This uses die() which was previously unused.
Before this change an unhelpful error message was printed when make tried
to parse English text as if it was part of the makefile:
.xcompile:1: *** missing separator (did you mean TAB instead of 8 spaces?). Stop.
After this change the first error message at least mentions that iasl is
missing:
ERROR: no iasl found
make: -print-libgcc-file-name: Command not found
make: -print-libgcc-file-name: Command not found
make: -print-libgcc-file-name: Command not found
/bin/sh: 0: Illegal option -
Makefile.inc:36: *** Please use the coreboot toolchain (or prove that your toolchain works). Stop.
Change-Id: I79d5de5993e3828460130192df376daa55f32aa0
Signed-off-by: Daniele Forsi <dforsi@gmail.com>
Reviewed-on: http://review.coreboot.org/6272
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <gaumless@gmail.com>
| -rw-r--r-- | util/xcompile/xcompile | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index d133bd2a59..823924341a 100644 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -49,8 +49,7 @@ if [ "$(${XGCCPATH}/iasl 2>/dev/null | grep -c ACPI)" -gt 0 ]; then elif [ "$(iasl 2>/dev/null | grep -c ACPI)" -gt 0 ]; then IASL=iasl else - echo "no iasl found" - exit 1 + die "no iasl found" fi if program_exists gcc; then @@ -58,8 +57,7 @@ if program_exists gcc; then elif program_exists cc; then HOSTCC=cc else - echo "no host compiler found" - exit 1 + die "no host compiler found" fi cat <<EOF @@ -196,8 +194,7 @@ test_architecture() { if type arch_config_$architecture > /dev/null; then arch_config_$architecture else - echo "no architecture definition for $architecture" - exit 1 + die "no architecture definition for $architecture" fi # To override toolchain, define CROSS_COMPILE_$arch or CROSS_COMPILE as |