diff options
| author | Marshall Dawson <marshalldawson3rd@gmail.com> | 2019-10-29 11:44:16 -0600 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2019-10-30 21:42:53 +0000 |
| commit | 376357c1078ca53573cfb338877d37398ce76978 (patch) | |
| tree | 8df08cfcf5a2152341c7da921abac2bb8bc816ca | |
| parent | 86278a036120ff5be8b5d99b31b15460f54bf2d8 (diff) | |
Makefile.inc: Consolidate submodule comments
Reduce duplicated comments explaining that submodules' settings in
.gitmodules are update=none, and that --checkout is required. This
prepares for another submodule, and makes adding a third set of
comments unnecessary.
Change-Id: I7721333a61122284ed9975ecd2adc3271a879728
Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36440
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
| -rw-r--r-- | Makefile.inc | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/Makefile.inc b/Makefile.inc index 04c83d84d5..3ca113be4d 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -197,13 +197,11 @@ ifneq ($(UPDATED_SUBMODULES),1) # try to fetch non-optional submodules if the source is under git forgetthis:=$(if $(GIT),$(shell git submodule update --init)) ifeq ($(CONFIG_USE_BLOBS),y) -# this is necessary because 3rdparty/{blobs,intel-microcode} is update=none, and so is ignored -# unless explicitly requested and enabled through --checkout +# These items are necessary because each has update=none in .gitmodules. They are ignored +# until expressly requested and enabled with --checkout forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/blobs)) forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/intel-microcode)) ifeq ($(CONFIG_PLATFORM_USES_FSP1_0)$(CONFIG_PLATFORM_USES_FSP1_1)$(CONFIG_PLATFORM_USES_FSP2_0),y) -# this is necessary because 3rdparty/fsp is update=none, and so is ignored -# unless explicitly requested and enabled through --checkout forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/fsp)) endif endif |