summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Lemenkov <lemenkov@gmail.com>2019-02-10 23:33:54 +0100
committerPatrick Georgi <pgeorgi@google.com>2019-02-14 07:54:47 +0000
commit272804ff014ea736f1a325cc8a118a590ba3f388 (patch)
treed264c081738a9bd25a16c86ccedf7ca093eadba2
parent485937fd4f184374ca95fe9541d3cf1e18d0c21b (diff)
superio/nsc/pc87366: Use common early_serial
Change-Id: I1f03182cd760ea63df78ef3e2b2604c3322b4f3f Signed-off-by: Peter Lemenkov <lemenkov@gmail.com> Reviewed-on: https://review.coreboot.org/c/31336 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
-rw-r--r--src/superio/nsc/pc87366/Kconfig1
-rw-r--r--src/superio/nsc/pc87366/Makefile.inc2
-rw-r--r--src/superio/nsc/pc87366/early_serial.c29
-rw-r--r--src/superio/nsc/pc87366/pc87366.h5
4 files changed, 1 insertions, 36 deletions
diff --git a/src/superio/nsc/pc87366/Kconfig b/src/superio/nsc/pc87366/Kconfig
index e42aa07bed..bf17117812 100644
--- a/src/superio/nsc/pc87366/Kconfig
+++ b/src/superio/nsc/pc87366/Kconfig
@@ -15,3 +15,4 @@
config SUPERIO_NSC_PC87366
bool
+ select SUPERIO_NSC_COMMON_PRE_RAM
diff --git a/src/superio/nsc/pc87366/Makefile.inc b/src/superio/nsc/pc87366/Makefile.inc
index 6e558ac432..f432530f35 100644
--- a/src/superio/nsc/pc87366/Makefile.inc
+++ b/src/superio/nsc/pc87366/Makefile.inc
@@ -15,6 +15,4 @@
## GNU General Public License for more details.
##
-bootblock-$(CONFIG_SUPERIO_NSC_PC87366) += early_serial.c
-romstage-$(CONFIG_SUPERIO_NSC_PC87366) += early_serial.c
ramstage-$(CONFIG_SUPERIO_NSC_PC87366) += superio.c
diff --git a/src/superio/nsc/pc87366/early_serial.c b/src/superio/nsc/pc87366/early_serial.c
deleted file mode 100644
index b088093bf3..0000000000
--- a/src/superio/nsc/pc87366/early_serial.c
+++ /dev/null
@@ -1,29 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2000 AG Electronics Ltd.
- * Copyright (C) 2003-2004 Linux Networx
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-#include <arch/io.h>
-#include <device/pnp.h>
-#include <stdint.h>
-#include "pc87366.h"
-
-void pc87366_enable_serial(pnp_devfn_t dev, u16 iobase)
-{
- pnp_set_logical_device(dev);
- pnp_set_enable(dev, 0);
- pnp_set_iobase(dev, PNP_IDX_IO0, iobase);
- pnp_set_enable(dev, 1);
-}
diff --git a/src/superio/nsc/pc87366/pc87366.h b/src/superio/nsc/pc87366/pc87366.h
index 7f4a9955d9..b1df69f355 100644
--- a/src/superio/nsc/pc87366/pc87366.h
+++ b/src/superio/nsc/pc87366/pc87366.h
@@ -34,9 +34,4 @@
#define PC87366_VLM 0x0D
#define PC87366_TMS 0x0E
-#include <arch/io.h>
-#include <stdint.h>
-
-void pc87366_enable_serial(pnp_devfn_t dev, u16 iobase);
-
#endif /* SUPERIO_NSC_PC87366_H */