summaryrefslogtreecommitdiff
path: root/.gitreview
diff options
context:
space:
mode:
authorLennart Eichhorn <lennarteichhorn@googlemail.com>2023-12-01 18:17:39 +0100
committerFelix Held <felix-coreboot@felixheld.de>2024-01-17 16:03:54 +0000
commit182e56964e8504ba3e460d7c6af59e1f900ab373 (patch)
tree3baf84e5567c31931c9e675383644c9a92af8b1f /.gitreview
parentf55b711c07f6454c38a2de31c3eef5d489e639dd (diff)
vc/amd/psp: Remove unknown section flags
The `d` flag used in .section is unknown in LLVM/clang 17 and fails the build. It is also not documented in the ARM compiler manual. The GNU assembler supports the `d` flag but it also seems to compile without. ARM compiler manual: https://developer.arm.com/documentation/101754/0621/armclang-Reference/armclang-Integrated-Assembler/Section-directives GNU compiler manual: https://sourceware.org/binutils/docs/as/Section.html `coreboot.rom` does not change between compiling a google skyrim board with or without this patch. However the debug info for the following three files in the build directory changes with this patch: * build/verstage/vendorcode/amd/fsp/mendocino/bl_uapp/bl_uapp_end.o * build/cbfs/fallback/verstage.elf * build/cbfs/fallback/verstage.debug Change-Id: Ie3735b72349b0cfdd27364a39bcdda390af7bfa5 Signed-off-by: Lennart Eichhorn <lennarteichhorn@googlemail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79366 Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to '.gitreview')
0 files changed, 0 insertions, 0 deletions