| Age | Commit message (Collapse) | Author |
|---|
|
ub-contactsdialer-a-dev
|
|
ub-contactsdialer-a-dev
|
|
To support call blocking, added BLOCKED call type.
Also added utility to be able to mark the most recent call from a
number as BLOCKEd in the call log database.
Added REJECTED call type as well. This is not presently used within
our application, but we want to reserve the integer, anticipating
changes in the framework to add this constant.
Introduced AppCompConstants, because BLOCKED and REJECTED call type
values will not be defined as part of the API on M devices. Change
existing call type constants to reference this compatability class.
Bug: 24341350
Change-Id: I523ebd8dd1844a3b71a69a14bd38073be5940804
|
|
Bug: 22168682
Change-Id: Id0135ca03310f6c1587151af81c29b22e9d20d2b
|
|
OnboardingActivity is not referenced yet and its supporting
components will get stripped out by proguard causing the tests
to fail.
Change-Id: I71361b021f287e696c3732568ccc646c1ed9fb0b
|
|
|
|
* Add OnboardingActivity that controls the onboarding the UI
ensuring that the user grants the necessary permissions before
the Dialer can start.
* Add first pass (no graphics, eyeballed measurements) for the
screens that request for default dialer as well as permissions
* OnboardingActivity is not actually launched at this moment - will
be tied in to the various Dialer activities in a follow up CL.
* Add tests for logic that controls the display of the screens in
anticipation of future additions to the onboarding flow.
* Add mockito library to DialerTests's Android.mk
Bug: 24270592
Change-Id: I00d0f75edaecaa85042b136b0d830b5fbb3a0a73
|
|
|
|
Try to address race condition by checking for asserts immediately
for testFetchingVoicemail.
Bug: 24405834
Change-Id: I9c96f3932c30dfeeac18a2954810f856ca6e5e3c
|
|
Bug: 24341350
Change-Id: I2c4a4d04f3ed400e8f619879d94a708d3b0c1cf3
|
|
ub-contactsdialer-a-dev
|
|
Add a text field to manually enter a call type.
The TouchListener is so that if the user edits the text specifying
the custom type, the toggle is automatically switched to select
it as the call type.
Bug: 24341350
Change-Id: I524b211b17997280a6d4d3537411a39ada73e5de
|
|
Bug: 24406920
Change-Id: Ic38b075335cbbc2fdf93de193d471ed77ef2c57b
|
|
The issue was caused by a contact's phone number being removed,
but not the entire contact. Since we currently determine a list
of contacts to be updated by querying for a list of all updated
phone numbers, this would incorrectly exclude the aforementioned
modified contact.
* Use the Contact URI instead of the Phone URI when doing this query
to fix the problem
* Add tests for DialerDatabaseHelper update behavior
* Refactor small portions of DialerDatabaseHelper to facilitate
testing
Bug: 24053247
Change-Id: I18a7706ebbfd39fd686dc84bdbb842cc9e9b5e20
|
|
+ Reduces flakiness of test.
+ Rewrote random stress test to be more deterministic; simpler code
but still tests in general for the same scenario (rebinding
viewholders for different presentation types).
Bug: 23640774
Change-Id: I57adf16f9becc5cb7354563986f55f9023e4aabd
|
|
|
|
There appears to be two issues which were borking this, although I'm not sure why
there was the change (maybe it's been around a long time).
A single instance of presenter is retained over time, which is no good for our case
where we're creating different FakeAsyncTaskExecutors each time, so added a method
for testing where we can clear the instance.
Secondly, the method checking the text views didn't work anymore. Not sure why, but
I added a hook into the state text so the tests can continue to check for that.
Bug: 23640774
Change-Id: Ie729627f3bb4ee08476d5ad0198e43cfea72ce5c
|
|
There was a change in assumptions where groups are added for
standalone elements, but missed updating the unit tests for the
GroupBuilder to reflect those changes.
Bug: 23640774
Change-Id: I89576bd003119ce1da675181adbf557e7b996057
|
|
|
|
+ Persist speakerphone setting across resume/pause.
+ Allow toggling speakerphone before voicemail is played or while
loading.
Bug: 23566924
Bug: 23716100
Change-Id: Icc7342be85bd6df0f4678134b222f2200d3fc56d
|
|
ub-contactsdialer-a-dev
|
|
This will hopefully make the CallLogFragmentTest more robust against
testing race conditions.
Bug: 23640774
Change-Id: I20a0fe7c7724a3c026b3f7520e475180b8f22270
|
|
|
|
Bug: 23422274
Change-Id: Ib67080b2eb71006eb52cbef58983788baa97c712
|
|
Use PopupMenu to get a Menu instance, instead of using an internal
MenuBuilder.
Bug: 23640774
Change-Id: I356eba8a646ca1d09e6bca0887cfc03adf12782b
|
|
- Remove expand/collapse and item type logic in GroupingListAdapter.
Losing some potential functionality, but it does not adversely
affect how we currently group, and makes grouping easier to
understanding.
+ Rewrite GroupingListAdapter to provide O(1) lookup for group size
and getItem. This requires maintaining a SparseIntArray of metadata
for each list item. Cut metadata storage from long to int, to help
adjust for the larger memory overhead.
+ Simplify the logic for building and maintaing the metadata in the
GroupingListAdapter, offloading much of it to the SparseIntArray.
+ Explictily add all groups, including groups with single items,
in the CallLogBroupBuilder.
+ Tidied up logic in CallLogGroupBuilder to make it more intuitive
what cases it's handling and what's happening.
+ Updated tests to work and pass with new tests.
Bug: 23422274
Change-Id: Ia7a00c4b580813cade87fdc054ffdd702f59c12c
|
|
Also add tests and update test APK manifest to allow it to be
installed.
Bug: 22007312
Change-Id: Ibc71d9efd8666c38b0d879a27dae3f5642ce383c
|
|
Build tests against current SDK. Use android-support-test instead of
android.test.runner. Temporarily disable ContextMenuBuilder tests.
Use internal copy of LaunchPerformanceBase. Use reflection to call
CursorLoader.waitForLoader. Make local copy of
android.provider.CallLog.addCall.
Bug:23642167
Change-Id: I6b5901f60cd28cdee4857d9e66696a5c66efcd20
(cherry picked from commit 81b66b8ef878e6209e6f7dfc011e41fe806ec099)
|
|
|
|
Authority name for FilteredNumberProvider changed so it can be
overriden in GoogleDialer.
Added UNIQUE constraint to NORMALIZED_NUMBER field.
Added NUMBER field to filtered_number_table (un-normalized number).
Bug: 23424013
Bug: 23424011
Change-Id: I3156cee70ddcaea15b7272650d5f255782e34520
|
|
|
|
Bug: 23350722
Bug: 23350276
Change-Id: I070434cead43aa93026aa6b00ab886aa2947b1e6
|
|
Change-Id: Ic86c8e03ab55e31df7c66602218e1822b8fc23d5
|
|
This improves call log scrolling performance.
+ Split "Wrapper" into a utility and a cache.
+ Use cache for repeated calls related to call logs.
+ In the process of fixing plumbing and typer, moved some phone call
detail classes into the more appropriate call log package.
+ Update tests.
Bug: 20524705
Change-Id: Ib8ee21e417c19f98f6474a5793416e8f99103b55
|
|
+ Control MediaPlayer instance more tightly. Wait until
prepareContent to initialize instance. Release MediaPlayer when it
is no longer needed.
+ Instead of using isFinishing, check explicitly for orientation
change to know whether to release MediaPlayer.
+ Change Presenter to singleton, to address audio change wonkiness.
+ Only create a Presenter if the call log fragment shows voicemail.
+ ... fixing a variety of cases.
- Temporarily disable proximity sensor until blocking issue is fixed.
Bug: 21856243
Change-Id: Ic06e98bb5278467c3cce726a06b6cf3d855861a2
|
|
We will use it to set windows flags to help make playback behaviors
reasonable.
Bug: 21856243
Change-Id: I7c1ecb9e225a507ea8956ccc31d667361a4b6824
|
|
+ Add voicemail primary action button, which expands the call log
and plays immediately when clicked.
+ Pass expand/collapse listener into the view holder. This is
necessary because it needs to be triggered when the "play" primary
action is clicked so that the CallLogAdapter correctly registers
what has been added and binded.
+ Update primary action button state when showing or hiding actions,
so the visibility of the voicemail play button is managed properly.
+ Ensure voicemail playback state is consistent between multiple
call log items when the user initiates a collapse or expand. Add
reset function to help manage this.
+ With the reset, protect against the possibility of functions in
the presenter being called when no voicemail playback view is set.
Bug: 21654755
Change-Id: I7bcf67d27fa08fe77d1334dc084b52effe8d3ccc
|
|
|
|
|
|
Not sure precisely why this changed, but hopefully this logic is
more robust. Show the geocoded location if there is no name to use
and a location is available.
Removed GEOCODE_AS_LABEL, which wasn't really used anymore.
Bug: 21814339
Change-Id: I1343282ef415647853d7995d900a3f50186ad156
|
|
Change-Id: I9568ab3236ab02125c3d7da5f8a477df34bd7499
|
|
+ This is the call button on the standard call log list item, but
will be play on voicemail call log list items.
+ Add call "list" action for voicemail call log list items.
Change-Id: I4b115b96738b77c8a19c1071d5290e65f93395ac
|
|
- Delete old report button/handling code.
+ Convert menu click listeners into single onMenuItemClick method.
+ Add and populate objectId on PhoneCallDetails, to be able to
tell from the CallDetailActivity whether to enable reporting.
Change-Id: Ie4b9a3c1835792cbba04dc826f71fd2e53071400
|
|
|
|
It's been a pain to add/change fields on PhoneCallDetails because
a multitude of parameters required for the constructors to create
an instance. I ran into this while considering how to add an
objectId to its parameters, and have previously too...
Make fields non-final so that they are more easily set. This has
the side-effect of making the casing of some initialization code
more straightforward.
+ Change it's constructor to a subset of required fields.
+ Simplify/reorganize CallLogAdapter and CallLogAsyncTaskUtil code.
+ Simplify tests.
Bug: 21733599
Change-Id: I236dfb0b8e6513f4b44dbdae17ce2eb9c9ae4778
|
|
Run "changeCursor" on the main thread. I'm not precisely sure why
this fixes things, but it appeared before that the data I had on my
local device was being used instead of the test data.
Bug: 21471763
Change-Id: I6bece02e7c6828d54f76b5221ad10cf8f0052aa9
|
|
+ Pull out voicemail playback tests into their own test class.
+ Fix CallDetailActivity unit tests.
+ Some minor tweaks to functional code to facilitate.
Bug: 21471763
Change-Id: I0f1747ab7ad6eba7dd2a7f6f8cfd060b409771bc
|
|
|
|
When this was refactored before, some of the logic was bad.
Some of the expected values were changed as well. I figured
"add to contacts" is a really bad default text, because we
don't actually support that action in call details. Also,
the strings returned by the library for describing relative
time spans changed.
Bug: 21471763
Change-Id: I0c78c89c9c2e44de198f1f9299711fc31fe81cb1
|
|
- Delete voicemail playback in the CallDetailActivity.
+ Add voicemail playback to the call log list items.
+ Move the VoicemailPlaybackPresenter to the CallLogFragment.
+ Fix some retaining state for both call log (expanded items), and
preserve rotation/state functionality for voicemail playback. This
included some changes to the Presenter logic.
+ Fix some tests.
Bug: 21471763
Bug: 21170557
Change-Id: I30aae3a52c5bbf74a5075a9666343c337b1fc0df
|
|
+ Reset the AsyncTaskExecutor's instance between calls in tests.
I don't know why this is necessary, but it fixes a class of problems
which were happening.
+ Don't try to release a media player if it has not been prepared.
+ Handle possible race conditions since MediaPlayer's async prepare
may be buffering or finished when a test assert is executed.
+ Add asset file no longer provided by variablespeed library.
- Cleanup some stream copy code.
Change-Id: I0ae5fde00514c6dcdb1e9c063435a13eed6e8528
|
|
+ Substitutes the existing playback widget in CallDetailActivity,
although the plan is to move this to the call log shortly.
+ Convert the widget from a fragment into a layout. This allows us
to more easily create multiple instances of the voicemail widget in
the same view, as we intend to do in the call log.
+ Shift UI-related logic from Presenter to the Layout.
+ Fix janky seeking, so that it now works correctly consistently
rather than sporadically, and doesn't need to buffer again.
- Remove the VariableSpeed player formerly used in the Presenter. We
don't use this functionality anymore, and this allows us to directly
used the framework MediaPlayer (instead of a custom legacy proxy).
Bug: 21170557
Bug: 20693172
Change-Id: Ia34f459df10e43763b32fdb0954f83e882664231
|
|
+ Factors out async tasks from Call Detail activity, so that in the
near future it can be invoked from the call log directly.
+ Create listener interfaces for actions to execute after tasks have
been completed.
+ Should have no logical/behavioral changes.
Hopefully, this creates a more opaque interface for activities or
other classes to perform these actions as well.
Bug: 21170557
Change-Id: I43aea7e37600d3978e285f047cba7ce75ebb5787
|
|
- Remove call to CallUtil to check if video is enabled. It seems
like it's fine to include the content description of what the
call was, if it was a video call, even if there is not a
video-enabled call account.
- Factor out PhoneNumberDisplayHelper so it doesn't need to be
an instance. This reduces some extra calls to getDisplayNameHelper.
Probably a marginal difference, performance-wise, but it probably
helps a smidgen and also simplifies the need for creating and
passing or recalculating various instances of things.
TODO: It'd be much better if PhoneCallDetails had a builder.
It's terribly painful to fix all the tests when adding fields...
Change-Id: I6da13dc8b6b047043aba871796a8ed13b112a227
|
|
- Remove increase/decrease playback rate functionality.
- Flip button controls below the scrubber.
- Delete TextController.
Bug: 20433758
Change-Id: Id628bac0c9f8baed014079f2a89ce912fd2bb549
|
|
+ Rename CallIntentUtils.java to IntentUtil.java.
+ Consolidate various intent creation methods to new file, and update
referenes throughout the application.
Bug: 20433758
Change-Id: Iee9e37985217c38c816124d0e74dff40a2871680
|
|
Bug: 20924950
Change-Id: I6163565ec508d245afd83112927d636a4a50f27e
|
|
Bug: 20348183
Change-Id: If1b193f933b4a7b2b322784b0cbbc66c210b25df
|
|
This isn't the prettiest thing ever, but with this the "framework" of
all of the changes for the new visual style of the call logs is in
place. From here on out, the remainder of tasks should be unblocked
and relatively independent.
+ Rename ...ItemViews to ...ItemViewHolder. This probably wasn't
completely necessary, but is more proper given the new architecture.
+ ViewHolder is now officially where most of the independent UI logic
for a single call log list item should live. This changelist moves
further in that direction by storing references and helpers in it, to
lessen what must be passed in from the adapter.
+ Split out the call action from the rest of the actions, since it
has a special treatment on the card.
+ Convert text action buttons into a vertical stack.
+ Consolidate action stylings into a single style, for simplicity.
+ Miscellaneous style and string changes to put things in a better
state. This included tweaking some of the (ripple) backgrounds.
+ Update tests, according to changes.
Bug: 19372817
Change-Id: Ic923c0bcbbc1c153952131d0c772df9e9589fb03
|
|
Yay, finally!
+ Replace ListView with RecyclerView in layout and fragment files.
+ Change GroupingListAdapter to extend RecyclerView.Adapter instead
of BaseAdapter.
+ Change CallLogListItemViews to extend RecyclerView.ViewHolder.
+ Adapt onBindViewHolder and onCreateViewHolder methods in the
CallLogAdapter.
+ Update/rework tests for related classes.
+ Fix a bug in the GroupingListAdapter, where childCount was not
updated for standalone views, and the previously cached group size
was used instead. Set childCount to 1 for standalone views.
- Removed the idea of creating different views for standalone vs
group vs group headers from the adapters. This logic has not been
used for quite some time and all these functions funneled into
createView/bindView methods anyways, so there is no logical
difference. If we need to create custom views in the future, we can
leverage onCreateViewHolder's viewType parameter.
Bug: 19372817
Change-Id: I1b7289340600609669db22d8bc89265240d0b561
|
|
- Remove custom testing method formerly in the adapter.
- Remove unused expand animate code.
Bug: 19372817
Change-Id: I78489d63ac9c3324cd80f8039d14a41813772e11
|
|
|
|
+ Copied in from com.android.common.widget. This component is pretty
specific to phone number / call log grouping anyways.
+ Changed CallLogAdapter to reference this GroupingListAdapter
instead of the one in the framework library.
+ Changed CallLogGroupBuilder to reference this adapter too.
+ Copy in tests too.
Next step: change GroupingListAdapter to extend RecyclerView.Adapter.
This will preserve existing grouping logic, despite switching to the
new view.
Bug: 19372817
Change-Id: Ic0186ca5fad06a3ae398b9d8f8006210077149dc
|
|
- Remove animation logic in CallLogFragment.
- Remove expand listener from CallLogAdapter.
+ Update tests and constructor.
This preemptively removes expand/collapse behavior. While this
will result in a janky short-term experience, this is an incremental
step in shifting to RecyclerView and the new "Card" UI. I figured it
would be most efficient to delete it straight up, rather than coding
in intermediate logic to work with the RecyclerView because it will be
made obsolete by the Cards UI anyways.
In the long run, expand/collapse animation behavior will be
restored once the call log is migrated to RecyclerView and converted
to Cards.
Bug: 19372817
Change-Id: Icbdc7dcb9f2f2223456c29334c826d38917b087a
|
|
|
|
This pulls code from the CallLogAdapter, with only tweaks to variable
names and comments, to create a ContactInfoCache responsible for logic
pertaining to looking up and caching contact info.
The logic is intended to be unchanged for now, although in the future
it can/should probably be cleaned up sometime.
Bug: 20038300
Change-Id: I60a57b0a665496522a6b51c9e6e41a4fd6dbad1f
|
|
This is an exact copy of ag/655143.
Bug: 19667686
Change-Id: I36d5e3e91b0e58e0fc4ecb4a3068c994f9b90111
|
|
Fix warnings of form: "libpng warning: iCCP: Not recognizing known
sRGB profile that has been edited". Most of these were swaped by
replacing the old assets with newer or equivalent versions.
Bug: 19536005
Change-Id: I0535c0876806607f4aa170a5839829fff367ab9a
|
|
Change-Id: I4cbc6d79985680b4b5fc6e807fb30908352900b5
|
|
- Remove isCallLog specific code from adapter; now everything will
always be in the call log.
- Remove unneeded adapter bits from ListsFragment; there is now no
shortcut card shown in the lists fragment.
- Remove call log list item extra. We won't bind badges using this
any more. This will be superseded by the actions. Remove
badge-related code in CallLogAdapter.
+ Leaving the add-person icon, since it will be used in the future.
Bug: 19372817
Bug: 19627987
Change-Id: I4db8149761b017e02e89c081930a05f3aafe9606
|
|
Change-Id: I84da99d70801a6d1621de0883b801fa43ea5e5fd
|
|
Change-Id: I46188070997ebc9b69f7d9b5a8ba9cb3c221b743
|
|
Bug: 18192406
Change-Id: I94df77ad8aaac8da5583ab80572c0bbd120b980e
|
|
|
|
The original CL to fix ActionBarControllerTest by using an
ActivityInstrumentationTestCase was too heavyweight and caused flaky
test. It was also indicative of a flaw in the original design that
ActionBar couldn't be mocked out easily.
Refactor the code so that:
1) getActionBar() is no longer needed
2) Respect the invariant that all access to the actionBar goes through the
ActionBarController (see the changes in ListsFragment) so that any change to
the ActionBar's hide offset can be tracked appropriately.
Bug: 17487016
Change-Id: I935b683ddb301ca5d3952889af1381bdbdcc97d3
|
|
Fix failure in CallLogListItemHelper#testGetCallDescription_Video
Add some documentation to CallDetailActivityTest
Bug: 17487016
Change-Id: I31594feccb936500b20e13f3db5c68cbe5435c6e
|
|
|
|
|
|
Create a MockActionBar that to prevent NPEs. For this an
ActivityInstrumentationTestCase is needed.
Bug: 17487016
Change-Id: Ieca95bec22c075ad64a1167e57f6b85f913bcf7e
|
|
Bug: 17487016
Change-Id: I4c13c3e826a4eb1de84708dfa27ad093b2134087
|
|
CallLogListItemView is a custom view that might have done
something once, but doesn't anymore. It makes the code more
complicated to read and requires a lot of casting that does
nothing at all.
Change-Id: I53efb35367d748aa3d164d0fb56686175967c90e
|
|
Call the "isVoicemailNumber(subId, number)" method instead
of the one with just the number. This is because we need to check
whether a number is the voicemail number for a specific phone account,
otherwise the UI would never correctly display "voicemail" for the
non-default SIM.
Bug:17925501
Change-Id: If1d6cb1acfcb570aca5e639858af8804bac202c0
|
|
Enabling/disabling of phone accounts was only used for SIP accounts and
is no longer necessary for the purpose it was put in.
Bug: 17510811
Change-Id: I41a2d11cfa85343fdf3f8681f1152d94abd79d2f
|
|
- Changing package from android.telecomm to android.telecom
- Changing package from com.android.telecomm to
com.android.server.telecomm.
- Renaming TelecommManager to TelecomManager.
Bug: 17364651
Change-Id: I44d6d6546cac53232e4e2be0ebe0391d02411309
|
|
Bug: 17253963
Change-Id: I9e9e56cdf4c9a60ac1e047bef0eba2ba0c8f10fb
|
|
Bug: 16211386
Change-Id: I0bda040bd6cd5c55ee7c708044befaad8977d460
|
|
Method signatures have changed for PhoneCallDetails and at some point the
wrong method call was made.
Bug: 16540503
Change-Id: Ie17facaa26aa6ebbb12a43b04d5ea4994b865a1f
|
|
* Restore action bar slid state only after onCreateOptionsMenu, when it has
an effect
* ActionBarController is now the only way to make changes to the offset of
the action bar so that it can appropriately restore its state
Bug: 16710397
Change-Id: Id9e0ebe210c89df0be56b32aa3bbd959cce88621
|
|
We will be adding the account label field to call details if there is
more than one account to disambiguate. Otherwise this field will be
hidden.
Bug: 16488229
Change-Id: Idb03d09d63372655504a5f9178e6f2e408aefb88
|
|
* Display voicemail transcriptions in the call log and call details
activity in the Dialer
* Fix a bug in CallDetailActivity that would result in multiple instances of VoicemailPlaybackFragment being added on rotation. Now, reuse the same fragment
if it is already present in the FragmentManager, to avoid creating new ones
* Simplify some test and ctor logic in PhoneCallDetails to reduce the pain
of adding new fields into PhoneCallDetails
* Simplified playback_layout.xml to remove unnecessary parent LinearLayouts
Bug: 16320164
Change-Id: Ie68acc9058aace49d8e64f44a0128de0b6a3f842
|
|
|
|
Bug:16347739
Change-Id: I810af831b782f0a7a6f3aa9df154c93c03c4080e
|
|
Change-Id: I4597b14110c1cee7f637ec125b839852ef0f34c4
|
|
Change-Id: I2e97b348e6316a8b3ccc39fd81013e7f514a2889
|
|
Database and call log are now updated when user confirms.
Bug: 11150383
Change-Id: Ic716e92bcb2280c1d352bd2232bda516e83349b2
|
|
|
|
This reverts commit cee1e65f0c411e35c4521922c3e9def13e01fe64.
Change-Id: Ic50fd443856ea7e22714423939ac782cd4e89276
|
|
|
|
Database and call log are now updated when user confirms.
Bug: 11150383
Change-Id: Iafaca2172f2d44a6edf8514f7d900888dab9cf0e
|
|
Requires cl/501841.
Call log:
1. Add video call affordance.
2. Add accessibility text for calls, video call afforance.
3. Fixed unit test
Call details:
1. Showing video icon when a call had video.
2. Changing call headings to indicate they were video calls.
Bug: 16013879
Bug: 16013344
Bug: 16013684
Change-Id: I53b5bf9b0b1a63f9d119318d59f690d310cca7c8
|
