summaryrefslogtreecommitdiff
path: root/tests/src
AgeCommit message (Collapse)Author
2015-09-03Move non-cache tests from Fragment to Adapter.Andrew Lee
This will hopefully make the CallLogFragmentTest more robust against testing race conditions. Bug: 23640774 Change-Id: I20a0fe7c7724a3c026b3f7520e475180b8f22270
2015-09-02Merge "Fix CallDetailActivityTest." into ub-contactsdialer-a-devAndrew Lee
2015-09-01Fix test method for showing promo card.Andrew Lee
Bug: 23422274 Change-Id: Ib67080b2eb71006eb52cbef58983788baa97c712
2015-09-01Fix CallDetailActivityTest.Andrew Lee
Use PopupMenu to get a Menu instance, instead of using an internal MenuBuilder. Bug: 23640774 Change-Id: I356eba8a646ca1d09e6bca0887cfc03adf12782b
2015-09-01Rewrite grouping logic in Dialer.Andrew Lee
- Remove expand/collapse and item type logic in GroupingListAdapter. Losing some potential functionality, but it does not adversely affect how we currently group, and makes grouping easier to understanding. + Rewrite GroupingListAdapter to provide O(1) lookup for group size and getItem. This requires maintaining a SparseIntArray of metadata for each list item. Cut metadata storage from long to int, to help adjust for the larger memory overhead. + Simplify the logic for building and maintaing the metadata in the GroupingListAdapter, offloading much of it to the SparseIntArray. + Explictily add all groups, including groups with single items, in the CallLogBroupBuilder. + Tidied up logic in CallLogGroupBuilder to make it more intuitive what cases it's handling and what's happening. + Updated tests to work and pass with new tests. Bug: 23422274 Change-Id: Ia7a00c4b580813cade87fdc054ffdd702f59c12c
2015-08-31Don't strip post dial string when handling DIAL intentYorke Lee
Also add tests and update test APK manifest to allow it to be installed. Bug: 22007312 Change-Id: Ibc71d9efd8666c38b0d879a27dae3f5642ce383c
2015-08-29Unbundled build fixes for testsJay Shrauner
Build tests against current SDK. Use android-support-test instead of android.test.runner. Temporarily disable ContextMenuBuilder tests. Use internal copy of LaunchPerformanceBase. Use reflection to call CursorLoader.waitForLoader. Make local copy of android.provider.CallLog.addCall. Bug:23642167 Change-Id: I6b5901f60cd28cdee4857d9e66696a5c66efcd20 (cherry picked from commit 81b66b8ef878e6209e6f7dfc011e41fe806ec099)
2015-08-21Merge "FilteredNumberProvider authority name & filtered_number_table changes"Anne Rong
2015-08-21FilteredNumberProvider authority name & filtered_number_table changesAnne Rong
Authority name for FilteredNumberProvider changed so it can be overriden in GoogleDialer. Added UNIQUE constraint to NORMALIZED_NUMBER field. Added NUMBER field to filtered_number_table (un-normalized number). Bug: 23424013 Bug: 23424011 Change-Id: I3156cee70ddcaea15b7272650d5f255782e34520
2015-08-19Merge "Create local database table + ContentProvider for filtered numbers"Anne Rong
2015-08-19Create local database table + ContentProvider for filtered numbersAnne Rong
Bug: 23350722 Bug: 23350276 Change-Id: I070434cead43aa93026aa6b00ab886aa2947b1e6
2015-07-27Add ability to add test voicemails from test appYorke Lee
Change-Id: Ic86c8e03ab55e31df7c66602218e1822b8fc23d5
2015-06-26Cache repeated Telecom requests from call log.Andrew Lee
This improves call log scrolling performance. + Split "Wrapper" into a utility and a cache. + Use cache for repeated calls related to call logs. + In the process of fixing plumbing and typer, moved some phone call detail classes into the more appropriate call log package. + Update tests. Bug: 20524705 Change-Id: Ib8ee21e417c19f98f6474a5793416e8f99103b55
2015-06-19Rewrite of MediaPlayer logic.Andrew Lee
+ Control MediaPlayer instance more tightly. Wait until prepareContent to initialize instance. Release MediaPlayer when it is no longer needed. + Instead of using isFinishing, check explicitly for orientation change to know whether to release MediaPlayer. + Change Presenter to singleton, to address audio change wonkiness. + Only create a Presenter if the call log fragment shows voicemail. + ... fixing a variety of cases. - Temporarily disable proximity sensor until blocking issue is fixed. Bug: 21856243 Change-Id: Ic06e98bb5278467c3cce726a06b6cf3d855861a2
2015-06-18Pass activity into VoicemailPlaybackPresenter.Andrew Lee
We will use it to set windows flags to help make playback behaviors reasonable. Bug: 21856243 Change-Id: I7c1ecb9e225a507ea8956ccc31d667361a4b6824
2015-06-15Add play voicemail primary action to call log.Andrew Lee
+ Add voicemail primary action button, which expands the call log and plays immediately when clicked. + Pass expand/collapse listener into the view holder. This is necessary because it needs to be triggered when the "play" primary action is clicked so that the CallLogAdapter correctly registers what has been added and binded. + Update primary action button state when showing or hiding actions, so the visibility of the voicemail play button is managed properly. + Ensure voicemail playback state is consistent between multiple call log items when the user initiates a collapse or expand. Add reset function to help manage this. + With the reset, protect against the possibility of functions in the presenter being called when no voicemail playback view is set. Bug: 21654755 Change-Id: I7bcf67d27fa08fe77d1334dc084b52effe8d3ccc
2015-06-15Merge "Fix abundance of "Custom" labels." into mnc-devAndrew Lee
2015-06-15Merge "Fix VoicemailPlaybackTest flakiness." into mnc-devAndrew Lee
2015-06-15Fix abundance of "Custom" labels.Andrew Lee
Not sure precisely why this changed, but hopefully this logic is more robust. Show the geocoded location if there is no name to use and a location is available. Removed GEOCODE_AS_LABEL, which wasn't really used anymore. Bug: 21814339 Change-Id: I1343282ef415647853d7995d900a3f50186ad156
2015-06-15Fix VoicemailPlaybackTest flakiness.Andrew Lee
Change-Id: I9568ab3236ab02125c3d7da5f8a477df34bd7499
2015-06-12Convert to primary action button on call log items.Andrew Lee
+ This is the call button on the standard call log list item, but will be play on voicemail call log list items. + Add call "list" action for voicemail call log list items. Change-Id: I4b115b96738b77c8a19c1071d5290e65f93395ac
2015-06-10Move "Report" to CallDetailActivity.Andrew Lee
- Delete old report button/handling code. + Convert menu click listeners into single onMenuItemClick method. + Add and populate objectId on PhoneCallDetails, to be able to tell from the CallDetailActivity whether to enable reporting. Change-Id: Ie4b9a3c1835792cbba04dc826f71fd2e53071400
2015-06-10Merge "Change PhoneCallDetail fields to be non-final." into mnc-devAndrew Lee
2015-06-10Change PhoneCallDetail fields to be non-final.Andrew Lee
It's been a pain to add/change fields on PhoneCallDetails because a multitude of parameters required for the constructors to create an instance. I ran into this while considering how to add an objectId to its parameters, and have previously too... Make fields non-final so that they are more easily set. This has the side-effect of making the casing of some initialization code more straightforward. + Change it's constructor to a subset of required fields. + Simplify/reorganize CallLogAdapter and CallLogAsyncTaskUtil code. + Simplify tests. Bug: 21733599 Change-Id: I236dfb0b8e6513f4b44dbdae17ce2eb9c9ae4778
2015-06-09Fix CallLogFragment UnitTests.Andrew Lee
Run "changeCursor" on the main thread. I'm not precisely sure why this fixes things, but it appeared before that the data I had on my local device was being used instead of the test data. Bug: 21471763 Change-Id: I6bece02e7c6828d54f76b5221ad10cf8f0052aa9
2015-06-09Fix some more unit tests...Andrew Lee
+ Pull out voicemail playback tests into their own test class. + Fix CallDetailActivity unit tests. + Some minor tweaks to functional code to facilitate. Bug: 21471763 Change-Id: I0f1747ab7ad6eba7dd2a7f6f8cfd060b409771bc
2015-06-04Merge "Move VM playback from details to call log." into mnc-devAndrew Lee
2015-06-03Fix unit test errors.Andrew Lee
When this was refactored before, some of the logic was bad. Some of the expected values were changed as well. I figured "add to contacts" is a really bad default text, because we don't actually support that action in call details. Also, the strings returned by the library for describing relative time spans changed. Bug: 21471763 Change-Id: I0c78c89c9c2e44de198f1f9299711fc31fe81cb1
2015-06-03Move VM playback from details to call log.Andrew Lee
- Delete voicemail playback in the CallDetailActivity. + Add voicemail playback to the call log list items. + Move the VoicemailPlaybackPresenter to the CallLogFragment. + Fix some retaining state for both call log (expanded items), and preserve rotation/state functionality for voicemail playback. This included some changes to the Presenter logic. + Fix some tests. Bug: 21471763 Bug: 21170557 Change-Id: I30aae3a52c5bbf74a5075a9666343c337b1fc0df
2015-06-01Fix CallDetailActivity tests.Andrew Lee
+ Reset the AsyncTaskExecutor's instance between calls in tests. I don't know why this is necessary, but it fixes a class of problems which were happening. + Don't try to release a media player if it has not been prepared. + Handle possible race conditions since MediaPlayer's async prepare may be buffering or finished when a test assert is executed. + Add asset file no longer provided by variablespeed library. - Cleanup some stream copy code. Change-Id: I0ae5fde00514c6dcdb1e9c063435a13eed6e8528
2015-05-27Refactor Voicemail Playback into standalone view.Andrew Lee
+ Substitutes the existing playback widget in CallDetailActivity, although the plan is to move this to the call log shortly. + Convert the widget from a fragment into a layout. This allows us to more easily create multiple instances of the voicemail widget in the same view, as we intend to do in the call log. + Shift UI-related logic from Presenter to the Layout. + Fix janky seeking, so that it now works correctly consistently rather than sporadically, and doesn't need to buffer again. - Remove the VariableSpeed player formerly used in the Presenter. We don't use this functionality anymore, and this allows us to directly used the framework MediaPlayer (instead of a custom legacy proxy). Bug: 21170557 Bug: 20693172 Change-Id: Ia34f459df10e43763b32fdb0954f83e882664231
2015-05-19Add AsyncTaskUtil for call log actions.Andrew Lee
+ Factors out async tasks from Call Detail activity, so that in the near future it can be invoked from the call log directly. + Create listener interfaces for actions to execute after tasks have been completed. + Should have no logical/behavioral changes. Hopefully, this creates a more opaque interface for activities or other classes to perform these actions as well. Bug: 21170557 Change-Id: I43aea7e37600d3978e285f047cba7ce75ebb5787
2015-05-19Performance improvements to call log scrolling.Andrew Lee
- Remove call to CallUtil to check if video is enabled. It seems like it's fine to include the content description of what the call was, if it was a video call, even if there is not a video-enabled call account. - Factor out PhoneNumberDisplayHelper so it doesn't need to be an instance. This reduces some extra calls to getDisplayNameHelper. Probably a marginal difference, performance-wise, but it probably helps a smidgen and also simplifies the need for creating and passing or recalculating various instances of things. TODO: It'd be much better if PhoneCallDetails had a builder. It's terribly painful to fix all the tests when adding fields... Change-Id: I6da13dc8b6b047043aba871796a8ed13b112a227
2015-05-14Change VM playback fragment layout.Andrew Lee
- Remove increase/decrease playback rate functionality. - Flip button controls below the scrubber. - Delete TextController. Bug: 20433758 Change-Id: Id628bac0c9f8baed014079f2a89ce912fd2bb549
2015-05-13Reorganize Intent utilities, add send SMS intent.Andrew Lee
+ Rename CallIntentUtils.java to IntentUtil.java. + Consolidate various intent creation methods to new file, and update referenes throughout the application. Bug: 20433758 Change-Id: Iee9e37985217c38c816124d0e74dff40a2871680
2015-05-12Indicate whether CallLogAdapter is for Recents.Andrew Lee
Bug: 20924950 Change-Id: I6163565ec508d245afd83112927d636a4a50f27e
2015-04-23Use TelecomManager.placeCall APIYorke Lee
Bug: 20348183 Change-Id: If1b193f933b4a7b2b322784b0cbbc66c210b25df
2015-04-16Move call log actions into expandable view.Andrew Lee
This isn't the prettiest thing ever, but with this the "framework" of all of the changes for the new visual style of the call logs is in place. From here on out, the remainder of tasks should be unblocked and relatively independent. + Rename ...ItemViews to ...ItemViewHolder. This probably wasn't completely necessary, but is more proper given the new architecture. + ViewHolder is now officially where most of the independent UI logic for a single call log list item should live. This changelist moves further in that direction by storing references and helpers in it, to lessen what must be passed in from the adapter. + Split out the call action from the rest of the actions, since it has a special treatment on the card. + Convert text action buttons into a vertical stack. + Consolidate action stylings into a single style, for simplicity. + Miscellaneous style and string changes to put things in a better state. This included tweaking some of the (ripple) backgrounds. + Update tests, according to changes. Bug: 19372817 Change-Id: Ic923c0bcbbc1c153952131d0c772df9e9589fb03
2015-04-09Replace ListView with RecyclerView in call log.Andrew Lee
Yay, finally! + Replace ListView with RecyclerView in layout and fragment files. + Change GroupingListAdapter to extend RecyclerView.Adapter instead of BaseAdapter. + Change CallLogListItemViews to extend RecyclerView.ViewHolder. + Adapt onBindViewHolder and onCreateViewHolder methods in the CallLogAdapter. + Update/rework tests for related classes. + Fix a bug in the GroupingListAdapter, where childCount was not updated for standalone views, and the previously cached group size was used instead. Set childCount to 1 for standalone views. - Removed the idea of creating different views for standalone vs group vs group headers from the adapters. This logic has not been used for quite some time and all these functions funneled into createView/bindView methods anyways, so there is no logical difference. If we need to create custom views in the future, we can leverage onCreateViewHolder's viewType parameter. Bug: 19372817 Change-Id: I1b7289340600609669db22d8bc89265240d0b561
2015-04-09Move some CallLog testing from adapter to fragment.Andrew Lee
- Remove custom testing method formerly in the adapter. - Remove unused expand animate code. Bug: 19372817 Change-Id: I78489d63ac9c3324cd80f8039d14a41813772e11
2015-04-08Merge "Remove expand/collapse animations in the Call Log."Andrew Lee
2015-04-07Move copy of GroupingListAdapter to Dialer app.Andrew Lee
+ Copied in from com.android.common.widget. This component is pretty specific to phone number / call log grouping anyways. + Changed CallLogAdapter to reference this GroupingListAdapter instead of the one in the framework library. + Changed CallLogGroupBuilder to reference this adapter too. + Copy in tests too. Next step: change GroupingListAdapter to extend RecyclerView.Adapter. This will preserve existing grouping logic, despite switching to the new view. Bug: 19372817 Change-Id: Ic0186ca5fad06a3ae398b9d8f8006210077149dc
2015-04-06Remove expand/collapse animations in the Call Log.Andrew Lee
- Remove animation logic in CallLogFragment. - Remove expand listener from CallLogAdapter. + Update tests and constructor. This preemptively removes expand/collapse behavior. While this will result in a janky short-term experience, this is an incremental step in shifting to RecyclerView and the new "Card" UI. I figured it would be most efficient to delete it straight up, rather than coding in intermediate logic to work with the RecyclerView because it will be made obsolete by the Cards UI anyways. In the long run, expand/collapse animation behavior will be restored once the call log is migrated to RecyclerView and converted to Cards. Bug: 19372817 Change-Id: Icbdc7dcb9f2f2223456c29334c826d38917b087a
2015-04-03Create ContactInfoCache from CallLogAdapter.Andrew Lee
This pulls code from the CallLogAdapter, with only tweaks to variable names and comments, to create a ContactInfoCache responsible for logic pertaining to looking up and caching contact info. The logic is intended to be unchanged for now, although in the future it can/should probably be cleaned up sometime. Bug: 20038300 Change-Id: I60a57b0a665496522a6b51c9e6e41a4fd6dbad1f
2015-03-20Add CACHED_PHOTO_URI to test valuesYorke Lee
Change-Id: I4cbc6d79985680b4b5fc6e807fb30908352900b5
2015-03-16Delete call log list item extras.Andrew Lee
- Remove isCallLog specific code from adapter; now everything will always be in the call log. - Remove unneeded adapter bits from ListsFragment; there is now no shortcut card shown in the lists fragment. - Remove call log list item extra. We won't bind badges using this any more. This will be superseded by the actions. Remove badge-related code in CallLogAdapter. + Leaving the add-person icon, since it will be used in the future. Bug: 19372817 Bug: 19627987 Change-Id: I4db8149761b017e02e89c081930a05f3aafe9606
2015-03-02Only consider toString value of TtsSpan for unit testsYorke Lee
Change-Id: I84da99d70801a6d1621de0883b801fa43ea5e5fd
2015-02-27Fix some Dialer testsYorke Lee
Change-Id: I46188070997ebc9b69f7d9b5a8ba9cb3c221b743
2014-11-14Remove call to deleted method AsyncTask.init().Jeff Brown
Bug: 18192406 Change-Id: I94df77ad8aaac8da5583ab80572c0bbd120b980e
2014-10-29Merge "Refactor ActionBarController and tests" into lmp-mr1-devYorke Lee
2014-10-28Refactor ActionBarController and testsYorke Lee
The original CL to fix ActionBarControllerTest by using an ActivityInstrumentationTestCase was too heavyweight and caused flaky test. It was also indicative of a flaw in the original design that ActionBar couldn't be mocked out easily. Refactor the code so that: 1) getActionBar() is no longer needed 2) Respect the invariant that all access to the actionBar goes through the ActionBarController (see the changes in ListsFragment) so that any change to the ActionBar's hide offset can be tracked appropriately. Bug: 17487016 Change-Id: I935b683ddb301ca5d3952889af1381bdbdcc97d3
2014-10-28More test-related changesYorke Lee
Fix failure in CallLogListItemHelper#testGetCallDescription_Video Add some documentation to CallDetailActivityTest Bug: 17487016 Change-Id: I31594feccb936500b20e13f3db5c68cbe5435c6e
2014-10-27Merge "Fix some broken Dialer tests" into lmp-mr1-devYorke Lee
2014-10-27Merge "Fix NPEs in ActionBarControllerTest" into lmp-mr1-devYorke Lee
2014-10-25Fix NPEs in ActionBarControllerTestYorke Lee
Create a MockActionBar that to prevent NPEs. For this an ActivityInstrumentationTestCase is needed. Bug: 17487016 Change-Id: Ieca95bec22c075ad64a1167e57f6b85f913bcf7e
2014-10-25Fix some broken Dialer testsYorke Lee
Bug: 17487016 Change-Id: I4c13c3e826a4eb1de84708dfa27ad093b2134087
2014-10-24Remove CallLogListItemViewYorke Lee
CallLogListItemView is a custom view that might have done something once, but doesn't anymore. It makes the code more complicated to read and requires a lot of casting that does nothing at all. Change-Id: I53efb35367d748aa3d164d0fb56686175967c90e
2014-10-15Enable use of phone accounts for voicemail info display.Nancy Chen
Call the "isVoicemailNumber(subId, number)" method instead of the one with just the number. This is because we need to check whether a number is the voicemail number for a specific phone account, otherwise the UI would never correctly display "voicemail" for the non-default SIM. Bug:17925501 Change-Id: If1d6cb1acfcb570aca5e639858af8804bac202c0
2014-09-16Remove ability to enable/disable phoneaccounts (4/6)Nancy Chen
Enabling/disabling of phone accounts was only used for SIP accounts and is no longer necessary for the purpose it was put in. Bug: 17510811 Change-Id: I41a2d11cfa85343fdf3f8681f1152d94abd79d2f
2014-09-12Renaming Telecomm to Telecom.Tyler Gunn
- Changing package from android.telecomm to android.telecom - Changing package from com.android.telecomm to com.android.server.telecomm. - Renaming TelecommManager to TelecomManager. Bug: 17364651 Change-Id: I44d6d6546cac53232e4e2be0ebe0391d02411309
2014-09-08Replace Calls.FEATURES_NONE with 0 (2/4)Yorke Lee
Bug: 17253963 Change-Id: I9e9e56cdf4c9a60ac1e047bef0eba2ba0c8f10fb
2014-08-20Pass application context into isVideoEnabled usages.Andrew Lee
Bug: 16211386 Change-Id: I0bda040bd6cd5c55ee7c708044befaad8977d460
2014-08-07Fix video description CallLogListItemHelper unit test.Tyler Gunn
Method signatures have changed for PhoneCallDetails and at some point the wrong method call was made. Bug: 16540503 Change-Id: Ie17facaa26aa6ebbb12a43b04d5ea4994b865a1f
2014-08-06Fix some action bar logicYorke Lee
* Restore action bar slid state only after onCreateOptionsMenu, when it has an effect * ActionBarController is now the only way to make changes to the offset of the action bar so that it can appropriately restore its state Bug: 16710397 Change-Id: Id9e0ebe210c89df0be56b32aa3bbd959cce88621
2014-07-25Add account label to call details if appropriateNancy Chen
We will be adding the account label field to call details if there is more than one account to disambiguate. Otherwise this field will be hidden. Bug: 16488229 Change-Id: Idb03d09d63372655504a5f9178e6f2e408aefb88
2014-07-24Add voicemail transcriptions to DialerYorke Lee
* Display voicemail transcriptions in the call log and call details activity in the Dialer * Fix a bug in CallDetailActivity that would result in multiple instances of VoicemailPlaybackFragment being added on rotation. Now, reuse the same fragment if it is already present in the FragmentManager, to avoid creating new ones * Simplify some test and ctor logic in PhoneCallDetails to reduce the pain of adding new fields into PhoneCallDetails * Simplified playback_layout.xml to remove unnecessary parent LinearLayouts Bug: 16320164 Change-Id: Ie68acc9058aace49d8e64f44a0128de0b6a3f842
2014-07-19Merge "Remove hardcoded class name from test" into lmp-devJay Shrauner
2014-07-18Remove hardcoded class name from testJay Shrauner
Bug:16347739 Change-Id: I810af831b782f0a7a6f3aa9df154c93c03c4080e
2014-07-20Rename PhoneAccountMetadata to PhoneAccountEvan Charlton
Change-Id: I4597b14110c1cee7f637ec125b839852ef0f34c4
2014-07-20Rename PhoneAccount to PhoneAccountHandleEvan Charlton
Change-Id: I2e97b348e6316a8b3ccc39fd81013e7f514a2889
2014-07-16Added a dialog to confirm caller id reporting (1/2).Sai Cheemalapati
Database and call log are now updated when user confirms. Bug: 11150383 Change-Id: Ic716e92bcb2280c1d352bd2232bda516e83349b2
2014-07-15Merge "Revert "Added a dialog to confirm caller id reporting."" into lmp-devSai Cheemalapati
2014-07-16Revert "Added a dialog to confirm caller id reporting."Sai Cheemalapati
This reverts commit cee1e65f0c411e35c4521922c3e9def13e01fe64. Change-Id: Ic50fd443856ea7e22714423939ac782cd4e89276
2014-07-16Merge "Added a dialog to confirm caller id reporting." into lmp-devSai Cheemalapati
2014-07-15Added a dialog to confirm caller id reporting.Sai Cheemalapati
Database and call log are now updated when user confirms. Bug: 11150383 Change-Id: Iafaca2172f2d44a6edf8514f7d900888dab9cf0e
2014-07-15Various call log / call details video call changes.Tyler Gunn
Requires cl/501841. Call log: 1. Add video call affordance. 2. Add accessibility text for calls, video call afforance. 3. Fixed unit test Call details: 1. Showing video icon when a call had video. 2. Changing call headings to indicate they were video calls. Bug: 16013879 Bug: 16013344 Bug: 16013684 Change-Id: I53b5bf9b0b1a63f9d119318d59f690d310cca7c8
2014-07-14Implement multi-SIM capabilities (3/6) [DO NOT MERGE]Ihab Awad
Bug:16292368 Change-Id: I367f838a08bd478aca86e2d75b221250ebd8a82e (cherry picked from commit 0e8a870afc9de3063a652256e81f9bf2043914e0)
2014-07-10Adding support for video call icon and data usage in call log.Tyler Gunn
Bug: 16013684 Bug: 16015261 Change-Id: Ie75443d641c1e09a5772bb618aba55de8583716b
2014-07-02Rename Telecomm "Subscription" to "Account" (3/7)Ihab Awad
Change-Id: I866e9d4f629a2b23acb3d3d3f2baeb0a674522f7
2014-06-30Adds back commented out test in DialerPaul Soulos
Change-Id: I032ca1c60cc7c5dbf9a6a832434fef5174ce90e8
2014-06-30Comments out faulty testPaul Soulos
Change-Id: I72755b548ae95e106fda012cd971d9c966a25cff
2014-06-26Add icon indicating subscription in call log/call historyNancy Chen
Display an icon in the call details showing which connection provider (subscription) is responsible for the call. Bug: 15473965 Change-Id: I0c6755864083799b8bafe20c3692b0d943beeee3
2014-06-13Add auto-offset for manual call log entry test screen.Tyler Gunn
Added ability to auto-offset the next call date/time to be manually added to the call log. This helps when you want to add a number of repeated calls but offset them by a short time (eg 1 minute). Change-Id: I66a59df47e17b99a008ca289c641301eda460b5e
2014-06-10Merge "Applying call details red-lines."Tyler Gunn
2014-06-10Adding ability to manually enter a call log entry to dialer test app.Tyler Gunn
Modified the FillCallLogTestActivity to include the ability to add calls to the call log manually (ie by specifying call date/time, type, etc). This is useful for call log debugging and testing. Change-Id: I4984b78fd38ceef4f18c89635fe61e4cd2c3ce3f
2014-06-09Applying call details red-lines.Tyler Gunn
- Contact photo is now quick-contact which invokes quick-contact view. - Removed send MS and call affordances, along with scrolling effect. - Added missing accessibility strings to voicemail controls. Bug: 15328410 Change-Id: I6d78d582af8c3a5cea8e051911cf3be763df2a36
2014-05-29Fix broken Dialer testsYorke Lee
Remove unneeded use of resources Instantiate CallLogListItemViews correctly Add dummy number to SmartDialPrefixTests Change-Id: I417f54329f43d53e24c4ab6cc65d08d05b5dd6a1
2014-05-29Fix build breakage: Revert "Fix broken Dialer tests"Ed Heyl
This reverts commit fabd82363920a24be32d68adb5966412c626dea0. Change-Id: If65df0d4badc3381f60923a04412f4bec5c36c62
2014-05-28Fix broken Dialer testsYorke Lee
Remove unneeded use of resources Instantiate CallLogListItemViews correctly Add dummy number to SmartDialPrefixTests Change-Id: I3d61c3a6892f3fe84a353cc7617c011aa5124e9a
2014-05-27Fix build breakYorke Lee
Change-Id: I84dd2667227f40962b8d034c35c5e56f854221e3
2014-05-23Add ActionBarControllerYorke Lee
* Collect all actionBar interactions within DialtactsActivity into a single controller to ensure that it behaves more deterministically, and fix some bugs with regards to actionBar interactions. * Make sure that action bar correctly handles activity recreation and destruction by saving its state * Add unit tests and mock classes for ActionBarController Bug: 14900155 Change-Id: I370831db425e1970b118f5d4fed3ce9297e3610d
2014-05-15Fixing build error caused by missing implementation in test class.Tyler Gunn
Bug: 13962594 Change-Id: I92b3da51069f4299ef056fdfa6abdcf63c5549c1
2014-05-13Animate call log expand/collapseYorke Lee
2014-05-12Removing highlighting of missed calls and voicemails in the call log.Tyler Gunn
Also fixing some broken unit tests. Bug: 13962594 Change-Id: I3ca2d72b3013b6324da19717dbc984f3e7e576e2
2014-05-05Adding support for expandable call log entries.Tyler Gunn
Bug: 13962594 Change-Id: I19a4a65dce922619df0a709293ca291c345c8be7
2014-04-21Use PhoneFavoritesTileAdapter directly in GridViewYorke Lee
This CL moves the adapter that contains the speed dial contacts into its own GridView that lives in PhoneFavoritesFragment. This is the first step to splitting up PhoneFavoritesMergedAdapter into a list of shortcuts and a grid of contacts, and also get rid of the convoluted ContactTileRow logic within PhoneFavoritesTileAdapter, to facilitate a future transition to RecyclerView. * PhoneFavoritesTileAdapter now directly returns PhoneFavoriteTileViews rather than ContactTileRows. * Deleted a lot of unnecessary complicated logic within PhoneFavoritesTileAdapter that had to do with ContactTileRows. * Simplified and rewrote animation logic so that animations now perform as expected within the GridView. In the future this may not be necessary if RecyclerView is used. * Rewrote layout/measurement logic for PhoneFavoriteTileView. It now determines its height directly based on what its measured width is. * Replaced PhoneFavoritesListView in PhoneFavoriteFragment with a standard GridView * Delete stale PhoneFavoriteTileAdapter tests Notes: Call shortcut cards are now temporarily missing due to this change Bug: 13963734 Bug: 13933092 Bug: 13419223 Change-Id: I71e8970667589e4024d00e9af2c8b45c843c5db1
2014-02-28Use new ContactPhotoManager APIs for letter tile avatarsYorke Lee
*Modify the following uses of ContactPhotoManager.loadPhoto in the following classes to include a DefaultImageRequest, populated with the contact's display name, lookupkey, and contact type as necessary CallDetailActivity CallLogAdapter PhoneFavoriteTileView *Add utility methods to ContactInfoHelper, to parse a lookupUri for a lookup key, as well as determine whether or not a contact is a business contact, from its sourceType field. *Add a sourceType field to PhoneCallDetails which can be used to track whether or not PhoneCallDetails belongs to a business contact *Add a lookupKey field to ContactInfo Bug: 13101785 Change-Id: If339a9c038f92a0212f8f8b45b5e3cc5f6442562
2014-02-18Switch favorites screen to grid layoutYorke Lee
* Add logic to PhoneFavoritesTileAdapter so that it now supports an unlimited number of tiled rows. * Tiles now have a configurable height to width ratio. * Fix animations so that tiles moving up and down rows appear to animate in from the correct direction. Tiles moving to the row above should animate in from right to left. Tiles moving to the row below should animate in from left to right. * Update the number of columns in the grid to 2. * Update layout of individual tiles to match redlines from UX. * Tweak font sizes for tiles * No longer truncate names in tiles * Tiles have a 2-3 height to width ratio * Update assets and layout for favorite and more info icons * Add content description for the favorite button * Add tests for PhoneFavoritesTileAdapter Change-Id: I50b298f0941698985d281f13e6a87c5a9b613efa
2014-02-03Call History Affordances SwapTyler Gunn
1. Swapped the intents for the primary view 2. Changed the icon for the secondary action button 3. Added a vertical divider line to separate the secondary action button from the primary view 4. Cleaned up the accessibility text Change-Id: Ifd4ceff0d67b1587c4378e29be7344de50057a7d
2013-11-25Merge "Remove use of hidden TelephonyManager methods"Yorke Lee