summaryrefslogtreecommitdiff
path: root/tests/src/com/android/dialer/calllog
AgeCommit message (Collapse)Author
2017-03-01Update dialer sources.Eric Erfanian
Test: Built package and system image. This change clobbers the old source, and is an export from an internal Google repository. The internal repository was forked form Android in March, and this change includes modifications since then, to near the v8 release. Since the fork, we've moved code from monolithic to independent modules. In addition, we've switched to Blaze/Bazel as the build sysetm. This export, however, still uses make. New dependencies have been added: - Dagger - Auto-Value - Glide - Libshortcutbadger Going forward, development will still be in Google3, and the Gerrit release will become an automated export, with the next drop happening in ~ two weeks. Android.mk includes local modifications from ToT. Abridged changelog: Bug fixes ● Not able to mute, add a call when using Phone app in multiwindow mode ● Double tap on keypad triggering multiple key and tones ● Reported spam numbers not showing as spam in the call log ● Crash when user tries to block number while Phone app is not set as default ● Crash when user picks a number from search auto-complete list Visual Voicemail (VVM) improvements ● Share Voicemail audio via standard exporting mechanisms that support file attachment (email, MMS, etc.) ● Make phone number, email and web sites in VVM transcript clickable ● Set PIN before declining VVM Terms of Service {Carrier} ● Set client type for outbound visual voicemail SMS {Carrier} New incoming call and incall UI on older devices (Android M) ● Updated Phone app icon ● New incall UI (large buttons, button labels) ● New and animated Answer/Reject gestures Accessibility ● Add custom answer/decline call buttons on answer screen for touch exploration accessibility services ● Increase size of touch target ● Add verbal feedback when a Voicemail fails to load ● Fix pressing of Phone buttons while in a phone call using Switch Access ● Fix selecting and opening contacts in talkback mode ● Split focus for ‘Learn More’ link in caller id & spam to help distinguish similar text Other ● Backup & Restore for App Preferences ● Prompt user to enable Wi-Fi calling if the call ends due to out of service and Wi-Fi is connected ● Rename “Dialpad” to “Keypad” ● Show "Private number" for restricted calls ● Delete unused items (vcard, add contact, call history) from Phone menu Change-Id: I2a7e53532a24c21bf308bf0a6d178d7ddbca4958
2016-04-15Refactor block/report dialogs and put into utility class.Sarmad Hashmi
+Put all the dialog creation code in one place so they can be re-used +This is mainly for the after call notification because the same dialogs will be shown in an invisible activity +Create listener for determining whether a user checked the spam checkbox +Change to DialogFragments for easy reusing of dialogs Change-Id: I67e13bc0e61952299a4770c9184543ef8b63728a
2016-04-07Merge "Add via number to CallLog Account entry" into nyc-dev am: 87b9abfBrad Ebinger
am: 8607dfb * commit '8607dfb43c2707ca534d68f2dcf728fece01c82b': Add via number to CallLog Account entry Change-Id: I55e9f40fb5497a4edeec31fc0abeb2efd459f1a2
2016-04-06Add via number to CallLog Account entryBrad Ebinger
Call Log now provides the phone number that an incoming call was received on if that number is different than the SIM subscription number. This "via number" is appended to the Phone Account of the Call Log entry in Dialer if it exists. Screenshots: - One PhoneAccount: http://screen/HuCSL0U6jU6.png - Multiple PhoneAccounts: http://screen/pDg8F9zpMei.png Bug: 25594198 Change-Id: I8c05ea98409e54d20493fbdb20096bf851480719
2016-04-06Add dialogs for spam report and block.Qi Wang
Screenshots: 1. block/report spam https://screenshot.googleplex.com/5e772Kikikw 2. block https://screenshot.googleplex.com/AEpYSYoL2E8 3. unblock(is spam and report not a spam) https://screenshot.googleplex.com/AEZfhCXj4h8 4. unblock(not spam) https://screenshot.googleplex.com/r7YkHuCMT1p 5. report not spam https://screenshot.googleplex.com/jkcpm0pdKoj Change-Id: I78fbbacece44632614026c03909289995bef5b14 Fix: 27295785
2016-03-30Fix Dialer crash loop for caller id in personal contact directoryVictor Chang
The bug is dialer queries CP2 for alternative name by lookup key of personal directory CP2 throws IllegalArgumentException as the lookup key is not found locally 2 fixes are included to avoid this happening 1. slient IllegalArgumentException since alternative name is not very important to crash dialer. (It's a fix by reverting some changes in ag/880910) 2. Check directory id before querying CP2 either one should fix this bug. Include both to make sure that it's not crashed. Unit test added. Bug:27905000 Change-Id: Ib8eab5f718a168fcec2785c3101e96bb91521d40
2016-03-18Fix dialer crash on unknown number call.Sarmad Hashmi
+Number is set to empty string if null +Added 11 tests for getContactInfo method, mainly testing various combinations of inputs BUG=27725458 BUG=27724999 Change-Id: Ic64fbdb7490a3c07145310cf02249555bfc963a3
2016-03-17Return null constructing a malformed PhoneAccountHandleBrad Ebinger
Return null when constructing a PhoneAccountHandle if the ComponentName from the database is malformed. Bug: 26684527 Change-Id: I76a3e61699e0646cdf0b715d7b3908611cdca8ff
2016-03-11Removing hardcoded database column nameBrandon Maxwell
+ We were previously hardcoding the post_dial_digits column name. This code was written before we had src-N and src-pre-N folders. + This CL converts the hard coded column name to follow the pattern we have for new stuff in the SDK. + Additionally, this CL removes an unneeded method which checks the SDK version, instead using the CompatUtils class. Bug: 25021389 Change-Id: I017d47f7efd323254e616a64d7ac824c5cfb8902
2016-03-11Query lookup uri with work lookup key directly is not allowedTony Mak
Query lookup uri with work lookup key directly is not allowed, app crashes if doing so. And actually, all APIs do not support work lookup key except those explicitly say it does. This Cls changed two places: 1. Do not pass lookup uri with work lookup to NotificationManager to avoid NotificationManager using the uri to query. 2. Dialer perform query for alternative display name using lookup key. But if it is a work contact, do not do so. Bug: 27146678 Change-Id: Ie59c37ff43b6f953a96564c446d79d8812f5ada1
2016-03-04Update call log adapter and related files for archived voicemails.Sarmad Hashmi
+ Populate CallLogAdapter items with different data depending on whether it is in the voicemail archive activity or not + Added addVoicemailGroups method to CallLogGroupBuilder so that every voicemail is put into an individual group + Voicemails grouped differently than regular calls, so added changeCursorVoicemail in GroupingListAdapter +Fix CallLogAdapter tests and add test for archive adapter BUG=22797391 Change-Id: Ib8387c5b3ab8c5e39876cfaf20fde5a44295f152
2016-02-24Fix bug where 00:00 duration is shown for voicemails without a duration.Sarmad Hashmi
Instead of showing a 00:00 duration, nothing is displayed. When the content is loaded, the duration field for the call log entry associated with the voicemail is updated with the duration fetched from the mediaplayer. The proper duration is then displayed in MM:SS format. BUG=24175525 Change-Id: I1cafebae4fcbc749f573accfcf8833b598675f0b (cherry picked from commit 6f3016d9065564bf09a5759f16563a05abbe105d)
2016-02-24Collapsed and expanded voicemail cards show duration.Sarmad Hashmi
The duration of the voicemail is appended to the date in a MM:SS format. BUG=25728257 Change-Id: I9c3e392336877c2ca69707e14c6ab2eed6f2e7c6 (cherry picked from commit 3f70c27d80b2e3176159f561248f95612d66afe2)
2016-02-22Show Briefcase icon not displayed in in-call UI for work SIP callsTony Mak
Current dialer always queries PhoneLookup._ID and uses this as a contact ID. In pre-N, contact id of non-sip query is stored in PhoneLookup._ID and it is actually a mistake. This problem does not exist in sip query, and contact id of sip query is stored in Data.CONTACT_ID. So it is a "bug" in dialer that we use PhoneLooup._ID for sip query as it is not really a contacat id. The bug of missing work badge may not be the only issue introduced by this. In N, the issue is get fixed in framework, PhoneLookup.CONTACT_ID is introduced. We should access PhoneLookup.CONTACT_ID no matter what phone lookup query we are having. The ideal case is we always use PhoneLookup.CONTACT_ID for retrieving contact id, but given that we need to support in pre-N, we need to query PhoneLookup._ID for contact id in non-sip query in pre-N. BUG:27242975 Change-Id: Id14378e3dce5b07629ffe0c6e83c3d107fbb468e
2016-02-12Use DATA.CONTACT_ID when lookup SIP callTony Mak
It is actually a naming mistake in framework, the column store contact id of normal query is _id, but that of sip query is contact_id. It is an old issue and we can't do much in the framework side. So, we need to use the correct projection when it is a SIP call. Bug:27143980 Bug:27141566 (cherry picked from commit 328f75ff518bf7d8863c6cf4446e26636e05b297) Change-Id: I0551c308072892ef13c8cb14ea4a4ab37ffa6f83
2015-12-28Make TelecomManager APIs compatible with Lollipop. (1/3)Nancy Chen
+ Add methods to TelecomManagerCompat - Move TelecomManagerCompat to ContactsCommon because it is called within ContactsCommon - Move TestTelecomCallLogCache to the right package so tests pass Bug: 25776171 Change-Id: I1963959292d8038ab505488d831afd06e6fef6d0
2015-12-03Adapt TelecomCallLogCache to pre-MSIM.Nancy Chen
TelecomCallLogCache creates a mapping between PhoneAccount and per-SIM information like voicemail number which is not relevant pre-LMr1. Create a compatibility classes so that MSIM functionality is factored out pre-LMr1. Bug: 25776171 Change-Id: I67b012110829121dffa42d542aa0395d683fa78b
2015-12-01Add checks for post-dial functionality to avoid breaking testsHall Liu
Bug: 25929524 Change-Id: I21b00d18e06960add576f8f3a2d01583abadaa17
2015-11-12Fix build breakage due to bad manual cherry-pickHall Liu
Change-Id: I1a020321ba71760485aa4df2313d3877c4795f5a
2015-11-11Added support for displaying/redialing post-dialHall Liu
Append dialed post-dial digits(if any exist) to the displayed number and changes the intent sent by the redial button to include the post-dial digits. Bug: 24955678 Change-Id: I0ec2cb2d5504f7fd715132eba7d969ff284e23d1
2015-11-03Changing method to public, static for use in InCallUiBrandon Maxwell
+ Changed ContactInfoHelper.lookUpDisplayNameAlternative to public so it's usable in InCallUi + Changed ContactInfoHelper.lookUpDisplayNamealternative to static to cut down on object creation + Added tests for lookUpDisplayNameAlternative since it is public Change-Id: Iede746655a1ca773cb0cd8cf26df665e34ab47fc
2015-10-27Merge "CallDetailActivity respect display name order" into ↵Brandon Maxwell
ub-contactsdialer-a-dev
2015-10-27Merge "Fix voicemail tab items reading "speed dial" when selected." into ↵Nancy Chen
ub-contactsdialer-a-dev
2015-10-26Fix voicemail tab items reading "speed dial" when selected.Nancy Chen
The voicemail entries were reading "speed dial" because the focus would go to the newly added "speed dial" tab since the tabs are all removed and readded when the tab info changes. Change the logic so that only the voicemail tab is changed when needed. The voicemail entry reads "seek playback" instead of the information about the voicemail because of custom expand logic for accessibilty. Change it so that only the call log items are expanded when selected (it is more important to be able to discover the overflow options). Also change content description text because it was too long and confusing. Bug: 25124120 Change-Id: I64c1b27d8c0db57525f7f4ada59655e9f8352245
2015-10-26CallDetailActivity respect display name orderBrandon Maxwell
- Updated the CallDetailActivity to choose whether to show last name first or first name first based on user preferences. - Modified callLog code to behave in a similar fashion - Fixed bug in ContactInfoHelperTests - Rename PhoneCallDetails.name -> PhoneCallDetails.namePrimary Bug: 19364093 Change-Id: I50971ad0f26f6ede49f1c82965d1b00ce0cba4d3
2015-10-26Call log respects display name order preferencesBrandon Maxwell
- Updated ContactInfoHelper to retrieve DISPLAY_NAME_ALTERNATIVE (name in last name first order) - Stored alternative name in ContactInfo object - Updated CallLogAdapter to choose between first name first and last name first when showing contact name - Added tests for ContactInfoHelper.lookupContactFromUri (changed to public method) - Fixed bug with ContactsPreferences so ChangeListener works Bug:19364093 Change-Id: I73e8d8602a54e3134ef01b3d5167d828b26fa5ea
2015-10-23Revert "Call log respects display name order preferences"Brandon Maxwell
This reverts commit 327fb5bb609a6bee44a62888d671c951b19782fd. Change-Id: I134f0a26697bec20b746a6e8f041a715d8e95136
2015-10-23Call log respects display name order preferencesBrandon Maxwell
- Updated ContactInfoHelper to retrieve DISPLAY_NAME_ALTERNATIVE (name in last name first order) - Stored alternative name in ContactInfo object - Updated CallLogAdapter to choose between first name first and last name first when showing contact name - Added tests for ContactInfoHelper.lookupContactFromUri (changed to public method) - Fixed bug with ContactsPreferences so ChangeListener works Bug:19364093 Change-Id: I188d8fc2eccb87edbe56625c9a7537b3d5f0e19e
2015-10-20Update Dialer testsYorke Lee
* Update all tests with @SmallTest, @MediumTest or @LargeTest annotation to ensure coverage by continuous test infrastructure * Fix one failing test Change-Id: Ib878a3fe292916e21a465580a74319e807e7efe0
2015-10-14Moving call type/location for voicemailBrandon Maxwell
Combination of two related bugs. 22168682: In the voicemail call log, moved call type/location to below the call action button and removed the call details button as it didn't have any additional information. 22514722: Modified spacing and text sizes for call log. Moved voicemail transcription below call date as in mocks. Bug:22168682,22514722 Change-Id: I557761b815604fee4e6b61f4670608b8fa90d3a7
2015-10-03Group blocked calls separately in call log.Andrew Lee
+ Group blocked calls separately from other call types, but group adjacent blocked calls together. + Add unit tests. Bug: 23943480 Change-Id: Iffe6fac800007f6b88e0feb15d91c63515e496f8
2015-10-02Merge "Modifying voicemail call log date and time format" into ↵Brandon Maxwell
ub-contactsdialer-a-dev
2015-10-02Add BLOCKED call type and util to mark in call log.Andrew Lee
To support call blocking, added BLOCKED call type. Also added utility to be able to mark the most recent call from a number as BLOCKEd in the call log database. Added REJECTED call type as well. This is not presently used within our application, but we want to reserve the integer, anticipating changes in the framework to add this constant. Introduced AppCompConstants, because BLOCKED and REJECTED call type values will not be defined as part of the API on M devices. Change existing call type constants to reference this compatability class. Bug: 24341350 Change-Id: I523ebd8dd1844a3b71a69a14bd38073be5940804
2015-10-02Modifying voicemail call log date and time formatBrandon Maxwell
Bug: 22168682 Change-Id: Id0135ca03310f6c1587151af81c29b22e9d20d2b
2015-09-16Move CallLogFragment tests to CallLogAdapterTest.Andrew Lee
+ Reduces flakiness of test. + Rewrote random stress test to be more deterministic; simpler code but still tests in general for the same scenario (rebinding viewholders for different presentation types). Bug: 23640774 Change-Id: I57adf16f9becc5cb7354563986f55f9023e4aabd
2015-09-15Fix GroupBuilder Tests.Andrew Lee
There was a change in assumptions where groups are added for standalone elements, but missed updating the unit tests for the GroupBuilder to reflect those changes. Bug: 23640774 Change-Id: I89576bd003119ce1da675181adbf557e7b996057
2015-09-05Merge "Move non-cache tests from Fragment to Adapter." into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-09-03Move non-cache tests from Fragment to Adapter.Andrew Lee
This will hopefully make the CallLogFragmentTest more robust against testing race conditions. Bug: 23640774 Change-Id: I20a0fe7c7724a3c026b3f7520e475180b8f22270
2015-09-01Fix test method for showing promo card.Andrew Lee
Bug: 23422274 Change-Id: Ib67080b2eb71006eb52cbef58983788baa97c712
2015-09-01Rewrite grouping logic in Dialer.Andrew Lee
- Remove expand/collapse and item type logic in GroupingListAdapter. Losing some potential functionality, but it does not adversely affect how we currently group, and makes grouping easier to understanding. + Rewrite GroupingListAdapter to provide O(1) lookup for group size and getItem. This requires maintaining a SparseIntArray of metadata for each list item. Cut metadata storage from long to int, to help adjust for the larger memory overhead. + Simplify the logic for building and maintaing the metadata in the GroupingListAdapter, offloading much of it to the SparseIntArray. + Explictily add all groups, including groups with single items, in the CallLogBroupBuilder. + Tidied up logic in CallLogGroupBuilder to make it more intuitive what cases it's handling and what's happening. + Updated tests to work and pass with new tests. Bug: 23422274 Change-Id: Ia7a00c4b580813cade87fdc054ffdd702f59c12c
2015-06-26Cache repeated Telecom requests from call log.Andrew Lee
This improves call log scrolling performance. + Split "Wrapper" into a utility and a cache. + Use cache for repeated calls related to call logs. + In the process of fixing plumbing and typer, moved some phone call detail classes into the more appropriate call log package. + Update tests. Bug: 20524705 Change-Id: Ib8ee21e417c19f98f6474a5793416e8f99103b55
2015-06-15Add play voicemail primary action to call log.Andrew Lee
+ Add voicemail primary action button, which expands the call log and plays immediately when clicked. + Pass expand/collapse listener into the view holder. This is necessary because it needs to be triggered when the "play" primary action is clicked so that the CallLogAdapter correctly registers what has been added and binded. + Update primary action button state when showing or hiding actions, so the visibility of the voicemail play button is managed properly. + Ensure voicemail playback state is consistent between multiple call log items when the user initiates a collapse or expand. Add reset function to help manage this. + With the reset, protect against the possibility of functions in the presenter being called when no voicemail playback view is set. Bug: 21654755 Change-Id: I7bcf67d27fa08fe77d1334dc084b52effe8d3ccc
2015-06-15Merge "Fix abundance of "Custom" labels." into mnc-devAndrew Lee
2015-06-15Fix abundance of "Custom" labels.Andrew Lee
Not sure precisely why this changed, but hopefully this logic is more robust. Show the geocoded location if there is no name to use and a location is available. Removed GEOCODE_AS_LABEL, which wasn't really used anymore. Bug: 21814339 Change-Id: I1343282ef415647853d7995d900a3f50186ad156
2015-06-12Convert to primary action button on call log items.Andrew Lee
+ This is the call button on the standard call log list item, but will be play on voicemail call log list items. + Add call "list" action for voicemail call log list items. Change-Id: I4b115b96738b77c8a19c1071d5290e65f93395ac
2015-06-10Move "Report" to CallDetailActivity.Andrew Lee
- Delete old report button/handling code. + Convert menu click listeners into single onMenuItemClick method. + Add and populate objectId on PhoneCallDetails, to be able to tell from the CallDetailActivity whether to enable reporting. Change-Id: Ie4b9a3c1835792cbba04dc826f71fd2e53071400
2015-06-10Merge "Change PhoneCallDetail fields to be non-final." into mnc-devAndrew Lee
2015-06-10Change PhoneCallDetail fields to be non-final.Andrew Lee
It's been a pain to add/change fields on PhoneCallDetails because a multitude of parameters required for the constructors to create an instance. I ran into this while considering how to add an objectId to its parameters, and have previously too... Make fields non-final so that they are more easily set. This has the side-effect of making the casing of some initialization code more straightforward. + Change it's constructor to a subset of required fields. + Simplify/reorganize CallLogAdapter and CallLogAsyncTaskUtil code. + Simplify tests. Bug: 21733599 Change-Id: I236dfb0b8e6513f4b44dbdae17ce2eb9c9ae4778
2015-06-09Fix CallLogFragment UnitTests.Andrew Lee
Run "changeCursor" on the main thread. I'm not precisely sure why this fixes things, but it appeared before that the data I had on my local device was being used instead of the test data. Bug: 21471763 Change-Id: I6bece02e7c6828d54f76b5221ad10cf8f0052aa9
2015-06-03Move VM playback from details to call log.Andrew Lee
- Delete voicemail playback in the CallDetailActivity. + Add voicemail playback to the call log list items. + Move the VoicemailPlaybackPresenter to the CallLogFragment. + Fix some retaining state for both call log (expanded items), and preserve rotation/state functionality for voicemail playback. This included some changes to the Presenter logic. + Fix some tests. Bug: 21471763 Bug: 21170557 Change-Id: I30aae3a52c5bbf74a5075a9666343c337b1fc0df
2015-05-19Performance improvements to call log scrolling.Andrew Lee
- Remove call to CallUtil to check if video is enabled. It seems like it's fine to include the content description of what the call was, if it was a video call, even if there is not a video-enabled call account. - Factor out PhoneNumberDisplayHelper so it doesn't need to be an instance. This reduces some extra calls to getDisplayNameHelper. Probably a marginal difference, performance-wise, but it probably helps a smidgen and also simplifies the need for creating and passing or recalculating various instances of things. TODO: It'd be much better if PhoneCallDetails had a builder. It's terribly painful to fix all the tests when adding fields... Change-Id: I6da13dc8b6b047043aba871796a8ed13b112a227
2015-05-12Indicate whether CallLogAdapter is for Recents.Andrew Lee
Bug: 20924950 Change-Id: I6163565ec508d245afd83112927d636a4a50f27e
2015-04-16Move call log actions into expandable view.Andrew Lee
This isn't the prettiest thing ever, but with this the "framework" of all of the changes for the new visual style of the call logs is in place. From here on out, the remainder of tasks should be unblocked and relatively independent. + Rename ...ItemViews to ...ItemViewHolder. This probably wasn't completely necessary, but is more proper given the new architecture. + ViewHolder is now officially where most of the independent UI logic for a single call log list item should live. This changelist moves further in that direction by storing references and helpers in it, to lessen what must be passed in from the adapter. + Split out the call action from the rest of the actions, since it has a special treatment on the card. + Convert text action buttons into a vertical stack. + Consolidate action stylings into a single style, for simplicity. + Miscellaneous style and string changes to put things in a better state. This included tweaking some of the (ripple) backgrounds. + Update tests, according to changes. Bug: 19372817 Change-Id: Ic923c0bcbbc1c153952131d0c772df9e9589fb03
2015-04-09Replace ListView with RecyclerView in call log.Andrew Lee
Yay, finally! + Replace ListView with RecyclerView in layout and fragment files. + Change GroupingListAdapter to extend RecyclerView.Adapter instead of BaseAdapter. + Change CallLogListItemViews to extend RecyclerView.ViewHolder. + Adapt onBindViewHolder and onCreateViewHolder methods in the CallLogAdapter. + Update/rework tests for related classes. + Fix a bug in the GroupingListAdapter, where childCount was not updated for standalone views, and the previously cached group size was used instead. Set childCount to 1 for standalone views. - Removed the idea of creating different views for standalone vs group vs group headers from the adapters. This logic has not been used for quite some time and all these functions funneled into createView/bindView methods anyways, so there is no logical difference. If we need to create custom views in the future, we can leverage onCreateViewHolder's viewType parameter. Bug: 19372817 Change-Id: I1b7289340600609669db22d8bc89265240d0b561
2015-04-09Move some CallLog testing from adapter to fragment.Andrew Lee
- Remove custom testing method formerly in the adapter. - Remove unused expand animate code. Bug: 19372817 Change-Id: I78489d63ac9c3324cd80f8039d14a41813772e11
2015-04-08Merge "Remove expand/collapse animations in the Call Log."Andrew Lee
2015-04-07Move copy of GroupingListAdapter to Dialer app.Andrew Lee
+ Copied in from com.android.common.widget. This component is pretty specific to phone number / call log grouping anyways. + Changed CallLogAdapter to reference this GroupingListAdapter instead of the one in the framework library. + Changed CallLogGroupBuilder to reference this adapter too. + Copy in tests too. Next step: change GroupingListAdapter to extend RecyclerView.Adapter. This will preserve existing grouping logic, despite switching to the new view. Bug: 19372817 Change-Id: Ic0186ca5fad06a3ae398b9d8f8006210077149dc
2015-04-06Remove expand/collapse animations in the Call Log.Andrew Lee
- Remove animation logic in CallLogFragment. - Remove expand listener from CallLogAdapter. + Update tests and constructor. This preemptively removes expand/collapse behavior. While this will result in a janky short-term experience, this is an incremental step in shifting to RecyclerView and the new "Card" UI. I figured it would be most efficient to delete it straight up, rather than coding in intermediate logic to work with the RecyclerView because it will be made obsolete by the Cards UI anyways. In the long run, expand/collapse animation behavior will be restored once the call log is migrated to RecyclerView and converted to Cards. Bug: 19372817 Change-Id: Icbdc7dcb9f2f2223456c29334c826d38917b087a
2015-04-03Create ContactInfoCache from CallLogAdapter.Andrew Lee
This pulls code from the CallLogAdapter, with only tweaks to variable names and comments, to create a ContactInfoCache responsible for logic pertaining to looking up and caching contact info. The logic is intended to be unchanged for now, although in the future it can/should probably be cleaned up sometime. Bug: 20038300 Change-Id: I60a57b0a665496522a6b51c9e6e41a4fd6dbad1f
2015-03-20Add CACHED_PHOTO_URI to test valuesYorke Lee
Change-Id: I4cbc6d79985680b4b5fc6e807fb30908352900b5
2015-03-16Delete call log list item extras.Andrew Lee
- Remove isCallLog specific code from adapter; now everything will always be in the call log. - Remove unneeded adapter bits from ListsFragment; there is now no shortcut card shown in the lists fragment. - Remove call log list item extra. We won't bind badges using this any more. This will be superseded by the actions. Remove badge-related code in CallLogAdapter. + Leaving the add-person icon, since it will be used in the future. Bug: 19372817 Bug: 19627987 Change-Id: I4db8149761b017e02e89c081930a05f3aafe9606
2015-03-02Only consider toString value of TtsSpan for unit testsYorke Lee
Change-Id: I84da99d70801a6d1621de0883b801fa43ea5e5fd
2014-10-28More test-related changesYorke Lee
Fix failure in CallLogListItemHelper#testGetCallDescription_Video Add some documentation to CallDetailActivityTest Bug: 17487016 Change-Id: I31594feccb936500b20e13f3db5c68cbe5435c6e
2014-10-27Merge "Fix some broken Dialer tests" into lmp-mr1-devYorke Lee
2014-10-25Fix some broken Dialer testsYorke Lee
Bug: 17487016 Change-Id: I4c13c3e826a4eb1de84708dfa27ad093b2134087
2014-10-24Remove CallLogListItemViewYorke Lee
CallLogListItemView is a custom view that might have done something once, but doesn't anymore. It makes the code more complicated to read and requires a lot of casting that does nothing at all. Change-Id: I53efb35367d748aa3d164d0fb56686175967c90e
2014-10-15Enable use of phone accounts for voicemail info display.Nancy Chen
Call the "isVoicemailNumber(subId, number)" method instead of the one with just the number. This is because we need to check whether a number is the voicemail number for a specific phone account, otherwise the UI would never correctly display "voicemail" for the non-default SIM. Bug:17925501 Change-Id: If1d6cb1acfcb570aca5e639858af8804bac202c0
2014-09-08Replace Calls.FEATURES_NONE with 0 (2/4)Yorke Lee
Bug: 17253963 Change-Id: I9e9e56cdf4c9a60ac1e047bef0eba2ba0c8f10fb
2014-08-20Pass application context into isVideoEnabled usages.Andrew Lee
Bug: 16211386 Change-Id: I0bda040bd6cd5c55ee7c708044befaad8977d460
2014-08-07Fix video description CallLogListItemHelper unit test.Tyler Gunn
Method signatures have changed for PhoneCallDetails and at some point the wrong method call was made. Bug: 16540503 Change-Id: Ie17facaa26aa6ebbb12a43b04d5ea4994b865a1f
2014-07-24Add voicemail transcriptions to DialerYorke Lee
* Display voicemail transcriptions in the call log and call details activity in the Dialer * Fix a bug in CallDetailActivity that would result in multiple instances of VoicemailPlaybackFragment being added on rotation. Now, reuse the same fragment if it is already present in the FragmentManager, to avoid creating new ones * Simplify some test and ctor logic in PhoneCallDetails to reduce the pain of adding new fields into PhoneCallDetails * Simplified playback_layout.xml to remove unnecessary parent LinearLayouts Bug: 16320164 Change-Id: Ie68acc9058aace49d8e64f44a0128de0b6a3f842
2014-07-18Remove hardcoded class name from testJay Shrauner
Bug:16347739 Change-Id: I810af831b782f0a7a6f3aa9df154c93c03c4080e
2014-07-16Added a dialog to confirm caller id reporting (1/2).Sai Cheemalapati
Database and call log are now updated when user confirms. Bug: 11150383 Change-Id: Ic716e92bcb2280c1d352bd2232bda516e83349b2
2014-07-15Merge "Revert "Added a dialog to confirm caller id reporting."" into lmp-devSai Cheemalapati
2014-07-16Revert "Added a dialog to confirm caller id reporting."Sai Cheemalapati
This reverts commit cee1e65f0c411e35c4521922c3e9def13e01fe64. Change-Id: Ic50fd443856ea7e22714423939ac782cd4e89276
2014-07-16Merge "Added a dialog to confirm caller id reporting." into lmp-devSai Cheemalapati
2014-07-15Added a dialog to confirm caller id reporting.Sai Cheemalapati
Database and call log are now updated when user confirms. Bug: 11150383 Change-Id: Iafaca2172f2d44a6edf8514f7d900888dab9cf0e
2014-07-15Various call log / call details video call changes.Tyler Gunn
Requires cl/501841. Call log: 1. Add video call affordance. 2. Add accessibility text for calls, video call afforance. 3. Fixed unit test Call details: 1. Showing video icon when a call had video. 2. Changing call headings to indicate they were video calls. Bug: 16013879 Bug: 16013344 Bug: 16013684 Change-Id: I53b5bf9b0b1a63f9d119318d59f690d310cca7c8
2014-07-10Adding support for video call icon and data usage in call log.Tyler Gunn
Bug: 16013684 Bug: 16015261 Change-Id: Ie75443d641c1e09a5772bb618aba55de8583716b
2014-06-26Add icon indicating subscription in call log/call historyNancy Chen
Display an icon in the call details showing which connection provider (subscription) is responsible for the call. Bug: 15473965 Change-Id: I0c6755864083799b8bafe20c3692b0d943beeee3
2014-05-29Fix broken Dialer testsYorke Lee
Remove unneeded use of resources Instantiate CallLogListItemViews correctly Add dummy number to SmartDialPrefixTests Change-Id: I417f54329f43d53e24c4ab6cc65d08d05b5dd6a1
2014-05-29Fix build breakage: Revert "Fix broken Dialer tests"Ed Heyl
This reverts commit fabd82363920a24be32d68adb5966412c626dea0. Change-Id: If65df0d4badc3381f60923a04412f4bec5c36c62
2014-05-28Fix broken Dialer testsYorke Lee
Remove unneeded use of resources Instantiate CallLogListItemViews correctly Add dummy number to SmartDialPrefixTests Change-Id: I3d61c3a6892f3fe84a353cc7617c011aa5124e9a
2014-05-15Fixing build error caused by missing implementation in test class.Tyler Gunn
Bug: 13962594 Change-Id: I92b3da51069f4299ef056fdfa6abdcf63c5549c1
2014-05-13Animate call log expand/collapseYorke Lee
2014-05-12Removing highlighting of missed calls and voicemails in the call log.Tyler Gunn
Also fixing some broken unit tests. Bug: 13962594 Change-Id: I3ca2d72b3013b6324da19717dbc984f3e7e576e2
2014-05-05Adding support for expandable call log entries.Tyler Gunn
Bug: 13962594 Change-Id: I19a4a65dce922619df0a709293ca291c345c8be7
2014-02-03Call History Affordances SwapTyler Gunn
1. Swapped the intents for the primary view 2. Changed the icon for the secondary action button 3. Added a vertical divider line to separate the secondary action button from the primary view 4. Cleaned up the accessibility text Change-Id: Ifd4ceff0d67b1587c4378e29be7344de50057a7d
2013-11-25Merge "Remove use of hidden TelephonyManager methods"Yorke Lee
2013-11-22Remove use of hidden TelephonyManager methodsYorke Lee
Bug: 6948882 Change-Id: Ibce04c24e64fdb33fba532c0f0e5dca3b11f1b6c
2013-11-22Fix Dialer testsYorke Lee
* Empty geocode is now " " instead of "-" per UX request * DialpadFragment now throws IllegalArgumentException instead of Log.wtf so that it can be tested * Added contact id column to contactsprovider query * Modified PhoneNumberDisplayHelper to take an instance of PhoneNumberUtilsWrapper so that it can be mocked out Fix label-related tests that were failing due to a change in how we treat empty labels Bug: 9111164 Change-Id: If2244586b9d09fa2839fa0ddfc9f369f9dc66e51
2013-11-19Rename PhoneNumberHelper in DialerYorke Lee
Rename PhoneNumberHelper to more appropriate PhoneNumberDisplayHelper Change-Id: I2c03f5cbb04c1e03f1fc1e0051a1cea641160dca
2013-09-24Adding missed call badge.Chiao Cheng
Bug: 10861718 Change-Id: I3a889a71cff7abac578da83d09dd7af23f3f88ca
2013-09-20Fix build break.Chiao Cheng
Updating access modifier of test class. Bug: 10822944 Change-Id: If24c4afc280b2b2dcdf38119a857f0f3b9fd8778
2013-09-14Follow up on build break to fix unit tests.Chiao Cheng
Change-Id: I82b7fa50601f6dad60038fd1b9c5f0aad2f374f5
2013-09-13Fix build break.Chiao Cheng
Change-Id: I1d1aa2bc7228a788805937b80972cb800ed0ceff
2013-08-15Change primary actions of the CallLog items.Christine Chen
- When the CallLog item is in the CallLog fragment, the primary action remains to be opening the call detail page. - When the CallLog item is in the Favorite fragment, the primary action changes to be calling the number directly. The secondary action is hidden unless it is to play a voicemail. Bug: 10308694 Change-Id: I28ca7aa783bcca35eb8b41f6e8508d08062dd253
2013-08-05Code cleanup for call log related itemsYorke Lee
Change-Id: I2aa0458e1fb74abaea60a02f430a4e413dfed365
2013-07-03Remove CallLog New and Old sectioning.Christine Chen
Bug: <5751629> Change-Id: I1689fa10f285bc66fc69b6a9b9da139ce5461d83
2013-06-13Use new CallLog number presentation columnJay Shrauner
Switch to using new number presentation column in the CallLog table and discontinue using special phone number strings in CallerInfo. Needed for unbundling. Bug:6948882 Change-Id: Ibf27ea55cee783c4530101e4e228198e245e6684