Age | Commit message (Collapse) | Author |
|
|
|
It will continue to be shown in the call log, but will be removed
from details since the widget will be moved.
Bug: 21170557
Change-Id: I1ec3b090adc0736f7b134d0f67282ba7b4f9483b
|
|
|
|
|
|
Fix NPEs encountered during monkey tests
Bug: 21167534
Change-Id: I98b6f675adfd233d3583c363f7daeca1bc14d8b7
|
|
- I don't know of any affordances in call detail to make a call,
so the onKeyDown code seems to be superfluous.
- No references to ViewEntry or forceLeftToRight.
Bug: 20433758
Change-Id: Idbf6ffb81d3697b27cb51eda346b46eb5d083878
|
|
This isn't used in any particular case right now.
Remove some unused layouts too.
Bug: 21170557
Change-Id: Ie21264d7059e73c905b2807b993b95c91a0dd3ec
|
|
|
|
- Remove increase/decrease playback rate functionality.
- Flip button controls below the scrubber.
- Delete TextController.
Bug: 20433758
Change-Id: Id628bac0c9f8baed014079f2a89ce912fd2bb549
|
|
This was some functionality lost in the switch to RecyclerView
and cards.
+ Consolidate old methods into single OnClickListener.
- Deleted unused listener.
Bug: 20433758
Change-Id: Ic4797687548e94c0459e2a3a4134ef0aa5191d90
|
|
|
|
This code has been unused for quite some time, as far as I can
tell.
Bug: 20433758
Change-Id: Ic9fef01954720c24d8ba6971534897a88af42a8f
|
|
|
|
|
|
|
|
We used to send them straight into call details to play the
voicemail. But, now we're removing that playback widget into
the call log, so that doesn't work anymore. Instead, drop them
into the call log.
- Remove superfluous interface.
Bug: 20433758
Change-Id: Icac220c65bb8ccf5589b4ae38db7b8c3fbf384f4
|
|
Bug:21120753
Change-Id: I2e82e4a8e7b8226a2d74753d37ff36d1d3ab367e
|
|
In preparation for moving it from the CallDetailActivity into
the call log. Seems to make sense to consolidate this within the
fragment in any case.
Bug: 20433758
Change-Id: I1aa0cd9a766fac3e1eb9285d31df5ed90523b8ad
|
|
+ Rename CallIntentUtils.java to IntentUtil.java.
+ Consolidate various intent creation methods to new file, and update
referenes throughout the application.
Bug: 20433758
Change-Id: Iee9e37985217c38c816124d0e74dff40a2871680
|
|
|
|
|
|
Bug: 20924950
Change-Id: I6163565ec508d245afd83112927d636a4a50f27e
|
|
android.telecom.Connection.VideoProvider
* onSetPauseImage takes Uri instead of String
* changeCallDataUsage -> setCallDataUsage
* add quality constants to changeVideoQuality() docs
android.telecom.InCallService.VideoCall
* setPauseImage takes Uri instea dof String
android.telecom.VideoProfile.VideoState
* Move constants to VideoProfile, prefix with STATE_
Bug: 21040387
Bug: 21066505
Change-Id: I764e72aced9d1e2d30d6d0cf0862100860d47c79
|
|
|
|
If the call contains necessary CNAP information, try to save
it into the CachedNumberLookupService.
Move the various source type constants into AOSP dialer.
Bug: 10121624
Change-Id: Ic1911b8ef5556dca2a9855992f1857da5edbf6ed
|
|
Bug: 19641682
Change-Id: I148e0c8306e38bced6c5fd13182edb9625e80ff7
|
|
|
|
Ending up with an NPE because of a non-existent URI.
Bug: 21004150
Change-Id: If06a05461a392fcbb2ed750dea2f8a0deb5bbd80
|
|
Don't crash when performing certain operations that the
dialer might not have permissions to execute:
* Access voicemail provider
* Certain TelecomManager methods
Add a class TelecomUtil that checks for permissions/default
dialer status, and handles the privileged operations
appropriately.
Bug: 20266292
Change-Id: Ibe8a85440b9ca20169b5ce3be24d1a385caaebb6
|
|
|
|
Bug: 19870705
Change-Id: I7d13ab65da9d69819d39b3871297d274140b2a23
|
|
- Remove previous/next hints; not needed.
+ Add descriptions for new actions.
- Make TextViews not important for accessibility. Descriptions on the
actions will be used instead.
Bug: 20433758
Change-Id: I043b03075631134f37151e165360b038f3961b2a
|
|
|
|
|
|
Reorder sequence of events so that the search fragment is only
displayed after the dialpad animation is complete.
Bug: 20891354
Change-Id: I3aaba7c715f740d7a7ee8f5273eee3b85bfdc958
|
|
Music and other audio should be paused when listening to a voicemail.
The voicemail player grabs transient focus so that when the voicemail is
paused or finished, the focus returns to the music that was playing.
Bug: 19589110
Change-Id: I9876cc2700139d0db787d0e370020d2a38d82cda
|
|
+ Add two actions: create new contact and add to existing contact.
+ Pass in ContactInfo to the CallLogListItem's ViewHolder.
Bug: 20433758
Change-Id: Ic1387b33ebe027fa6ddbdb971996fc7d4c4ac88b
|
|
|
|
Currently when voicemails are marked as read, they are not also marked
as old ("new" set to 0). This means that when the phone is restarted,
the voicemails come back in the notifications bar even if they have been
read.
Also ensure the voicemail notification is dismissed when the
"play" button is pressed. Currently the voicemail is marked as old, but
the notifications are not immediately updated so there's no instant
feedback.
I split the markNewVoicemailsAsOld method from CallLogQueryHandler out
into a separate handler (VoicemailQueryHandler) because the
markNewVoicemailsAsOld method did not share any notable logic with
CallLogQueryHandler and would otherwise require creating two extra
constructors.
Bug: 20117483
Change-Id: I0f475e1a1489f1b45c8654f5ca882ccd857466e8
|
|
Views are null because of how tags are set with the new ViewHolder
logic. In the long run, I expect all this logic will be obsolete
once we listen to changes on individual ViewHolders. Presumably,
at that point, we don't need to deal with all this tag business.
Bug: 20521104
Change-Id: Iaf7aff6f576a0a5c097acbd461c7a1d88c932231
|
|
|
|
+ Add icons for actions.
+ Revise layouts to match new visual appearance. Call Log actions
are now a linear layout with an icon and text.
+ Some style/redline tweaks.
+ Temporarily replaced animation logic with LinearLayout, to be
revisited.
Bug: 20433758
Change-Id: Ia13b6c9f583d673743488f2e93be5593a1fbf8dc
|
|
Bug: 20700084
Change-Id: Id2574f5b721dbaa4d7aab04945c2ad08c390835f
|
|
It can be confusing to show the "smartdial" string converting chars
to digits, so only show the actions in a potential vanity-scenario.
Bug: 20699894
Change-Id: I4df5e94841c519cc591d1d5333d48efa739124e7
|
|
|
|
+ Change the icon/behavior depending on the tab position.
+ Move current tab position logic from DialtactsActivity into the
lists fragment.
- Delete unused method, shift some helpers around.
Bug: 19366434
Change-Id: I6da767300907b3afd006248afb882bebde7bdfe6
|
|
|
|
This reverts commit d10eef28fc67aea0e4f4f49813b802ce1df5f7c7.
Change-Id: I0867f991c071fc55d1eadf611386b713c910d17f
|
|
+ Add new VIEW_TYPE to the CallLogAdapter.
+ Reintroduce boolean on CallLogAdapter to specify if a call history
list item should be shown.
+ Add new ViewHolder and layout for footer.
+ Some minor styling tweaks and cleanups.
Bug: 20108202
Change-Id: Ie4a86bff9e53cfd69ef8b061af048f40f4358579
|
|
I'm not sure if anyone else is seeing this, but this change didn't
seem like it would be harmful to make. I was running into sadness
because mListsFragment was undefined.
Change-Id: I75712c2cb3626002372ac9b4812c44c2ed74c12f
|
|
When determining whether to notify for a particular voicemail, check the
voicemail IDs instead of the whole URI since sometimes the URI will
include query parameters and sometimes not so we don't want to do a
direct string comparison. Doing a direct comparison was causing a bug
where the sound and vibration of the new notification would be suppressed.
Bug: 19716109
Change-Id: I7a33b4d3bcd9ca707db9462fcebfec27fd5f8a74
|
|
Bug: 20348183
Change-Id: If1b193f933b4a7b2b322784b0cbbc66c210b25df
|
|
- Some minor cleanup and refactoring.
Bug: 20393675
Change-Id: I438a9ca222cac87c9323417a216453706393c190
|
|
Bug: 20421404
Change-Id: Icc8b4a74ea17e969577dbaaa794b85a2e66ef8df
|
|
Bug: 20348316
Change-Id: I066e6b93c63e09850ef2234dd5c724e44594aaf8
|
|
Change-Id: I3ad2277b4822d219bd53b35914befb4a4d52b45b
|
|
|
|
This isn't the prettiest thing ever, but with this the "framework" of
all of the changes for the new visual style of the call logs is in
place. From here on out, the remainder of tasks should be unblocked
and relatively independent.
+ Rename ...ItemViews to ...ItemViewHolder. This probably wasn't
completely necessary, but is more proper given the new architecture.
+ ViewHolder is now officially where most of the independent UI logic
for a single call log list item should live. This changelist moves
further in that direction by storing references and helpers in it, to
lessen what must be passed in from the adapter.
+ Split out the call action from the rest of the actions, since it
has a special treatment on the card.
+ Convert text action buttons into a vertical stack.
+ Consolidate action stylings into a single style, for simplicity.
+ Miscellaneous style and string changes to put things in a better
state. This included tweaking some of the (ripple) backgrounds.
+ Update tests, according to changes.
Bug: 19372817
Change-Id: Ic923c0bcbbc1c153952131d0c772df9e9589fb03
|
|
Bug: 20223485
Change-Id: Iaa8f140746d1266febfcacf0f007ef2b4ebba968
|
|
|
|
Bug: 20224972
Change-Id: If7f1bde0229044f60bc889b380bc3e49e043e3ff
|
|
Bug: 20160799
Change-Id: I667fb47cf261703af817a6a16405bcf56f2bf0f7
|
|
|
|
+ Added card view dependencies to makefile.
+ Convert call log list items to use card views.
+ Cleaned up code style and unused views in fragment xml.
- Removed deprecated expand code (more work to be done here).
- Removed now-unused constants.
Bug: 19372817
Change-Id: I237cf214f8f052de5fb1f41908d6012f52de994e
|
|
Change-Id: I79fa0e84dc5ba0f2f9282cd4b209c2022d740b8d
|
|
|
|
Yay, finally!
+ Replace ListView with RecyclerView in layout and fragment files.
+ Change GroupingListAdapter to extend RecyclerView.Adapter instead
of BaseAdapter.
+ Change CallLogListItemViews to extend RecyclerView.ViewHolder.
+ Adapt onBindViewHolder and onCreateViewHolder methods in the
CallLogAdapter.
+ Update/rework tests for related classes.
+ Fix a bug in the GroupingListAdapter, where childCount was not
updated for standalone views, and the previously cached group size
was used instead. Set childCount to 1 for standalone views.
- Removed the idea of creating different views for standalone vs
group vs group headers from the adapters. This logic has not been
used for quite some time and all these functions funneled into
createView/bindView methods anyways, so there is no logical
difference. If we need to create custom views in the future, we can
leverage onCreateViewHolder's viewType parameter.
Bug: 19372817
Change-Id: I1b7289340600609669db22d8bc89265240d0b561
|
|
|
|
|
|
Switch to getPhoneTtsSpannable
Bug:
Change-Id: I1024aea2a766f6ac284bc5207c0e32c29c0cb72f
|
|
- Remove custom testing method formerly in the adapter.
- Remove unused expand animate code.
Bug: 19372817
Change-Id: I78489d63ac9c3324cd80f8039d14a41813772e11
|
|
This depends on ListView footer functions, but the Call Log is being
migrated to the RecyclerView. This view will be added back later,
with that work tracked in b/20108202 in scope of M.
Bug: 20108202
Bug: 19372817
Change-Id: I55201e068362083bf5c18ebd08c2e57c97c1b827
|
|
|
|
Don't rely on setting the empty list on the ListView for controlling
visibility of the list view and empty view. Save the reference and
control this in the call log fragment.
This removes a dependency on ListView-specific functionality which
is not found in the RecyclerView.
Bug: 19372817
Change-Id: I0a7e2e2366e258013ddbe30bd2ee7efb38349421
|
|
+ Copied in from com.android.common.widget. This component is pretty
specific to phone number / call log grouping anyways.
+ Changed CallLogAdapter to reference this GroupingListAdapter
instead of the one in the framework library.
+ Changed CallLogGroupBuilder to reference this adapter too.
+ Copy in tests too.
Next step: change GroupingListAdapter to extend RecyclerView.Adapter.
This will preserve existing grouping logic, despite switching to the
new view.
Bug: 19372817
Change-Id: Ic0186ca5fad06a3ae398b9d8f8006210077149dc
|
|
- Remove animation logic in CallLogFragment.
- Remove expand listener from CallLogAdapter.
+ Update tests and constructor.
This preemptively removes expand/collapse behavior. While this
will result in a janky short-term experience, this is an incremental
step in shifting to RecyclerView and the new "Card" UI. I figured it
would be most efficient to delete it straight up, rather than coding
in intermediate logic to work with the RecyclerView because it will be
made obsolete by the Cards UI anyways.
In the long run, expand/collapse animation behavior will be
restored once the call log is migrated to RecyclerView and converted
to Cards.
Bug: 19372817
Change-Id: Icbdc7dcb9f2f2223456c29334c826d38917b087a
|
|
|
|
Bug:20064573
Change-Id: If528b7a06a9e5d1452cfbd99c6e11d7ce390038c
|
|
|
|
This was implemented formerly to prevent a crash on rotation, but
this can be done by specifying that the Report fragment should be
retained in GoogleDialer.
This means that the fragment will not be retained now if the activity
is killed off by the system, but I think this should be okay since
it is a dialog.
Bug: 19949319
Change-Id: If3ebca4625fce93d9d9ce3c9bde6d92729f21c40
|
|
|
|
- Change made in partner CL introduced a regression in dialing from
the search results:
https://partner-android-review.googlesource.com/#/c/206297/
The problem with that change is that it was intended to ensure that the +
was not stripped off when dialing from the dial pad. It had the
unintential impact of rendering direct dial from the search box inoperative.
since mAddToContactNumber was null in this case.
Bug: 20068746
Change-Id: Ic3a75ccf00164e7c865cc633a6a16d1699227ed2
|
|
This pulls code from the CallLogAdapter, with only tweaks to variable
names and comments, to create a ContactInfoCache responsible for logic
pertaining to looking up and caching contact info.
The logic is intended to be unchanged for now, although in the future
it can/should probably be cleaned up sometime.
Bug: 20038300
Change-Id: I60a57b0a665496522a6b51c9e6e41a4fd6dbad1f
|
|
This greatly improves the dialpad slidein animation on
low end devices.
Bug: 20055089
Change-Id: I17e04eeaad48b8d2245ef6d9ce5fef623588cccc
|
|
|
|
Once a ContactInfoCache is implemented, these will be changed to have
package visibility. This is an incremental step of breaking out and
moving these classes to a "contactinfo" package. The next CL will
actually implement the Cache and have more churn in terms of logic,
while this is more straightforward.
Bug: 20038300
Change-Id: Ie6082b2eeab52e25f861f2459517fff057370f82
|
|
Bug: 20038300
Change-Id: Id1636fdf6a1b15ac0c570f484e6f0c05985027e8
|
|
Bug: 19372817
Change-Id: Icddc1edd2ca1ad040a03726471a19ddc9d434d4d
|
|
Bug: 19372817
Change-Id: I92d9f001155d4a059c89bc4b00abcef4e817f32d
|
|
It will initialize itself if it does not exist, instead of relying
on getting a system service as the mechanism for initialization.
Bug: 19372817
Change-Id: Iae3eff986a79730bb2a8da9dcd4f28f664719673
|
|
|
|
There's a lot of logic around inflating/initializing which lives in
the adapter, but only really applies to the views. Move this into
the View Holder for now. This may not be its final resting place,
but in any case this seems like it can be extracted from the adapter.
Bug: 19372817
Change-Id: Ib3436ad4d8e666a8df8cb2f894e71b321ecb68da
|
|
|
|
I don't think this method has been used for quite some time, and
am uncertain what it was used for originally.
Bug: 19372817
Change-Id: I6abc7cb2699306706dd790247a038d94ed7d1583
|
|
Bug: 19949319
Change-Id: I32a2217a24915a7d862a1c9d521fc0c45f0ecb68
|
|
|
|
|
|
Log more info, to help with debugging misbehaving shortcuts.
Bug: 19406317
Change-Id: Ia1dd8e51f7129a142d23867179fd1db7ca86c865
|
|
Thsi allows Google Dialer to add a feedback option and handle its
behavior accordingly.
Bug: 19254693
Change-Id: I64ab34049406d10f53504af8d5eda9ac29758ef8
|
|
|